From patchwork Mon Dec 10 01:15:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Boichat X-Patchwork-Id: 10720493 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D1121759 for ; Mon, 10 Dec 2018 01:15:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5797C29DB6 for ; Mon, 10 Dec 2018 01:15:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B38629E16; Mon, 10 Dec 2018 01:15:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4FDB329DB6 for ; Mon, 10 Dec 2018 01:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1PIMrmMye0UNh+gH0gLvwMggDyhaKiySytllKycMoT0=; b=GyEQtKtAVy1csL ap7uMvFuGDkhWuO/1XbVY/Om/LvljysGNmgCKfAUy54FLXpaJZvVTe6yMFSWrIql0WIDem0k1fSIc a7so5+pKwf0rz7z1xu9s7HypreD/dCOmboim1vwEVFVKVOdt8eUAy4NS484yXHC9gBhnnFoKdOeUi Lq8LjySCVJmN48vrLwIkTeudjV3RVIcULguz7I0PVAD2CZOgsQzL7jJ8JuMsk/kg6zjIEIbDduiou tYfiW71HoITcux7O89/z19+vxiQfYWPD0uJ1Gje0ZfMA3RUu8zPWe3ONN3olhkXBPkZKDYOAMavxN CTlhwRcqstHaglUMVqjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWAAV-0005Gz-S3; Mon, 10 Dec 2018 01:15:31 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWAAR-0005Ff-QG for linux-arm-kernel@lists.infradead.org; Mon, 10 Dec 2018 01:15:29 +0000 Received: by mail-pl1-x644.google.com with SMTP id u18so4406718plq.7 for ; Sun, 09 Dec 2018 17:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MkSsWMVSAeJSTGMkLIBUq4R1LV61HkOQXyu0ciWvNcA=; b=IGakDlDC4jzbyobxgJg+2BtK6pRzujiaHW9b/NlUxa0oN4Q+v0nQbxHrvV6rztYHh8 d3fr24CtYwIkYSO3HiHHaG/leWfyED+lGSqnIV7h/Xbo2OepSP1vmM9e307pfWp5Ne7t 7rnRbEZVNe0rbWbSsRsAUfgBYrhNOmlCsnIq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MkSsWMVSAeJSTGMkLIBUq4R1LV61HkOQXyu0ciWvNcA=; b=N+Fkhlw1nX/KsKnBbHzK8qU4WD9H1Ni+4+L8u3XeLNMIyHEqf1b1WrX0PRO5snfz7Z 5rZu64KbHjtLRlE3RvyEUr6CunGah0oI88UzSrDE0xosCZ9JMmFzQ54YYYRVn0EF04ss I3unZyFro3ApAmY/CvvMeKFy+OUPqtCCaxo9BvB0zJ2oKeeJEAAUqwJFBeB3fRnA0goC VeC84/2oeDTaFpyq5n05O50U1LGbaQpe4yl3oz8EFrEFBA+ZOtWcaFI+h6i+jkHtnjQ6 wvH8lNMDTGth/xF2VKi7pzCeMx7Ej0LZsCGx5vG3K4NZLAIn6t4xEnDwLMXlvCD92EcV zkKA== X-Gm-Message-State: AA+aEWa3ldfuW+/6+Hq8ckzXoxCbl/3ZXpAmX+XfUDXvgBf3oWStHWw+ 8VJ/c7ludtP6FduCjZVK5WLM9w== X-Google-Smtp-Source: AFSGD/WjUF0Gawkk7vT2zAOu4MoHSXVpXqw+NlA2IDYWtN/771s4IQ/JHyV568QM+ZRV7zANefqpgA== X-Received: by 2002:a17:902:7d90:: with SMTP id a16mr9818780plm.249.1544404516350; Sun, 09 Dec 2018 17:15:16 -0800 (PST) Received: from drinkcat2.tpe.corp.google.com ([2401:fa00:1:b:f659:7f17:ea11:4e8e]) by smtp.gmail.com with ESMTPSA id b10sm16516336pfj.183.2018.12.09.17.15.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Dec 2018 17:15:15 -0800 (PST) From: Nicolas Boichat To: Will Deacon Subject: [PATCH v6 0/3] iommu/io-pgtable-arm-v7s: Use DMA32 zone for page tables Date: Mon, 10 Dec 2018 09:15:01 +0800 Message-Id: <20181210011504.122604-1-drinkcat@chromium.org> X-Mailer: git-send-email 2.20.0.rc2.403.gdbc3b29805-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181209_171527_854569_42F581E3 X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Levin Alexander , linux-mm@kvack.org, Christoph Lameter , Huaisheng Ye , Joerg Roedel , Matthew Wilcox , hch@infradead.org, linux-arm-kernel@lists.infradead.org, David Rientjes , yingjoe.chen@mediatek.com, Vlastimil Babka , Tomasz Figa , Mike Rapoport , hsinyi@chromium.org, Matthias Brugger , Joonsoo Kim , Yong Wu , Robin Murphy , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Pekka Enberg , iommu@lists.linux-foundation.org, Andrew Morton , Mel Gorman Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This is a follow-up to the discussion in [1], [2]. IOMMUs using ARMv7 short-descriptor format require page tables (level 1 and 2) to be allocated within the first 4GB of RAM, even on 64-bit systems. For L1 tables that are bigger than a page, we can just use __get_free_pages with GFP_DMA32 (on arm64 systems only, arm would still use GFP_DMA). For L2 tables that only take 1KB, it would be a waste to allocate a full page, so we considered 3 approaches: 1. This series, adding support for GFP_DMA32 slab caches. 2. genalloc, which requires pre-allocating the maximum number of L2 page tables (4096, so 4MB of memory). 3. page_frag, which is not very memory-efficient as it is unable to reuse freed fragments until the whole page is freed. [3] This series is the most memory-efficient approach. stable@ note: We confirmed that this is a regression, and IOMMU errors happen on 4.19 and linux-next/master on MT8173 (elm, Acer Chromebook R13). The issue most likely starts from commit ad67f5a6545f ("arm64: replace ZONE_DMA with ZONE_DMA32"), i.e. 4.15, and presumably breaks a number of Mediatek platforms (and maybe others?). [1] https://lists.linuxfoundation.org/pipermail/iommu/2018-November/030876.html [2] https://lists.linuxfoundation.org/pipermail/iommu/2018-December/031696.html [3] https://patchwork.codeaurora.org/patch/671639/ Changes since v1: - Add support for SLAB_CACHE_DMA32 in slab and slub (patches 1/2) - iommu/io-pgtable-arm-v7s (patch 3): - Changed approach to use SLAB_CACHE_DMA32 added by the previous commit. - Use DMA or DMA32 depending on the architecture (DMA for arm, DMA32 for arm64). Changes since v2: - Reworded and expanded commit messages - Added cache_dma32 documentation in PATCH 2/3. v3 used the page_frag approach, see [3]. Changes since v4: - Dropped change that removed GFP_DMA32 from GFP_SLAB_BUG_MASK: instead we can just call kmem_cache_*alloc without GFP_DMA32 parameter. This also means that we can drop PATCH v4 1/3, as we do not make any changes in GFP flag verification. - Dropped hunks that added cache_dma32 sysfs file, and moved the hunks to PATCH v5 3/3, so that maintainer can decide whether to pick the change independently. Changes since v5: - Rename ARM_V7S_TABLE_SLAB_CACHE to ARM_V7S_TABLE_SLAB_FLAGS. - Add stable@ to cc. Nicolas Boichat (3): mm: Add support for kmem caches in DMA32 zone iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging mm: Add /sys/kernel/slab/cache/cache_dma32 Documentation/ABI/testing/sysfs-kernel-slab | 9 +++++++++ drivers/iommu/io-pgtable-arm-v7s.c | 19 +++++++++++++++---- include/linux/slab.h | 2 ++ mm/slab.c | 2 ++ mm/slab.h | 3 ++- mm/slab_common.c | 2 +- mm/slub.c | 16 ++++++++++++++++ tools/vm/slabinfo.c | 7 ++++++- 8 files changed, 53 insertions(+), 7 deletions(-)