From patchwork Wed Dec 12 10:21:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 10726003 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF9FA159A for ; Wed, 12 Dec 2018 10:22:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEF552A508 for ; Wed, 12 Dec 2018 10:22:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B30932A51A; Wed, 12 Dec 2018 10:22:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 35A102A508 for ; Wed, 12 Dec 2018 10:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=D0O9lOGT9vhpfQ8byNThEQzXzVMhFQ3Sj9BPi/8xxIo=; b=fbVw9pXrleqL32 tDRGXcCNC2MFdDOq3uPAGD5yjgfgkwPsigiSeQL3ZzWdd30thtMl2m2AlLdRhACUaEElQk/0w+8bQ JMYLz5NQsW93Sg1/CWAzQHYwtb7H1YG8ZufTKa2LgGNsubnAHQmwa1zsaRsMJg3ZR+shgEkaZPHGj XFPCuRwGpD/yzLO/FJFt1xrjeI192H5yeBUa25m4pOLZc04nRumSdZ7HQMUks9U305F4ukr6Ts0qB bKNB9YbyVnfzXlje/CdbpDa7EP1WnZ48NVOprfp4hlUB2+vy1PIq/43G/Rn6T8Wv+jdPZsmTXTLx9 5JYPyNWl2sms9/RdrIwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX1fC-0000FC-C7; Wed, 12 Dec 2018 10:22:46 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX1eW-00086M-SA for linux-arm-kernel@lists.infradead.org; Wed, 12 Dec 2018 10:22:08 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 921D720DBC; Wed, 12 Dec 2018 11:21:53 +0100 (CET) Received: from localhost.localdomain (aaubervilliers-681-1-89-7.w90-88.abo.wanadoo.fr [90.88.30.7]) by mail.bootlin.com (Postfix) with ESMTPSA id 2517620733; Wed, 12 Dec 2018 11:21:43 +0100 (CET) From: Miquel Raynal To: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Bjorn Helgaas Subject: [PATCH v2 00/12] Bring suspend to RAM support to PCIe Aardvark driver Date: Wed, 12 Dec 2018 11:21:30 +0100 Message-Id: <20181212102142.16053-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181212_022205_411252_CD967929 X-CRM114-Status: GOOD ( 14.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Lorenzo Pieralisi , Antoine Tenart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Chevallier , Nadav Haklai , Rob Herring , Miquel Raynal , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, As part of an effort to bring suspend to RAM support to Armada 3700 SoCs (main target: ESPRESSObin), this series handles the work around the PCIe IP. First, more configuration is done in the 'setup' helper as inspired from the U-Boot driver. This is needed to entirely initialize the IP during future resume operation (patch 1). Then, reset GPIO, PHY and clock support are introduced (patch 2-4). As current device trees do not provide the corresponding properties, not finding one of these properties is not an error and just produces a warning. However, if the property is present, an error during PHY initialization will fail the probe of the driver. Note: To be sure the clock will be resumed before this driver, a first series adding links between clocks and consumers has been submitted, see [1]. Anyway, having the clock series applied first is not needed. Patch 5 adds suspend/resume hooks, re-using all the above. Finally, bindings and device trees are updated to reflect the hardware (patch 6-12). While the clock depends on the SoC, the reset GPIO and the PHY depends on the board so the clock is added in the armada-37xx.dtsi file while the two other properties are added in armada-3720-espressobin.dts. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/614527.html Thanks, Miquèl Changes since v1: ================= * Change the capitalization in commit titles to follow the PCI subsystem rules. * Added Suggested-by tag to the patch adding PHY support and to the patch adding the PHY property in the DT. * Added Rob's Reviewed-by tags on bindings. * I am following the discussion about calling functions that might sleep in a NOIRQ context. As there is no real problem yet (as per my understanding), I did not change anything on this regard. Miquel Raynal (12): PCI: aardvark: Configure more registers in the configuration helper PCI: aardvark: Add reset GPIO support PCI: aardvark: Add PHY support PCI: aardvark: Add clock support PCI: aardvark: Add suspend to RAM support dt-bindings: PCI: aardvark: Describe the reset-gpios property dt-bindings: PCI: aardvark: Describe the clocks property dt-bindings: PCI: aardvark: Describe the PHY property ARM64: dts: marvell: armada-37xx: declare PCIe reset pin ARM64: dts: marvell: armada-3720-espressobin: declare PCIe reset GPIO ARM64: dts: marvell: armada-37xx: declare PCIe clock ARM64: dts: marvell: armada-3720-espressobin: declare PCIe PHY .../devicetree/bindings/pci/aardvark-pci.txt | 9 + .../dts/marvell/armada-3720-espressobin.dts | 4 + arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 5 + drivers/pci/controller/pci-aardvark.c | 214 ++++++++++++++++++ 4 files changed, 232 insertions(+)