From patchwork Wed Dec 19 16:48:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10737743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D5E381399 for ; Wed, 19 Dec 2018 16:49:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C58022B3EA for ; Wed, 19 Dec 2018 16:49:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B9EA32B459; Wed, 19 Dec 2018 16:49:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 614822B3EA for ; Wed, 19 Dec 2018 16:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=opFYhuXH80GtB36wLrtSYca4kPFo8uASPkHTEHlBRyY=; b=XJj nJiGCD3i8xBw+4bJRjOcxw/eE3xbA2EBCbbzbnKUxAJHWu2Y4fkaVPcLwCbHMGLVsqW52hgeSWOgm dWWifascowBHuz2GZ3CvknUUZgAhVcmhycwN7yMB+FvVYCbrqJpZCTrE66Ys5YK1OhSFW78bU8JWr 7D1lrj5zTGWS5sFPC1cpnBZv4+a02Z6k0EhDJ+vHN4sXPJs8grbZjV3jeZRJnUlLohqdrfwEmNcBw zeUf9bQcU9JhDfqCVwMX0iv33XBHiJRAwfEBdO2HHztqHt/GdqNasLSQ9lQ1mkaAKDpkrVVUbXX2+ MdVEFgUVbsZKk7rx3PN1s6C6qrA0tcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZf2M-0001nn-0O; Wed, 19 Dec 2018 16:49:34 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZf1e-00011S-FG for linux-arm-kernel@lists.infradead.org; Wed, 19 Dec 2018 16:48:52 +0000 Received: from localhost (p54B333DA.dip0.t-ipconnect.de [84.179.51.218]) by pokefinder.org (Postfix) with ESMTPSA id 7E6BA2E3542; Wed, 19 Dec 2018 17:48:33 +0100 (CET) From: Wolfram Sang To: linux-i2c@vger.kernel.org Subject: [PATCH 00/10] i2c: move handling of suspended adapters to the core Date: Wed, 19 Dec 2018 17:48:16 +0100 Message-Id: <20181219164827.20985-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181219_084850_718241_BAFB4C11 X-CRM114-Status: UNSURE ( 8.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Wolfram Sang , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Hans de Goede , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Finally, here is the implementation Hans and I agreed on. Plus, all potential users I could spot already converted. Renesas R-Car driver was added on top. This series was tested on a Renesas Lager board (R-Car H2). I had to hack some error cases into the code to verify the workings. Thanks for all the tests so far. Of course, more testing never hurts ;) Please comment, review, test... a branch can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/i2c/core-pm-helpers Thanks, Wolfram Changes since RFC: * don't use bitfields anymore but an unsigned long flags variable which is only meant for flags to be changed when the adapter lock is held * split the genereic accessor into _mark_suspended() and _mark_resumed() * added kerneldoc and noted that using these helpers is optional * documented -ESHUTDOWN as the error code when trying to transfer using an already suspended adapter * added acks from last series. Changes were minor enough to keep them. Please let me know if you disagree. Wolfram Sang (10): i2c: add suspended flag and accessors for i2c adapters i2c: reject new transfers when adapters are suspended i2c: synquacer: remove unused is_suspended flag i2c: brcmstb: use core helper to mark adapter suspended i2c: zx2967: use core helper to mark adapter suspended i2c: sprd: don't use pdev as variable name for struct device * i2c: sprd: use core helper to mark adapter suspended i2c: exynos5: use core helper to mark adapter suspended i2c: s3c2410: use core helper to mark adapter suspended i2c: rcar: add suspend/resume support Documentation/i2c/fault-codes | 4 ++++ drivers/i2c/busses/i2c-brcmstb.c | 13 ++----------- drivers/i2c/busses/i2c-exynos5.c | 11 ++--------- drivers/i2c/busses/i2c-rcar.c | 25 +++++++++++++++++++++++++ drivers/i2c/busses/i2c-s3c2410.c | 8 ++------ drivers/i2c/busses/i2c-sprd.c | 34 ++++++++++++---------------------- drivers/i2c/busses/i2c-synquacer.c | 5 ----- drivers/i2c/busses/i2c-zx2967.c | 8 ++------ drivers/i2c/i2c-core-base.c | 3 +++ include/linux/i2c.h | 34 ++++++++++++++++++++++++++++++++++ 10 files changed, 86 insertions(+), 59 deletions(-)