| Message ID | 20190527200627.8635-1-peron.clem@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Allwinner H6 SPDIF support | expand |
Hi, On Mon, 27 May 2019 at 22:10, Clément Péron <peron.clem@gmail.com> wrote: > > *H6 DMA support IS REQUIRED* DMA has been merged, so this series can be merge when ASoC maintainers have reviewed it. Regards, Clément > > Allwinner H6 SoC has a SPDIF controller called One Wire Audio (OWA) which > is different from the previous H3 generation and not compatible. > > Difference are an increase of fifo sizes, some memory mapping are different > and there is now the possibility to output the master clock on a pin. > > Actually all these features are unused and only a bit for flushing the TX > fifo is required. > > Also this series requires the DMA working on H6, a first version has been > submitted by Jernej Škrabec[1] but has not been accepted yet. > > [1] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=89011 > > Changes since v3: > - rename reg_fctl_ftx to val_fctl_ftx > - rebase this series on sound-next > - fix dt-bindings due to change in sound-next > - change node name sound_spdif to sound-spdif > > Changes since v2: > - Split quirks and H6 support patch > - Add specific section for quirks comment > > Changes since v1: > - Remove H3 compatible > - Add TX fifo bit flush quirks > - Add H6 bindings in SPDIF driver > > Clément Péron (7): > dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible > ASoC: sun4i-spdif: Move quirks to the top > ASoC: sun4i-spdif: Add TX fifo bit flush quirks > ASoC: sun4i-spdif: Add support for H6 SoC > arm64: dts: allwinner: Add SPDIF node for Allwinner H6 > arm64: dts: allwinner: h6: Enable SPDIF for Beelink GS1 > arm64: defconfig: Enable Sun4i SPDIF module > > .../sound/allwinner,sun4i-a10-spdif.yaml | 1 + > .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 4 ++ > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 ++++++++++++++ > arch/arm64/configs/defconfig | 1 + > sound/soc/sunxi/sun4i-spdif.c | 49 ++++++++++++++++--- > 5 files changed, 87 insertions(+), 6 deletions(-) > > -- > 2.20.1 >
Hi, I'm missing ACK from ASoC Maintainers patch 2-3-4. It's really small paches, if you could have a look at it. Many thanks, Clément On Fri, 14 Jun 2019 at 10:29, Clément Péron <peron.clem@gmail.com> wrote: > > Hi, > > On Mon, 27 May 2019 at 22:10, Clément Péron <peron.clem@gmail.com> wrote: > > > > *H6 DMA support IS REQUIRED* > > DMA has been merged, so this series can be merge when ASoC maintainers > have reviewed it. > > Regards, > Clément > > > > > Allwinner H6 SoC has a SPDIF controller called One Wire Audio (OWA) which > > is different from the previous H3 generation and not compatible. > > > > Difference are an increase of fifo sizes, some memory mapping are different > > and there is now the possibility to output the master clock on a pin. > > > > Actually all these features are unused and only a bit for flushing the TX > > fifo is required. > > > > Also this series requires the DMA working on H6, a first version has been > > submitted by Jernej Škrabec[1] but has not been accepted yet. > > > > [1] https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=89011 > > > > Changes since v3: > > - rename reg_fctl_ftx to val_fctl_ftx > > - rebase this series on sound-next > > - fix dt-bindings due to change in sound-next > > - change node name sound_spdif to sound-spdif > > > > Changes since v2: > > - Split quirks and H6 support patch > > - Add specific section for quirks comment > > > > Changes since v1: > > - Remove H3 compatible > > - Add TX fifo bit flush quirks > > - Add H6 bindings in SPDIF driver > > > > Clément Péron (7): > > dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible > > ASoC: sun4i-spdif: Move quirks to the top > > ASoC: sun4i-spdif: Add TX fifo bit flush quirks > > ASoC: sun4i-spdif: Add support for H6 SoC > > arm64: dts: allwinner: Add SPDIF node for Allwinner H6 > > arm64: dts: allwinner: h6: Enable SPDIF for Beelink GS1 > > arm64: defconfig: Enable Sun4i SPDIF module > > > > .../sound/allwinner,sun4i-a10-spdif.yaml | 1 + > > .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 4 ++ > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 ++++++++++++++ > > arch/arm64/configs/defconfig | 1 + > > sound/soc/sunxi/sun4i-spdif.c | 49 ++++++++++++++++--- > > 5 files changed, 87 insertions(+), 6 deletions(-) > > > > -- > > 2.20.1 > >
On Mon, Jul 15, 2019 at 09:21:01PM +0200, Clément Péron wrote: > Hi, > > I'm missing ACK from ASoC Maintainers patch 2-3-4. > > It's really small paches, if you could have a look at it. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
Hi, Sorry, I just discovered that the ASoC patches have been merged into the broonie and linus tree in 5.3. I'm still quite new in the sending of patches to the Kernel but souldn't be a ack or a mail sent to warn the sender when the series are accepted? Should 5/6/7 patches be picked by Sunxi maintainer? Thanks, Clément On Mon, 15 Jul 2019 at 21:38, Mark Brown <broonie@kernel.org> wrote: > > On Mon, Jul 15, 2019 at 09:21:01PM +0200, Clément Péron wrote: > > Hi, > > > > I'm missing ACK from ASoC Maintainers patch 2-3-4. > > > > It's really small paches, if you could have a look at it. > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. > > Sending content free pings adds to the mail volume (if they are seen at > all) which is often the problem and since they can't be reviewed > directly if something has gone wrong you'll have to resend the patches > anyway, so sending again is generally a better approach though there are > some other maintainers who like them - if in doubt look at how patches > for the subsystem are normally handled.
On Sat, Aug 10, 2019 at 10:45:23AM +0200, Clément Péron wrote: > Hi, Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. > Sorry, I just discovered that the ASoC patches have been merged into > the broonie and linus tree in 5.3. > I'm still quite new in the sending of patches to the Kernel but > souldn't be a ack or a mail sent to warn the sender when the series > are accepted? Not every maintainer will send those, I do but you might find they've gone into your spam folder if you're using gmail.
Hi Mark, On Mon, 12 Aug 2019 at 13:01, Mark Brown <broonie@kernel.org> wrote: > > On Sat, Aug 10, 2019 at 10:45:23AM +0200, Clément Péron wrote: > > > Hi, > > Please don't top post, reply in line with needed context. This allows > readers to readily follow the flow of conversation and understand what > you are talking about and also helps ensure that everything in the > discussion is being addressed. > > > Sorry, I just discovered that the ASoC patches have been merged into > > the broonie and linus tree in 5.3. > > > I'm still quite new in the sending of patches to the Kernel but > > souldn't be a ack or a mail sent to warn the sender when the series > > are accepted? > > Not every maintainer will send those, I do but you might find they've > gone into your spam folder if you're using gmail. Thank you very much for the answer, Regards, Clément