mbox series

[v3,0/5] arm64: vdso32: Address various issues

Message ID 20190926214342.34608-1-vincenzo.frascino@arm.com (mailing list archive)
Headers show
Series arm64: vdso32: Address various issues | expand

Message

Vincenzo Frascino Sept. 26, 2019, 9:43 p.m. UTC 
Hi Will,

this patch series is meant to address the various compilation issues you
reported about arm64 vdso32.

Please let me know if there is still something missing.

Thanks,
Vincenzo

Cc: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>

---

v3:
   - Exposed COMPATCC
   - Addressed Review Comments

v2:
   - Fixed binutils detection
   - Addressed review comments

Vincenzo Frascino (5):
  arm64: vdso32: Introduce COMPAT_CC_IS_GCC
  arm64: vdso32: Detect binutils support for dmb ishld
  arm64: vdso32: Fix compilation warning
  arm64: Remove gettimeofday.S
  arm64: vdso32: Remove jump label config option in Makefile

 arch/arm64/Kconfig                           |  5 ++++-
 arch/arm64/Makefile                          | 18 +++++-------------
 arch/arm64/include/asm/memory.h              |  3 +++
 arch/arm64/include/asm/vdso/compat_barrier.h |  2 +-
 arch/arm64/kernel/vdso/gettimeofday.S        |  0
 arch/arm64/kernel/vdso32/Makefile            | 14 +++++++++-----
 6 files changed, 22 insertions(+), 20 deletions(-)
 delete mode 100644 arch/arm64/kernel/vdso/gettimeofday.S

Comments

Catalin Marinas Sept. 27, 2019, 10:46 a.m. UTC | #1 
On Thu, Sep 26, 2019 at 10:43:37PM +0100, Vincenzo Frascino wrote:
> Vincenzo Frascino (5):
>   arm64: vdso32: Introduce COMPAT_CC_IS_GCC
>   arm64: vdso32: Detect binutils support for dmb ishld
>   arm64: vdso32: Fix compilation warning
>   arm64: Remove gettimeofday.S
>   arm64: vdso32: Remove jump label config option in Makefile

You can add this as well:

Tested-by: Catalin Marinas <catalin.marinas@arm.com>
Will Deacon Oct. 1, 2019, 1:27 p.m. UTC | #2 
On Thu, Sep 26, 2019 at 10:43:37PM +0100, Vincenzo Frascino wrote:
> this patch series is meant to address the various compilation issues you
> reported about arm64 vdso32.

Thanks, I've commented on the patches. Also, when you respin, please can
you drop the "As reported by Will Deacon ..." lines from the commit messages
and just add a Reported-by tag instead?

Thanks,

Will