mbox series

[v3,0/4] crypto: add sun8i-ss driver for Allwinner Security System

Message ID 20191025185128.24068-1-clabbe.montjoie@gmail.com (mailing list archive)
Headers show
Series crypto: add sun8i-ss driver for Allwinner Security System | expand

Message

Corentin Labbe Oct. 25, 2019, 6:51 p.m. UTC
Hello

This patch serie adds support for the second version of Allwinner Security System.
The first generation of the Security System is already handled by the sun4i-ss driver.
Due to major change, the first driver cannot handle the second one.
This new Security System is present on A80 and A83T SoCs.

For the moment, the driver support only DES3/AES in ECB/CBC mode.
Patchs for CTR/CTS, RSA and RNGs will came later.

This serie is tested with CRYPTO_MANAGER_EXTRA_TESTS
and tested on:
sun8i-a83t-bananapi-m3
sun9i-a80-cubieboard4

This serie is based on top of the "crypto: add sun8i-ce driver for
Allwinner crypto engine" serie.

Regards

Changes since v2:
- Made the reset mandatory
- Removed reset-names

Changes since v1:
- fixed uninitialized err in sun8i_ss_allocate_chanlist
- Added missing commit description on DT Documentation patch

Corentin Labbe (4):
  crypto: Add Allwinner sun8i-ss cryptographic offloader
  dt-bindings: crypto: Add DT bindings documentation for sun8i-ss
    Security System
  ARM: dts: sun8i: a83t: Add Security System node
  ARM: dts: sun9i: a80: Add Security System node

 .../bindings/crypto/allwinner,sun8i-ss.yaml   |  61 ++
 arch/arm/boot/dts/sun8i-a83t.dtsi             |   9 +
 arch/arm/boot/dts/sun9i-a80.dtsi              |   9 +
 drivers/crypto/allwinner/Kconfig              |  28 +
 drivers/crypto/allwinner/Makefile             |   1 +
 drivers/crypto/allwinner/sun8i-ss/Makefile    |   2 +
 .../allwinner/sun8i-ss/sun8i-ss-cipher.c      | 438 ++++++++++++
 .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 642 ++++++++++++++++++
 drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h  | 218 ++++++
 9 files changed, 1408 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
 create mode 100644 drivers/crypto/allwinner/sun8i-ss/Makefile
 create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
 create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
 create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h

Comments

Herbert Xu Nov. 1, 2019, 6:11 a.m. UTC | #1
On Fri, Oct 25, 2019 at 08:51:24PM +0200, Corentin Labbe wrote:
> Hello
> 
> This patch serie adds support for the second version of Allwinner Security System.
> The first generation of the Security System is already handled by the sun4i-ss driver.
> Due to major change, the first driver cannot handle the second one.
> This new Security System is present on A80 and A83T SoCs.
> 
> For the moment, the driver support only DES3/AES in ECB/CBC mode.
> Patchs for CTR/CTS, RSA and RNGs will came later.
> 
> This serie is tested with CRYPTO_MANAGER_EXTRA_TESTS
> and tested on:
> sun8i-a83t-bananapi-m3
> sun9i-a80-cubieboard4
> 
> This serie is based on top of the "crypto: add sun8i-ce driver for
> Allwinner crypto engine" serie.
> 
> Regards
> 
> Changes since v2:
> - Made the reset mandatory
> - Removed reset-names
> 
> Changes since v1:
> - fixed uninitialized err in sun8i_ss_allocate_chanlist
> - Added missing commit description on DT Documentation patch
> 
> Corentin Labbe (4):
>   crypto: Add Allwinner sun8i-ss cryptographic offloader
>   dt-bindings: crypto: Add DT bindings documentation for sun8i-ss
>     Security System
>   ARM: dts: sun8i: a83t: Add Security System node
>   ARM: dts: sun9i: a80: Add Security System node
> 
>  .../bindings/crypto/allwinner,sun8i-ss.yaml   |  61 ++
>  arch/arm/boot/dts/sun8i-a83t.dtsi             |   9 +
>  arch/arm/boot/dts/sun9i-a80.dtsi              |   9 +
>  drivers/crypto/allwinner/Kconfig              |  28 +
>  drivers/crypto/allwinner/Makefile             |   1 +
>  drivers/crypto/allwinner/sun8i-ss/Makefile    |   2 +
>  .../allwinner/sun8i-ss/sun8i-ss-cipher.c      | 438 ++++++++++++
>  .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 642 ++++++++++++++++++
>  drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h  | 218 ++++++
>  9 files changed, 1408 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
>  create mode 100644 drivers/crypto/allwinner/sun8i-ss/Makefile
>  create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
>  create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
>  create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h

Patches 1,2 applied.  Thanks.
Maxime Ripard Nov. 1, 2019, 8:58 a.m. UTC | #2
On Fri, Nov 01, 2019 at 02:11:54PM +0800, Herbert Xu wrote:
> On Fri, Oct 25, 2019 at 08:51:24PM +0200, Corentin Labbe wrote:
> > Hello
> >
> > This patch serie adds support for the second version of Allwinner Security System.
> > The first generation of the Security System is already handled by the sun4i-ss driver.
> > Due to major change, the first driver cannot handle the second one.
> > This new Security System is present on A80 and A83T SoCs.
> >
> > For the moment, the driver support only DES3/AES in ECB/CBC mode.
> > Patchs for CTR/CTS, RSA and RNGs will came later.
> >
> > This serie is tested with CRYPTO_MANAGER_EXTRA_TESTS
> > and tested on:
> > sun8i-a83t-bananapi-m3
> > sun9i-a80-cubieboard4
> >
> > This serie is based on top of the "crypto: add sun8i-ce driver for
> > Allwinner crypto engine" serie.
> >
> > Regards
> >
> > Changes since v2:
> > - Made the reset mandatory
> > - Removed reset-names
> >
> > Changes since v1:
> > - fixed uninitialized err in sun8i_ss_allocate_chanlist
> > - Added missing commit description on DT Documentation patch
> >
> > Corentin Labbe (4):
> >   crypto: Add Allwinner sun8i-ss cryptographic offloader
> >   dt-bindings: crypto: Add DT bindings documentation for sun8i-ss
> >     Security System
> >   ARM: dts: sun8i: a83t: Add Security System node
> >   ARM: dts: sun9i: a80: Add Security System node
> >
> >  .../bindings/crypto/allwinner,sun8i-ss.yaml   |  61 ++
> >  arch/arm/boot/dts/sun8i-a83t.dtsi             |   9 +
> >  arch/arm/boot/dts/sun9i-a80.dtsi              |   9 +
> >  drivers/crypto/allwinner/Kconfig              |  28 +
> >  drivers/crypto/allwinner/Makefile             |   1 +
> >  drivers/crypto/allwinner/sun8i-ss/Makefile    |   2 +
> >  .../allwinner/sun8i-ss/sun8i-ss-cipher.c      | 438 ++++++++++++
> >  .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 642 ++++++++++++++++++
> >  drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h  | 218 ++++++
> >  9 files changed, 1408 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ss.yaml
> >  create mode 100644 drivers/crypto/allwinner/sun8i-ss/Makefile
> >  create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
> >  create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
> >  create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss.h
>
> Patches 1,2 applied.  Thanks.

Applied 3 and 4, thanks!
Maxime