| Message ID | 20191230082734.28954-1-rppt@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm/arm64: add support for folded p4d page tables | expand |
On 12/30/2019 01:57 PM, Mike Rapoport wrote: > From: Mike Rapoport <rppt@linux.ibm.com> > > Hi, Hello Mike, > > This is a part of clean up of the page table manipulation code that aims to > remove asm-generic/5level-fixup.h and asm-generic/pgtable-nop4d-hack.h > > There is a single patch for both arm and arm64 because doing the conversion > separately would mean breaking the shared mmu bits in virt/kvm/arm. > > The patch is build tested and boot tested on qemu-system-{arm,aarch64}. There are lots of code changes here for a single patch but as you have mentioned shared KVM bits would have prevented splitting arm and arm64 changes into separate patches. Just curious, are you planning to respin this patch sooner after fixing the reported build problems caused by missing p4d_offset_kimg() and p4d_sect() definitions ? - Anshuman
On Thu, Jan 09, 2020 at 08:38:54AM +0530, Anshuman Khandual wrote: > > > On 12/30/2019 01:57 PM, Mike Rapoport wrote: > > From: Mike Rapoport <rppt@linux.ibm.com> > > > > Hi, > > Hello Mike, > > > > > This is a part of clean up of the page table manipulation code that aims to > > remove asm-generic/5level-fixup.h and asm-generic/pgtable-nop4d-hack.h > > > > There is a single patch for both arm and arm64 because doing the conversion > > separately would mean breaking the shared mmu bits in virt/kvm/arm. > > > > The patch is build tested and boot tested on qemu-system-{arm,aarch64}. > > There are lots of code changes here for a single patch but as you have > mentioned shared KVM bits would have prevented splitting arm and arm64 > changes into separate patches. Just curious, are you planning to respin > this patch sooner after fixing the reported build problems caused by > missing p4d_offset_kimg() and p4d_sect() definitions ? Well, I was waiting to see if there was some feedback except kbuild robot response :) I'm planning to send v2 soon, probably next week. > - Anshuman
From: Mike Rapoport <rppt@linux.ibm.com> Hi, This is a part of clean up of the page table manipulation code that aims to remove asm-generic/5level-fixup.h and asm-generic/pgtable-nop4d-hack.h There is a single patch for both arm and arm64 because doing the conversion separately would mean breaking the shared mmu bits in virt/kvm/arm. The patch is build tested and boot tested on qemu-system-{arm,aarch64}. Mike Rapoport (1): arm/arm64: add support for folded p4d page tables arch/arm/include/asm/kvm_mmu.h | 5 +- arch/arm/include/asm/pgtable.h | 1 - arch/arm/include/asm/stage2_pgtable.h | 15 +- arch/arm/lib/uaccess_with_memcpy.c | 9 +- arch/arm/mach-sa1100/assabet.c | 2 +- arch/arm/mm/dump.c | 29 +++- arch/arm/mm/fault-armv.c | 7 +- arch/arm/mm/fault.c | 28 +++- arch/arm/mm/idmap.c | 3 +- arch/arm/mm/init.c | 2 +- arch/arm/mm/ioremap.c | 12 +- arch/arm/mm/mm.h | 2 +- arch/arm/mm/mmu.c | 35 +++- arch/arm/mm/pgd.c | 40 ++++- arch/arm64/include/asm/kvm_mmu.h | 10 +- arch/arm64/include/asm/pgalloc.h | 10 +- arch/arm64/include/asm/pgtable-types.h | 5 +- arch/arm64/include/asm/pgtable.h | 37 +++-- arch/arm64/include/asm/stage2_pgtable.h | 48 ++++-- arch/arm64/kernel/hibernate.c | 46 +++++- arch/arm64/mm/dump.c | 29 +++- arch/arm64/mm/fault.c | 9 +- arch/arm64/mm/hugetlbpage.c | 15 +- arch/arm64/mm/kasan_init.c | 41 ++++- arch/arm64/mm/mmu.c | 52 ++++-- arch/arm64/mm/pageattr.c | 7 +- virt/kvm/arm/mmu.c | 209 ++++++++++++++++++++---- 27 files changed, 565 insertions(+), 143 deletions(-)