From patchwork Wed Feb 5 08:55:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ong Boon Leong X-Patchwork-Id: 11365895 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A263413A4 for ; Wed, 5 Feb 2020 08:55:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80EF42082E for ; Wed, 5 Feb 2020 08:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pqaSkxHR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80EF42082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=IeAjx52MRs0uRf5sJoa5lyujuCuPj0IizQ+soHRbTU8=; b=pqa SkxHRPN687DvFA/81ijDFjiHjglFwISv/RZcIXf7iA5DnQEwvSGpKzTxXzDnjwLMutpnsTI/+tnFl k1Z7Ixngitn5tibwRPYMgd0DSVMyLeivaGR3Hf3AeHD4rIMMv1TIBnf3fZWPP/WPlBZMTKW7ARRYd b/izECDJBTF6gSgMjL0ZT+/bIoio4vvV+r/kurXbyd6KayC29zeotpMaOkpUk80nO8S02hdOvQT+3 7Z+hQ3O12QncQ7GsLS7FHW85qoS6dHlaksVTN1ZAcEJGj4mkclsDFuXF3Jl9P7kdsMLDFuEQ26vzX mdSpWrSUHlSWxkUxvAzX7ha0hj3NYBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izGTD-0004kk-8T; Wed, 05 Feb 2020 08:55:39 +0000 Received: from mga06.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izGTA-0004iv-9N for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2020 08:55:37 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 00:55:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="264149167" Received: from unknown (HELO bong5-HP-Z440.png.intel.com) ([10.221.118.166]) by fmsmga002.fm.intel.com with ESMTP; 05 Feb 2020 00:55:29 -0800 From: Ong Boon Leong To: netdev@vger.kernel.org Subject: [PATCH net v4 0/6] net: stmmac: general fixes for Ethernet functionality Date: Wed, 5 Feb 2020 16:55:04 +0800 Message-Id: <20200205085510.32353-1-boon.leong.ong@intel.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_005536_391663_6DDCAC16 X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [134.134.136.31 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.1 AC_FROM_MANY_DOTS Multiple periods in From user name X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , Joao Pinto , Alexandre TORGUE , Voon Weifeng , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Arnd Bergmann , Maxime Coquelin , Tan Tee Min , Giuseppe Cavallaro , Alexandru Ardelean , "David S . Miller" , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Thanks to all feedbacks from community. We updated the patch-series to below:- 1/6: It ensures that the real_num_rx|tx_queues are set in both driver probe() and resume(). So, move the netif_set_real_num_rx|tx_queues() into stmmac_hw_setup(). Use rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume(). 2/6: It ensures that the previous value of GMAC_VLAN_TAG register is read first before for updating the register. 3/6: Similar to 2/6 patch but it is a fix for XGMAC_VLAN_TAG register as requested by Jose Abreu. 4/6: It ensures the GMAC IP v4.xx and above behaves correctly to:- ip link set multicast off|on 5/6: Added similar IFF_MULTICAST flag for xgmac2, similar to 4/6. 6/6: It ensures PCI platform data is using plat->phy_interface. Rgds, Boon Leong Changes from v3:- patch 1/6 - add rtnl_lock() and rtnl_unlock() for stmmac_hw_setup() called inside stmmac_resume() patch 3/6 - Added new patch to fix XGMAC_VLAN_TAG register writting v2:- patch 1/5 - added control for rtnl_lock() & rtnl_unlock() to ensure they are used forstmmac_resume() patch 4/5 - added IFF_MULTICAST flag check for xgmac to ensure multicast works correctly. v1:- - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid. Aashish Verma (1): net: stmmac: Fix incorrect location to set real_num_rx|tx_queues Ong Boon Leong (1): net: stmmac: xgmac: fix incorrect XGMAC_VLAN_TAG register writting Tan, Tee Min (2): net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter Verma, Aashish (1): net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter Voon Weifeng (1): net: stmmac: update pci platform data to use phy_interface drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++---- .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 10 +++++++--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++---- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 4 files changed, 26 insertions(+), 17 deletions(-)