mbox series

[0/8] net: ll_temac: Bugfixes and ethtool support

Message ID 20200218082607.7035-1-esben@geanix.com (mailing list archive)
Headers show
Series net: ll_temac: Bugfixes and ethtool support | expand

Message

Esben Haabendal Feb. 18, 2020, 8:26 a.m. UTC
Patch 1-4 brings fixes a number of bugs observed.
Patch 5-6 are simple cleanup, removing two unused struct fields.
Patch 7-8 add ethtool support for controlling rx and tx ring sizes and irq
coalesce parameters.

Esben Haabendal (9):
  net: ll_temac: Fix race condition causing TX hang
  net: ll_temac: Add more error handling of dma_map_single() calls
  net: ll_temac: Fix RX buffer descriptor handling on GFP_ATOMIC
    pressure
  net: ll_temac: Handle DMA halt condition caused by buffer underrun
  net: ll_temac: Remove unused tx_bd_next struct field
  net: ll_temac: Remove unused start_p variable
  net: ll_temac: Make RX/TX ring sizes configurable
  net: ll_temac: Add ethtool support for coalesce parameters

 drivers/net/ethernet/xilinx/ll_temac.h      |  12 +-
 drivers/net/ethernet/xilinx/ll_temac_main.c | 435 ++++++++++++++++----
 2 files changed, 367 insertions(+), 80 deletions(-)

Comments

David Miller Feb. 18, 2020, 7:50 p.m. UTC | #1
Several errors in this submission:

1) Do not mix bug fixes and new features.  Submit the bug fixes
   targetting 'net', and then wait for net to be merged into
   net-next at which time you can submit the new features on
   top.

2) As per Documentation/networking/netdev-FAQ.rst you should not
   ever CC: stable for networking patches, we submit bug fixes to
   stable ourselves.

Thank you.
Esben Haabendal Feb. 19, 2020, 10:53 a.m. UTC | #2
David Miller <davem@davemloft.net> writes:

> Several errors in this submission:
>
> 1) Do not mix bug fixes and new features.  Submit the bug fixes
>    targetting 'net', and then wait for net to be merged into
>    net-next at which time you can submit the new features on
>    top.
>
> 2) As per Documentation/networking/netdev-FAQ.rst you should not
>    ever CC: stable for networking patches, we submit bug fixes to
>    stable ourselves.

Got it.  I will resend against net and net-next.

/Esben