mbox series

[v2,00/11] Raspbery Pi 4 vmmc regulator support

Message ID 20200306174413.20634-1-nsaenzjulienne@suse.de (mailing list archive)
Headers show
Series Raspbery Pi 4 vmmc regulator support | expand

Message

Nicolas Saenz Julienne March 6, 2020, 5:44 p.m. UTC
The series first cleans up a common pattern, which is ultimately needed
to integrate the regulator with bcm2711's sdhci-iproc. It then
introduces the relevant device-tree changes.

---

Changes since v1:
 - Use helper function istead of quirk
 - Add GPIO label

Nicolas Saenz Julienne (11):
  mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage()
  mmc: sdhci: arasan: Use sdhci_set_power_and_voltage()
  mmc: sdhci: milbeaut: Use sdhci_set_power_and_voltage()
  mmc: sdhci: at91: Use sdhci_set_power_and_voltage()
  mmc: sdhci: pxav3: Use sdhci_set_power_and_voltage()
  mmc: sdhci: xenon: Use sdhci_set_power_and_voltage()
  mmc: sdhci: am654: Use sdhci_set_power_and_voltage()
  mmc: sdhci: Unexport sdhci_set_power_noreg()
  mmc: sdhci: iproc: Add custom set_power() callback for bcm2711
  ARM: dts: bcm2711: Update expgpio's GPIO labels
  ARM: dts: bcm2711: Add vmmc regulator in emmc2

 arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 13 ++++++++++++-
 drivers/mmc/host/sdhci-iproc.c        | 17 ++++++++++++++++-
 drivers/mmc/host/sdhci-milbeaut.c     | 13 +------------
 drivers/mmc/host/sdhci-of-arasan.c    | 15 ++-------------
 drivers/mmc/host/sdhci-of-at91.c      | 18 +-----------------
 drivers/mmc/host/sdhci-pxav3.c        | 20 +-------------------
 drivers/mmc/host/sdhci-xenon.c        | 20 +-------------------
 drivers/mmc/host/sdhci.c              | 24 +++++++++++++++++++++---
 drivers/mmc/host/sdhci.h              |  5 +++--
 drivers/mmc/host/sdhci_am654.c        | 17 +++--------------
 10 files changed, 61 insertions(+), 101 deletions(-)

Comments

Ulf Hansson March 12, 2020, 1:08 p.m. UTC | #1
On Fri, 6 Mar 2020 at 18:44, Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> The series first cleans up a common pattern, which is ultimately needed
> to integrate the regulator with bcm2711's sdhci-iproc. It then
> introduces the relevant device-tree changes.
>
> ---
>
> Changes since v1:
>  - Use helper function istead of quirk
>  - Add GPIO label
>
> Nicolas Saenz Julienne (11):
>   mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage()
>   mmc: sdhci: arasan: Use sdhci_set_power_and_voltage()
>   mmc: sdhci: milbeaut: Use sdhci_set_power_and_voltage()
>   mmc: sdhci: at91: Use sdhci_set_power_and_voltage()
>   mmc: sdhci: pxav3: Use sdhci_set_power_and_voltage()
>   mmc: sdhci: xenon: Use sdhci_set_power_and_voltage()
>   mmc: sdhci: am654: Use sdhci_set_power_and_voltage()
>   mmc: sdhci: Unexport sdhci_set_power_noreg()
>   mmc: sdhci: iproc: Add custom set_power() callback for bcm2711
>   ARM: dts: bcm2711: Update expgpio's GPIO labels
>   ARM: dts: bcm2711: Add vmmc regulator in emmc2
>
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 13 ++++++++++++-
>  drivers/mmc/host/sdhci-iproc.c        | 17 ++++++++++++++++-
>  drivers/mmc/host/sdhci-milbeaut.c     | 13 +------------
>  drivers/mmc/host/sdhci-of-arasan.c    | 15 ++-------------
>  drivers/mmc/host/sdhci-of-at91.c      | 18 +-----------------
>  drivers/mmc/host/sdhci-pxav3.c        | 20 +-------------------
>  drivers/mmc/host/sdhci-xenon.c        | 20 +-------------------
>  drivers/mmc/host/sdhci.c              | 24 +++++++++++++++++++++---
>  drivers/mmc/host/sdhci.h              |  5 +++--
>  drivers/mmc/host/sdhci_am654.c        | 17 +++--------------
>  10 files changed, 61 insertions(+), 101 deletions(-)
>
> --
> 2.25.1
>

Patch 1-4, 6, 9 applied for next, thanks!

Kind regards
Uffe
Nicolas Saenz Julienne March 12, 2020, 1:13 p.m. UTC | #2
Hi Ulf,

On Thu, 2020-03-12 at 14:08 +0100, Ulf Hansson wrote:
> On Fri, 6 Mar 2020 at 18:44, Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> > The series first cleans up a common pattern, which is ultimately needed
> > to integrate the regulator with bcm2711's sdhci-iproc. It then
> > introduces the relevant device-tree changes.
> > 
> > ---
> > 
> > Changes since v1:
> >  - Use helper function istead of quirk
> >  - Add GPIO label
> > 
> > Nicolas Saenz Julienne (11):
> >   mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage()
> >   mmc: sdhci: arasan: Use sdhci_set_power_and_voltage()
> >   mmc: sdhci: milbeaut: Use sdhci_set_power_and_voltage()
> >   mmc: sdhci: at91: Use sdhci_set_power_and_voltage()
> >   mmc: sdhci: pxav3: Use sdhci_set_power_and_voltage()
> >   mmc: sdhci: xenon: Use sdhci_set_power_and_voltage()
> >   mmc: sdhci: am654: Use sdhci_set_power_and_voltage()
> >   mmc: sdhci: Unexport sdhci_set_power_noreg()
> >   mmc: sdhci: iproc: Add custom set_power() callback for bcm2711
> >   ARM: dts: bcm2711: Update expgpio's GPIO labels
> >   ARM: dts: bcm2711: Add vmmc regulator in emmc2
> > 
> >  arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 13 ++++++++++++-
> >  drivers/mmc/host/sdhci-iproc.c        | 17 ++++++++++++++++-
> >  drivers/mmc/host/sdhci-milbeaut.c     | 13 +------------
> >  drivers/mmc/host/sdhci-of-arasan.c    | 15 ++-------------
> >  drivers/mmc/host/sdhci-of-at91.c      | 18 +-----------------
> >  drivers/mmc/host/sdhci-pxav3.c        | 20 +-------------------
> >  drivers/mmc/host/sdhci-xenon.c        | 20 +-------------------
> >  drivers/mmc/host/sdhci.c              | 24 +++++++++++++++++++++---
> >  drivers/mmc/host/sdhci.h              |  5 +++--
> >  drivers/mmc/host/sdhci_am654.c        | 17 +++--------------
> >  10 files changed, 61 insertions(+), 101 deletions(-)
> > 
> > --
> > 2.25.1
> > 
> 
> Patch 1-4, 6, 9 applied for next, thanks!

I think you meant to apply 1-4, 7 and 9. Patch 6 is one of the contentious
ones.

Regards,
Nicolas
Ulf Hansson March 12, 2020, 2:06 p.m. UTC | #3
On Thu, 12 Mar 2020 at 14:13, Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Hi Ulf,
>
> On Thu, 2020-03-12 at 14:08 +0100, Ulf Hansson wrote:
> > On Fri, 6 Mar 2020 at 18:44, Nicolas Saenz Julienne
> > <nsaenzjulienne@suse.de> wrote:
> > > The series first cleans up a common pattern, which is ultimately needed
> > > to integrate the regulator with bcm2711's sdhci-iproc. It then
> > > introduces the relevant device-tree changes.
> > >
> > > ---
> > >
> > > Changes since v1:
> > >  - Use helper function istead of quirk
> > >  - Add GPIO label
> > >
> > > Nicolas Saenz Julienne (11):
> > >   mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage()
> > >   mmc: sdhci: arasan: Use sdhci_set_power_and_voltage()
> > >   mmc: sdhci: milbeaut: Use sdhci_set_power_and_voltage()
> > >   mmc: sdhci: at91: Use sdhci_set_power_and_voltage()
> > >   mmc: sdhci: pxav3: Use sdhci_set_power_and_voltage()
> > >   mmc: sdhci: xenon: Use sdhci_set_power_and_voltage()
> > >   mmc: sdhci: am654: Use sdhci_set_power_and_voltage()
> > >   mmc: sdhci: Unexport sdhci_set_power_noreg()
> > >   mmc: sdhci: iproc: Add custom set_power() callback for bcm2711
> > >   ARM: dts: bcm2711: Update expgpio's GPIO labels
> > >   ARM: dts: bcm2711: Add vmmc regulator in emmc2
> > >
> > >  arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 13 ++++++++++++-
> > >  drivers/mmc/host/sdhci-iproc.c        | 17 ++++++++++++++++-
> > >  drivers/mmc/host/sdhci-milbeaut.c     | 13 +------------
> > >  drivers/mmc/host/sdhci-of-arasan.c    | 15 ++-------------
> > >  drivers/mmc/host/sdhci-of-at91.c      | 18 +-----------------
> > >  drivers/mmc/host/sdhci-pxav3.c        | 20 +-------------------
> > >  drivers/mmc/host/sdhci-xenon.c        | 20 +-------------------
> > >  drivers/mmc/host/sdhci.c              | 24 +++++++++++++++++++++---
> > >  drivers/mmc/host/sdhci.h              |  5 +++--
> > >  drivers/mmc/host/sdhci_am654.c        | 17 +++--------------
> > >  10 files changed, 61 insertions(+), 101 deletions(-)
> > >
> > > --
> > > 2.25.1
> > >
> >
> > Patch 1-4, 6, 9 applied for next, thanks!
>
> I think you meant to apply 1-4, 7 and 9. Patch 6 is one of the contentious
> ones.

Yes, that's what I did, but told you about 6. :-)

Thanks and sorry for the noise.

Kind regards
Uffe