| Message ID | 20200331005701.283998-1-marex@denx.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: dts: stm32: Repair AV96 board | expand |
Hi Marek, Thanks for the series. On Tue, Mar 31, 2020 at 02:56:39AM +0200, Marek Vasut wrote: > The AV96 board device tree is completely broken and does not match the > hardware. This series fixes it up. > Completely broken? The patch submitted previously was an initial one and there were many interfaces not enabled. I agree that there are few _obvious_ things like SDMMC1/Ethernet pinmux, LED naming were wrong. This was due to the fact the board was on early bringup stage and I couldn't test Ethernet due to my setup issue at that time (yeah I know it is bad). Also, I don't get access to DHCOR schematics as well for things like PMIC. Do you have access to it? If possible can you share a link to that if available publicly? I will test this series and also the uboot one on my board and give my Tested-by tag soon. Anyway, I think the patchset subject could be something like, "Improve AV96 support" :) Thanks, Mani > Marek Vasut (22): > ARM: dts: stm32: Add alternate pinmux for ethernet RGMII > ARM: dts: stm32: Repair ethernet operation on AV96 > ARM: dts: stm32: Add missing ethernet PHY reset on AV96 > ARM: dts: stm32: Add missing ethernet PHY skews on AV96 > ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins > ARM: dts: stm32: Repair SDMMC1 operation on AV96 > ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 > ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96 > ARM: dts: stm32: Repair PMIC configuration on AV96 > ARM: dts: stm32: Repair PMIC interrupt on AV96 > ARM: dts: stm32: Add QSPI NOR on AV96 > ARM: dts: stm32: Add configuration EEPROM on AV96 > ARM: dts: stm32: Enable GPU on AV96 > ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins > ARM: dts: stm32: Enable WiFi on AV96 > ARM: dts: stm32: Add alternate pinmux for USART2 pins > ARM: dts: stm32: Enable Bluetooth on AV96 > ARM: dts: stm32: Add alternate pinmux for LTDC pins > ARM: dts: stm32: Add bindings for HDMI video on AV96 > ARM: dts: stm32: Add bindings for audio on AV96 > ARM: dts: stm32: Add bindings for USB on AV96 > ARM: dts: stm32: Rename LEDs to match silkscreen on AV96 > > arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 248 +++++++++++++++ > arch/arm/boot/dts/stm32mp157a-avenger96.dts | 328 ++++++++++++++++++-- > 2 files changed, 543 insertions(+), 33 deletions(-) > > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: linux-stm32@st-md-mailman.stormreply.com > To: linux-arm-kernel@lists.infradead.org > > -- > 2.25.1 >
On 3/31/20 6:07 AM, Manivannan Sadhasivam wrote: > Hi Marek, Hi, > Thanks for the series. > > On Tue, Mar 31, 2020 at 02:56:39AM +0200, Marek Vasut wrote: >> The AV96 board device tree is completely broken and does not match the >> hardware. This series fixes it up. >> > > Completely broken? The board didn't even boot. > The patch submitted previously was an initial one and there > were many interfaces not enabled. I agree that there are few _obvious_ things > like SDMMC1/Ethernet pinmux, LED naming were wrong. This was due to the fact the > board was on early bringup stage and I couldn't test Ethernet due to my setup > issue at that time (yeah I know it is bad). Also, I don't get access to DHCOR > schematics as well for things like PMIC. Do you have access to it? Yes, I do have access. > If possible can you share a link to that if available publicly? The SoM schematic is not available in public, no, sorry. > I will test this series and also the uboot one on my board and give my > Tested-by tag soon. > > Anyway, I think the patchset subject could be something like, > "Improve AV96 support" :) I think if something doesn't work, "Repair" is the right word for it.
On Tue, Mar 31, 2020 at 03:44:52PM +0200, Marek Vasut wrote: > On 3/31/20 6:07 AM, Manivannan Sadhasivam wrote: > > Hi Marek, > > Hi, > > > Thanks for the series. > > > > On Tue, Mar 31, 2020 at 02:56:39AM +0200, Marek Vasut wrote: > >> The AV96 board device tree is completely broken and does not match the > >> hardware. This series fixes it up. > >> > > > > Completely broken? > > The board didn't even boot. > Hmm. I think you're using a new revision of AV96. I added the board support with an old version of it (might be an evaluation one). I don't have the delta or changeset so can't compare. Anyway, DH started selling new boards and I think the old ones were discontinued or not made available for purchase so we don't have to worry about breaking the old one. > > The patch submitted previously was an initial one and there > > were many interfaces not enabled. I agree that there are few _obvious_ things > > like SDMMC1/Ethernet pinmux, LED naming were wrong. This was due to the fact the > > board was on early bringup stage and I couldn't test Ethernet due to my setup > > issue at that time (yeah I know it is bad). Also, I don't get access to DHCOR > > schematics as well for things like PMIC. Do you have access to it? > > Yes, I do have access. > > > If possible can you share a link to that if available publicly? > > The SoM schematic is not available in public, no, sorry. > Fine. Just wanted to verify the PMIC part. But I got the information from DH guy offline. > > I will test this series and also the uboot one on my board and give my > > Tested-by tag soon. > > > > Anyway, I think the patchset subject could be something like, > > "Improve AV96 support" :) > > I think if something doesn't work, "Repair" is the right word for it. Right. Didn't know that it doesn't boot on newer boards. I do have one but haven't tried mainline kernel on it, just vendor image for some demos. But feel free to keep it as it is. Thanks, Mani
On 3/31/20 4:09 PM, Manivannan Sadhasivam wrote: > On Tue, Mar 31, 2020 at 03:44:52PM +0200, Marek Vasut wrote: >> On 3/31/20 6:07 AM, Manivannan Sadhasivam wrote: >>> Hi Marek, >> >> Hi, >> >>> Thanks for the series. >>> >>> On Tue, Mar 31, 2020 at 02:56:39AM +0200, Marek Vasut wrote: >>>> The AV96 board device tree is completely broken and does not match the >>>> hardware. This series fixes it up. >>>> >>> >>> Completely broken? >> >> The board didn't even boot. >> > > Hmm. I think you're using a new revision of AV96. I added the board support > with an old version of it (might be an evaluation one). I don't have the delta > or changeset so can't compare. Anyway, DH started selling new boards and I > think the old ones were discontinued or not made available for purchase so we > don't have to worry about breaking the old one. I'm sure we can/should support both, lemme ask about this. The baseboard I have is 588-200 (silkscreen next to barrel jack) and SoM 586-100. >>> The patch submitted previously was an initial one and there >>> were many interfaces not enabled. I agree that there are few _obvious_ things >>> like SDMMC1/Ethernet pinmux, LED naming were wrong. This was due to the fact the >>> board was on early bringup stage and I couldn't test Ethernet due to my setup >>> issue at that time (yeah I know it is bad). Also, I don't get access to DHCOR >>> schematics as well for things like PMIC. Do you have access to it? >> >> Yes, I do have access. >> >>> If possible can you share a link to that if available publicly? >> >> The SoM schematic is not available in public, no, sorry. >> > > Fine. Just wanted to verify the PMIC part. But I got the information from > DH guy offline. Yep, I saw that, good. >>> I will test this series and also the uboot one on my board and give my >>> Tested-by tag soon. >>> >>> Anyway, I think the patchset subject could be something like, >>> "Improve AV96 support" :) >> >> I think if something doesn't work, "Repair" is the right word for it. > > Right. Didn't know that it doesn't boot on newer boards. I do have one but > haven't tried mainline kernel on it, just vendor image for some demos. But > feel free to keep it as it is. Do you have the Enpirion regulator on the SoM ? It's between the STPMIC1A and the SPI NOR. I'll be sending a V3 shortly (few hours), apply it on next/master if you want to test: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git