mbox series

[0/2] firmware/psci: PSCI checker cleanup

Message ID 20200424135657.32519-1-valentin.schneider@arm.com (mailing list archive)
Headers show
Series firmware/psci: PSCI checker cleanup | expand

Message

Valentin Schneider April 24, 2020, 1:56 p.m. UTC 
Hi folks,

This is a small cleanup of the PSCI checker following Peter's objections
to its homegrown do_idle() implementation. It is based on his
sched_setscheduler() unexport series at [1].

I've never really used the thing before, but it still seems to behave
correctly on my Juno r0 & HiKey960.

Cheers,
Valentin

[1]: https://lore.kernel.org/lkml/20200422112719.826676174@infradead.org/T/#t

Valentin Schneider (2):
  firmware/psci: Make PSCI checker not bother with parking
  firmware/psci: Make PSCI checker use play_idle()

 drivers/firmware/psci/psci_checker.c | 159 +++++++--------------------
 1 file changed, 42 insertions(+), 117 deletions(-)

--
2.24.0

Comments

Sudeep Holla June 3, 2020, 5:05 p.m. UTC | #1 
On Fri, Apr 24, 2020 at 02:56:55PM +0100, Valentin Schneider wrote:
> Hi folks,
> 
> This is a small cleanup of the PSCI checker following Peter's objections
> to its homegrown do_idle() implementation. It is based on his
> sched_setscheduler() unexport series at [1].
> 
> I've never really used the thing before, but it still seems to behave
> correctly on my Juno r0 & HiKey960.
> 

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Valentin Schneider June 3, 2020, 5:39 p.m. UTC | #2 
On 03/06/20 18:05, Sudeep Holla wrote:
> On Fri, Apr 24, 2020 at 02:56:55PM +0100, Valentin Schneider wrote:
>> Hi folks,
>>
>> This is a small cleanup of the PSCI checker following Peter's objections
>> to its homegrown do_idle() implementation. It is based on his
>> sched_setscheduler() unexport series at [1].
>>
>> I've never really used the thing before, but it still seems to behave
>> correctly on my Juno r0 & HiKey960.
>>
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Tested-by: Sudeep Holla <sudeep.holla@arm.com>

Thanks!

AIUI the plan is to have the base in for the following version, so we
can wait until then - or I can rebase this on top of mainline, and
whoever will be on the receiving end of the merge conflict will be
slightly annoyed :-)

I'm in no particular rush, and this isn't very hot code, so up to you.
Valentin Schneider Oct. 12, 2020, 1:17 p.m. UTC | #3 
Hi,

On 03/06/20 18:39, Valentin Schneider wrote:
> On 03/06/20 18:05, Sudeep Holla wrote:
>> On Fri, Apr 24, 2020 at 02:56:55PM +0100, Valentin Schneider wrote:
>>> Hi folks,
>>>
>>> This is a small cleanup of the PSCI checker following Peter's objections
>>> to its homegrown do_idle() implementation. It is based on his
>>> sched_setscheduler() unexport series at [1].
>>>
>>> I've never really used the thing before, but it still seems to behave
>>> correctly on my Juno r0 & HiKey960.
>>>
>>
>> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
>> Tested-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Thanks!
>
> AIUI the plan is to have the base in for the following version, so we
> can wait until then - or I can rebase this on top of mainline, and
> whoever will be on the receiving end of the merge conflict will be
> slightly annoyed :-)
>
> I'm in no particular rush, and this isn't very hot code, so up to you.
>

The sched_setscheduler() series is in 5.9. Patches apply cleanly atop 5.9,
and I double-checked on my Juno that they still actually work :-)

> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel