| Message ID | 20200504115625.12589-1-leo.yan@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | perf arm-spe: Add support for synthetic events | expand |
Hi, On Mon, May 04, 2020 at 07:56:22PM +0800, Leo Yan wrote: > This patch set is to support synthetic events with enabling Arm SPE > decoder. Since before Xiaojun Tan (Hisilicon) and James Clark (Arm) > have contributed much for this task, so this patch set is based on their > privous work and polish for the version 7. > > The main work in this version is to polished the core patch "perf > arm-spe: Support synthetic events", e.g. rewrite the code to calculate > ip, packet generation for multiple types (L1 data cache, Last level > cache, TLB, remote access, etc). It also heavily refactors code for > data structure and program flow, which removed unused fields in > structure and polished the program flow to achieve neat code as > possible. > > This patch set has been checked with checkpatch.pl, though it leaves > several warnings, but these warnings are delibarately kept after > reviewing. Some warnings ask to add maintainer (so far it's not > necessary), and some warnings complaint for patch 02 "perf auxtrace: > Add four itrace options" for the text format, since need to keep the > consistency with the same code format in the source code, this is why > this patch doesn't get rid of checkpatch warnings. Gentle ping ... It would be appreciate if can get some review for this patch set. Thanks, Leo > Tan Xiaojun (3): > perf tools: Move arm-spe-pkt-decoder.h/c to the new dir > perf auxtrace: Add four itrace options > perf arm-spe: Support synthetic events > > tools/perf/Documentation/itrace.txt | 6 +- > tools/perf/util/Build | 2 +- > tools/perf/util/arm-spe-decoder/Build | 1 + > .../util/arm-spe-decoder/arm-spe-decoder.c | 219 +++++ > .../util/arm-spe-decoder/arm-spe-decoder.h | 82 ++ > .../arm-spe-pkt-decoder.c | 0 > .../arm-spe-pkt-decoder.h | 16 + > tools/perf/util/arm-spe.c | 823 +++++++++++++++++- > tools/perf/util/auxtrace.c | 17 + > tools/perf/util/auxtrace.h | 15 +- > 10 files changed, 1135 insertions(+), 46 deletions(-) > create mode 100644 tools/perf/util/arm-spe-decoder/Build > create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h > rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%) > rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (64%) > > -- > 2.17.1 >
On Fri, May 22, 2020 at 11:09:19AM +0800, Leo Yan wrote: > On Mon, May 04, 2020 at 07:56:22PM +0800, Leo Yan wrote: > > This patch set is to support synthetic events with enabling Arm SPE > > decoder. Since before Xiaojun Tan (Hisilicon) and James Clark (Arm) > > have contributed much for this task, so this patch set is based on their > > privous work and polish for the version 7. > > > > The main work in this version is to polished the core patch "perf > > arm-spe: Support synthetic events", e.g. rewrite the code to calculate > > ip, packet generation for multiple types (L1 data cache, Last level > > cache, TLB, remote access, etc). It also heavily refactors code for > > data structure and program flow, which removed unused fields in > > structure and polished the program flow to achieve neat code as > > possible. > > > > This patch set has been checked with checkpatch.pl, though it leaves > > several warnings, but these warnings are delibarately kept after > > reviewing. Some warnings ask to add maintainer (so far it's not > > necessary), and some warnings complaint for patch 02 "perf auxtrace: > > Add four itrace options" for the text format, since need to keep the > > consistency with the same code format in the source code, this is why > > this patch doesn't get rid of checkpatch warnings. > > Gentle ping ... > > It would be appreciate if can get some review for this patch set. I was hoping that James Clark would have a look, since he was the last person to go near the userspace side of SPE. Will
Hi Will, On Tue, May 26, 2020 at 11:26:03AM +0100, Will Deacon wrote: > On Fri, May 22, 2020 at 11:09:19AM +0800, Leo Yan wrote: > > On Mon, May 04, 2020 at 07:56:22PM +0800, Leo Yan wrote: > > > This patch set is to support synthetic events with enabling Arm SPE > > > decoder. Since before Xiaojun Tan (Hisilicon) and James Clark (Arm) > > > have contributed much for this task, so this patch set is based on their > > > privous work and polish for the version 7. > > > > > > The main work in this version is to polished the core patch "perf > > > arm-spe: Support synthetic events", e.g. rewrite the code to calculate > > > ip, packet generation for multiple types (L1 data cache, Last level > > > cache, TLB, remote access, etc). It also heavily refactors code for > > > data structure and program flow, which removed unused fields in > > > structure and polished the program flow to achieve neat code as > > > possible. > > > > > > This patch set has been checked with checkpatch.pl, though it leaves > > > several warnings, but these warnings are delibarately kept after > > > reviewing. Some warnings ask to add maintainer (so far it's not > > > necessary), and some warnings complaint for patch 02 "perf auxtrace: > > > Add four itrace options" for the text format, since need to keep the > > > consistency with the same code format in the source code, this is why > > > this patch doesn't get rid of checkpatch warnings. > > > > Gentle ping ... > > > > It would be appreciate if can get some review for this patch set. > > I was hoping that James Clark would have a look, since he was the last > person to go near the userspace side of SPE. Yes, I have offline synced with James and James has verified this patch set at his side. I don't want to rush to ask Arnaldo to merge patches, so just want to get wider reviewing if possible; otherwise, I will rebase this patch set and resend to ML. Thanks, Leo
On Tue, May 26, 2020 at 06:43:37PM +0800, Leo Yan wrote: > On Tue, May 26, 2020 at 11:26:03AM +0100, Will Deacon wrote: > > On Fri, May 22, 2020 at 11:09:19AM +0800, Leo Yan wrote: > > > On Mon, May 04, 2020 at 07:56:22PM +0800, Leo Yan wrote: > > > > This patch set is to support synthetic events with enabling Arm SPE > > > > decoder. Since before Xiaojun Tan (Hisilicon) and James Clark (Arm) > > > > have contributed much for this task, so this patch set is based on their > > > > privous work and polish for the version 7. > > > > > > > > The main work in this version is to polished the core patch "perf > > > > arm-spe: Support synthetic events", e.g. rewrite the code to calculate > > > > ip, packet generation for multiple types (L1 data cache, Last level > > > > cache, TLB, remote access, etc). It also heavily refactors code for > > > > data structure and program flow, which removed unused fields in > > > > structure and polished the program flow to achieve neat code as > > > > possible. > > > > > > > > This patch set has been checked with checkpatch.pl, though it leaves > > > > several warnings, but these warnings are delibarately kept after > > > > reviewing. Some warnings ask to add maintainer (so far it's not > > > > necessary), and some warnings complaint for patch 02 "perf auxtrace: > > > > Add four itrace options" for the text format, since need to keep the > > > > consistency with the same code format in the source code, this is why > > > > this patch doesn't get rid of checkpatch warnings. > > > > > > Gentle ping ... > > > > > > It would be appreciate if can get some review for this patch set. > > > > I was hoping that James Clark would have a look, since he was the last > > person to go near the userspace side of SPE. > > Yes, I have offline synced with James and James has verified this > patch set at his side. > > I don't want to rush to ask Arnaldo to merge patches, so just > want to get wider reviewing if possible; otherwise, I will rebase this > patch set and resend to ML. One thing that might be useful is if James could offer his Tested-by or Acked-by on the public mailing list. Neither Arnaldo nor I have details about your offline sync! Will
On May 26, 2020 4:54:39 PM GMT-03:00, Will Deacon <will@kernel.org> wrote: >On Tue, May 26, 2020 at 06:43:37PM +0800, Leo Yan wrote: >> On Tue, May 26, 2020 at 11:26:03AM +0100, Will Deacon wrote: >> > On Fri, May 22, 2020 at 11:09:19AM +0800, Leo Yan wrote: >> > > On Mon, May 04, 2020 at 07:56:22PM +0800, Leo Yan wrote: >> > > > This patch set is to support synthetic events with enabling Arm >SPE >> > > > decoder. Since before Xiaojun Tan (Hisilicon) and James Clark >(Arm) >> > > > have contributed much for this task, so this patch set is based >on their >> > > > privous work and polish for the version 7. >> > > > >> > > > The main work in this version is to polished the core patch >"perf >> > > > arm-spe: Support synthetic events", e.g. rewrite the code to >calculate >> > > > ip, packet generation for multiple types (L1 data cache, Last >level >> > > > cache, TLB, remote access, etc). It also heavily refactors >code for >> > > > data structure and program flow, which removed unused fields in >> > > > structure and polished the program flow to achieve neat code as >> > > > possible. >> > > > >> > > > This patch set has been checked with checkpatch.pl, though it >leaves >> > > > several warnings, but these warnings are delibarately kept >after >> > > > reviewing. Some warnings ask to add maintainer (so far it's >not >> > > > necessary), and some warnings complaint for patch 02 "perf >auxtrace: >> > > > Add four itrace options" for the text format, since need to >keep the >> > > > consistency with the same code format in the source code, this >is why >> > > > this patch doesn't get rid of checkpatch warnings. >> > > >> > > Gentle ping ... >> > > >> > > It would be appreciate if can get some review for this patch set. >> > >> > I was hoping that James Clark would have a look, since he was the >last >> > person to go near the userspace side of SPE. >> >> Yes, I have offline synced with James and James has verified this >> patch set at his side. >> >> I don't want to rush to ask Arnaldo to merge patches, so just >> want to get wider reviewing if possible; otherwise, I will rebase >this >> patch set and resend to ML. > >One thing that might be useful is if James could offer his Tested-by or >Acked-by on the public mailing list. Neither Arnaldo nor I have details >about your offline sync! That always help, indeed :-) > >Will
Hi Will and Leo, I've tested this on an Arm N1 machine and it looks good to me. James On 26/05/2020 20:54, Will Deacon wrote: > On Tue, May 26, 2020 at 06:43:37PM +0800, Leo Yan wrote: >> On Tue, May 26, 2020 at 11:26:03AM +0100, Will Deacon wrote: >>> On Fri, May 22, 2020 at 11:09:19AM +0800, Leo Yan wrote: >>>> On Mon, May 04, 2020 at 07:56:22PM +0800, Leo Yan wrote: >>>>> This patch set is to support synthetic events with enabling Arm SPE >>>>> decoder. Since before Xiaojun Tan (Hisilicon) and James Clark (Arm) >>>>> have contributed much for this task, so this patch set is based on their >>>>> privous work and polish for the version 7. >>>>> >>>>> The main work in this version is to polished the core patch "perf >>>>> arm-spe: Support synthetic events", e.g. rewrite the code to calculate >>>>> ip, packet generation for multiple types (L1 data cache, Last level >>>>> cache, TLB, remote access, etc). It also heavily refactors code for >>>>> data structure and program flow, which removed unused fields in >>>>> structure and polished the program flow to achieve neat code as >>>>> possible. >>>>> >>>>> This patch set has been checked with checkpatch.pl, though it leaves >>>>> several warnings, but these warnings are delibarately kept after >>>>> reviewing. Some warnings ask to add maintainer (so far it's not >>>>> necessary), and some warnings complaint for patch 02 "perf auxtrace: >>>>> Add four itrace options" for the text format, since need to keep the >>>>> consistency with the same code format in the source code, this is why >>>>> this patch doesn't get rid of checkpatch warnings. >>>> >>>> Gentle ping ... >>>> >>>> It would be appreciate if can get some review for this patch set. >>> >>> I was hoping that James Clark would have a look, since he was the last >>> person to go near the userspace side of SPE. >> >> Yes, I have offline synced with James and James has verified this >> patch set at his side. >> >> I don't want to rush to ask Arnaldo to merge patches, so just >> want to get wider reviewing if possible; otherwise, I will rebase this >> patch set and resend to ML. > > One thing that might be useful is if James could offer his Tested-by or > Acked-by on the public mailing list. Neither Arnaldo nor I have details > about your offline sync! > > Will >
Hi James, On Fri, May 29, 2020 at 03:58:23PM +0100, James Clark wrote: > Hi Will and Leo, > > I've tested this on an Arm N1 machine and it looks good to me. This is great! Will respin the new patch set with adding your test tag and send to ML. Thanks a lot for the effort. Hi Will, Arnaldo, sorry for late replying you due to other works and thanks for suggestions in other emails. Leo
Em Fri, May 29, 2020 at 11:28:01PM +0800, Leo Yan escreveu: > Hi James, > > On Fri, May 29, 2020 at 03:58:23PM +0100, James Clark wrote: > > Hi Will and Leo, > > > > I've tested this on an Arm N1 machine and it looks good to me. > > This is great! Will respin the new patch set with adding your test tag > and send to ML. Thanks a lot for the effort. > > Hi Will, Arnaldo, sorry for late replying you due to other works and > thanks for suggestions in other emails. Np, please do it on top of my tmp.perf/core branch, it'll become perf/core as soon as testing that is ongoing finishes. - Arnaldo
On Fri, May 29, 2020 at 01:18:30PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, May 29, 2020 at 11:28:01PM +0800, Leo Yan escreveu: > > Hi James, > > > > On Fri, May 29, 2020 at 03:58:23PM +0100, James Clark wrote: > > > Hi Will and Leo, > > > > > > I've tested this on an Arm N1 machine and it looks good to me. > > > > This is great! Will respin the new patch set with adding your test tag > > and send to ML. Thanks a lot for the effort. > > > > Hi Will, Arnaldo, sorry for late replying you due to other works and > > thanks for suggestions in other emails. > > Np, please do it on top of my tmp.perf/core branch, it'll become > perf/core as soon as testing that is ongoing finishes. Understood, will do. Thanks, Leo
This patch set is to support synthetic events with enabling Arm SPE decoder. Since before Xiaojun Tan (Hisilicon) and James Clark (Arm) have contributed much for this task, so this patch set is based on their privous work and polish for the version 7. The main work in this version is to polished the core patch "perf arm-spe: Support synthetic events", e.g. rewrite the code to calculate ip, packet generation for multiple types (L1 data cache, Last level cache, TLB, remote access, etc). It also heavily refactors code for data structure and program flow, which removed unused fields in structure and polished the program flow to achieve neat code as possible. This patch set has been checked with checkpatch.pl, though it leaves several warnings, but these warnings are delibarately kept after reviewing. Some warnings ask to add maintainer (so far it's not necessary), and some warnings complaint for patch 02 "perf auxtrace: Add four itrace options" for the text format, since need to keep the consistency with the same code format in the source code, this is why this patch doesn't get rid of checkpatch warnings. Tan Xiaojun (3): perf tools: Move arm-spe-pkt-decoder.h/c to the new dir perf auxtrace: Add four itrace options perf arm-spe: Support synthetic events tools/perf/Documentation/itrace.txt | 6 +- tools/perf/util/Build | 2 +- tools/perf/util/arm-spe-decoder/Build | 1 + .../util/arm-spe-decoder/arm-spe-decoder.c | 219 +++++ .../util/arm-spe-decoder/arm-spe-decoder.h | 82 ++ .../arm-spe-pkt-decoder.c | 0 .../arm-spe-pkt-decoder.h | 16 + tools/perf/util/arm-spe.c | 823 +++++++++++++++++- tools/perf/util/auxtrace.c | 17 + tools/perf/util/auxtrace.h | 15 +- 10 files changed, 1135 insertions(+), 46 deletions(-) create mode 100644 tools/perf/util/arm-spe-decoder/Build create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%) rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (64%)