mbox series

[v2,00/20] coresight: allow to build coresight as modules

Message ID 20200714054914.15141-1-tingwei@codeaurora.org (mailing list archive)
Headers show
Series coresight: allow to build coresight as modules | expand

Message

Tingwei Zhang July 14, 2020, 5:48 a.m. UTC
Allow to build coresight as modules. This gives developers the feasibility to
test their code without reboot.

This series is based on below two series.

 - "coresight: allow to build components as modules"
   https://lkml.org/lkml/2018/6/5/989
 - "coresight: make drivers modular"
   https://lkml.org/lkml/2020/1/17/468

Change from v1:
Use try_module_get() to avoid module to be unloaded when device is used
in active trace session. (Mathieu P)

Change from above two series.
This series adds the support to dynamically remove module when the device in
that module is enabled and used by some trace path. It disables all trace
paths with that device and release the trace path.

Kim Phillips (7):
  coresight: use IS_ENABLED for CONFIGs that may be modules
  coresight: allow etm3x to be built as a module
  coresight: allow etm4x to be built as a module
  coresight: allow etb to be built as a module
  coresight: allow tpiu to be built as a module
  coresight: allow tmc to be built as a module
  coresight: allow funnel and replicator drivers to be built as modules

Mian Yousaf Kaukab (4):
  coresight: export global symbols
  coresight: remove multiple init calls from funnel driver
  coresight: remove multiple init calls from replicator driver
  coresight: tmc-etr: add function to register catu ops

Tingwei Zhang (9):
  coresight: cpu_debug: add module name in Kconfig
  coresight: cpu_debug: define MODULE_DEVICE_TABLE
  coresight: add coresight prefix to barrier_pkt
  Allow to build coresight-stm as a module, for ease of development.
  coresight: cti: add function to register cti associate ops
  coresight: allow cti to be built as a module
  coresight: allow catu drivers to be built as modules
  coresight: add try_get_module() in coresight_grab_device()
  coresight: allow the coresight core driver to be built as a module

 drivers/hwtracing/coresight/Kconfig           |  54 ++++++++--
 drivers/hwtracing/coresight/Makefile          |  20 ++--
 drivers/hwtracing/coresight/coresight-catu.c  |  37 ++++++-
 drivers/hwtracing/coresight/coresight-catu.h  |   2 -
 .../{coresight.c => coresight-core.c}         | 101 +++++++++++++++---
 .../hwtracing/coresight/coresight-cpu-debug.c |   2 +
 .../{coresight-cti.c => coresight-cti-core.c} |  46 +++++++-
 drivers/hwtracing/coresight/coresight-etb10.c |  22 +++-
 .../hwtracing/coresight/coresight-etm-perf.c  |   9 +-
 .../hwtracing/coresight/coresight-etm-perf.h  |   5 +-
 ...resight-etm3x.c => coresight-etm3x-core.c} |  27 ++++-
 ...resight-etm4x.c => coresight-etm4x-core.c} |  31 +++++-
 .../hwtracing/coresight/coresight-funnel.c    |  62 ++++++++++-
 .../hwtracing/coresight/coresight-platform.c  |   1 +
 drivers/hwtracing/coresight/coresight-priv.h  |  24 ++---
 .../coresight/coresight-replicator.c          |  63 ++++++++++-
 drivers/hwtracing/coresight/coresight-stm.c   |  20 +++-
 .../{coresight-tmc.c => coresight-tmc-core.c} |  19 +++-
 .../hwtracing/coresight/coresight-tmc-etf.c   |   2 +-
 .../hwtracing/coresight/coresight-tmc-etr.c   |  21 +++-
 drivers/hwtracing/coresight/coresight-tmc.h   |   3 +
 drivers/hwtracing/coresight/coresight-tpiu.c  |  19 +++-
 include/linux/coresight.h                     |   2 +-
 23 files changed, 518 insertions(+), 74 deletions(-)
 rename drivers/hwtracing/coresight/{coresight.c => coresight-core.c} (94%)
 rename drivers/hwtracing/coresight/{coresight-cti.c => coresight-cti-core.c} (95%)
 rename drivers/hwtracing/coresight/{coresight-etm3x.c => coresight-etm3x-core.c} (97%)
 rename drivers/hwtracing/coresight/{coresight-etm4x.c => coresight-etm4x-core.c} (98%)
 rename drivers/hwtracing/coresight/{coresight-tmc.c => coresight-tmc-core.c} (96%)

Comments

Mike Leach July 16, 2020, 1:29 p.m. UTC | #1
Hi,

I've tried to apply this set locally to test functionality but patch
03 does not apply without --3way, and patch 11 does not apply at all.
I am attempting to apply to 5.8-rc5. What does this set apply to?

Thanks

Mike

On Tue, 14 Jul 2020 at 06:49, Tingwei Zhang <tingwei@codeaurora.org> wrote:
>
> Allow to build coresight as modules. This gives developers the feasibility to
> test their code without reboot.
>
> This series is based on below two series.
>
>  - "coresight: allow to build components as modules"
>    https://lkml.org/lkml/2018/6/5/989
>  - "coresight: make drivers modular"
>    https://lkml.org/lkml/2020/1/17/468
>
> Change from v1:
> Use try_module_get() to avoid module to be unloaded when device is used
> in active trace session. (Mathieu P)
>
> Change from above two series.
> This series adds the support to dynamically remove module when the device in
> that module is enabled and used by some trace path. It disables all trace
> paths with that device and release the trace path.
>
> Kim Phillips (7):
>   coresight: use IS_ENABLED for CONFIGs that may be modules
>   coresight: allow etm3x to be built as a module
>   coresight: allow etm4x to be built as a module
>   coresight: allow etb to be built as a module
>   coresight: allow tpiu to be built as a module
>   coresight: allow tmc to be built as a module
>   coresight: allow funnel and replicator drivers to be built as modules
>
> Mian Yousaf Kaukab (4):
>   coresight: export global symbols
>   coresight: remove multiple init calls from funnel driver
>   coresight: remove multiple init calls from replicator driver
>   coresight: tmc-etr: add function to register catu ops
>
> Tingwei Zhang (9):
>   coresight: cpu_debug: add module name in Kconfig
>   coresight: cpu_debug: define MODULE_DEVICE_TABLE
>   coresight: add coresight prefix to barrier_pkt
>   Allow to build coresight-stm as a module, for ease of development.
>   coresight: cti: add function to register cti associate ops
>   coresight: allow cti to be built as a module
>   coresight: allow catu drivers to be built as modules
>   coresight: add try_get_module() in coresight_grab_device()
>   coresight: allow the coresight core driver to be built as a module
>
>  drivers/hwtracing/coresight/Kconfig           |  54 ++++++++--
>  drivers/hwtracing/coresight/Makefile          |  20 ++--
>  drivers/hwtracing/coresight/coresight-catu.c  |  37 ++++++-
>  drivers/hwtracing/coresight/coresight-catu.h  |   2 -
>  .../{coresight.c => coresight-core.c}         | 101 +++++++++++++++---
>  .../hwtracing/coresight/coresight-cpu-debug.c |   2 +
>  .../{coresight-cti.c => coresight-cti-core.c} |  46 +++++++-
>  drivers/hwtracing/coresight/coresight-etb10.c |  22 +++-
>  .../hwtracing/coresight/coresight-etm-perf.c  |   9 +-
>  .../hwtracing/coresight/coresight-etm-perf.h  |   5 +-
>  ...resight-etm3x.c => coresight-etm3x-core.c} |  27 ++++-
>  ...resight-etm4x.c => coresight-etm4x-core.c} |  31 +++++-
>  .../hwtracing/coresight/coresight-funnel.c    |  62 ++++++++++-
>  .../hwtracing/coresight/coresight-platform.c  |   1 +
>  drivers/hwtracing/coresight/coresight-priv.h  |  24 ++---
>  .../coresight/coresight-replicator.c          |  63 ++++++++++-
>  drivers/hwtracing/coresight/coresight-stm.c   |  20 +++-
>  .../{coresight-tmc.c => coresight-tmc-core.c} |  19 +++-
>  .../hwtracing/coresight/coresight-tmc-etf.c   |   2 +-
>  .../hwtracing/coresight/coresight-tmc-etr.c   |  21 +++-
>  drivers/hwtracing/coresight/coresight-tmc.h   |   3 +
>  drivers/hwtracing/coresight/coresight-tpiu.c  |  19 +++-
>  include/linux/coresight.h                     |   2 +-
>  23 files changed, 518 insertions(+), 74 deletions(-)
>  rename drivers/hwtracing/coresight/{coresight.c => coresight-core.c} (94%)
>  rename drivers/hwtracing/coresight/{coresight-cti.c => coresight-cti-core.c} (95%)
>  rename drivers/hwtracing/coresight/{coresight-etm3x.c => coresight-etm3x-core.c} (97%)
>  rename drivers/hwtracing/coresight/{coresight-etm4x.c => coresight-etm4x-core.c} (98%)
>  rename drivers/hwtracing/coresight/{coresight-tmc.c => coresight-tmc-core.c} (96%)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> _______________________________________________
> CoreSight mailing list
> CoreSight@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/coresight
Tingwei Zhang July 17, 2020, 3:53 a.m. UTC | #2
On 2020-07-16 21:29, Mike Leach wrote:
> Hi,
> 
> I've tried to apply this set locally to test functionality but patch
> 03 does not apply without --3way, and patch 11 does not apply at all.
> I am attempting to apply to 5.8-rc5. What does this set apply to?
> 

It's applied on 5.7.8.  I'll rebase to 5.8-rc5 and push a new patchset.

Thanks,
Tingwei

> Thanks
> 
> Mike
> 
> On Tue, 14 Jul 2020 at 06:49, Tingwei Zhang <tingwei@codeaurora.org>
> wrote:
>> 
>> Allow to build coresight as modules. This gives developers the
> feasibility to
>> test their code without reboot.
>> 
>> This series is based on below two series.
>> 
>>  - "coresight: allow to build components as modules"
>>    https://lkml.org/lkml/2018/6/5/989
>>  - "coresight: make drivers modular"
>>    https://lkml.org/lkml/2020/1/17/468
>> 
>> Change from v1:
>> Use try_module_get() to avoid module to be unloaded when device is 
>> used
>> in active trace session. (Mathieu P)
>> 
>> Change from above two series.
>> This series adds the support to dynamically remove module when the
> device in
>> that module is enabled and used by some trace path. It disables all
> trace
>> paths with that device and release the trace path.
>> 
>> Kim Phillips (7):
>>   coresight: use IS_ENABLED for CONFIGs that may be modules
>>   coresight: allow etm3x to be built as a module
>>   coresight: allow etm4x to be built as a module
>>   coresight: allow etb to be built as a module
>>   coresight: allow tpiu to be built as a module
>>   coresight: allow tmc to be built as a module
>>   coresight: allow funnel and replicator drivers to be built as 
>> modules
>> 
>> Mian Yousaf Kaukab (4):
>>   coresight: export global symbols
>>   coresight: remove multiple init calls from funnel driver
>>   coresight: remove multiple init calls from replicator driver
>>   coresight: tmc-etr: add function to register catu ops
>> 
>> Tingwei Zhang (9):
>>   coresight: cpu_debug: add module name in Kconfig
>>   coresight: cpu_debug: define MODULE_DEVICE_TABLE
>>   coresight: add coresight prefix to barrier_pkt
>>   Allow to build coresight-stm as a module, for ease of development.
>>   coresight: cti: add function to register cti associate ops
>>   coresight: allow cti to be built as a module
>>   coresight: allow catu drivers to be built as modules
>>   coresight: add try_get_module() in coresight_grab_device()
>>   coresight: allow the coresight core driver to be built as a module
>> 
>>  drivers/hwtracing/coresight/Kconfig           |  54 ++++++++--
>>  drivers/hwtracing/coresight/Makefile          |  20 ++--
>>  drivers/hwtracing/coresight/coresight-catu.c  |  37 ++++++-
>>  drivers/hwtracing/coresight/coresight-catu.h  |   2 -
>>  .../{coresight.c => coresight-core.c}         | 101 
>> +++++++++++++++---
>>  .../hwtracing/coresight/coresight-cpu-debug.c |   2 +
>>  .../{coresight-cti.c => coresight-cti-core.c} |  46 +++++++-
>>  drivers/hwtracing/coresight/coresight-etb10.c |  22 +++-
>>  .../hwtracing/coresight/coresight-etm-perf.c  |   9 +-
>>  .../hwtracing/coresight/coresight-etm-perf.h  |   5 +-
>>  ...resight-etm3x.c => coresight-etm3x-core.c} |  27 ++++-
>>  ...resight-etm4x.c => coresight-etm4x-core.c} |  31 +++++-
>>  .../hwtracing/coresight/coresight-funnel.c    |  62 ++++++++++-
>>  .../hwtracing/coresight/coresight-platform.c  |   1 +
>>  drivers/hwtracing/coresight/coresight-priv.h  |  24 ++---
>>  .../coresight/coresight-replicator.c          |  63 ++++++++++-
>>  drivers/hwtracing/coresight/coresight-stm.c   |  20 +++-
>>  .../{coresight-tmc.c => coresight-tmc-core.c} |  19 +++-
>>  .../hwtracing/coresight/coresight-tmc-etf.c   |   2 +-
>>  .../hwtracing/coresight/coresight-tmc-etr.c   |  21 +++-
>>  drivers/hwtracing/coresight/coresight-tmc.h   |   3 +
>>  drivers/hwtracing/coresight/coresight-tpiu.c  |  19 +++-
>>  include/linux/coresight.h                     |   2 +-
>>  23 files changed, 518 insertions(+), 74 deletions(-)
>>  rename drivers/hwtracing/coresight/{coresight.c => coresight-core.c}
> (94%)
>>  rename drivers/hwtracing/coresight/{coresight-cti.c =>
> coresight-cti-core.c} (95%)
>>  rename drivers/hwtracing/coresight/{coresight-etm3x.c =>
> coresight-etm3x-core.c} (97%)
>>  rename drivers/hwtracing/coresight/{coresight-etm4x.c =>
> coresight-etm4x-core.c} (98%)
>>  rename drivers/hwtracing/coresight/{coresight-tmc.c =>
> coresight-tmc-core.c} (96%)
>> 
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
>> a Linux Foundation Collaborative Project
>> 
>> _______________________________________________
>> CoreSight mailing list
>> CoreSight@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/coresight