From patchwork Sun Aug 2 14:25:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= X-Patchwork-Id: 11696505 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2A36B13B6 for ; Sun, 2 Aug 2020 14:28:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02B5A20759 for ; Sun, 2 Aug 2020 14:28:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uMIhrnTH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02B5A20759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=sL1uGsOjySdrqhZzuMU6FU7C+DLgxHjHfYQUbd95I6o=; b=uMIhrnTHLg8Kmt5NhaTVGBik+U RKZVT2vW1q4Oi2vi3YhqTsHF93horA56UizK5RK8IBYeE9Nm3QTBJM4lHeDZftFZ6RrvAh4yuu7Nj RktGDszDi443mcS769szlLQZX/HMN7WViUAp3OtT03S46q6wcfUMONDyWAu7GD2GGaafljkB9hJPc jPWT7uhr3oBNvhlihft4Ty5SE0w+YixCSLiGdP1T7aPddLcL4BoySwn3+tMhRIkzji63RCg2C9btU YqMYPBMl2Uz+MSD38x0NPq+njqztSawwgw3x5J+fPiGHlvTjBuqJv5fSlUV8oEbzKfBrR7YTHA9Ta 2IFqzyXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwG-00071m-DD; Sun, 02 Aug 2020 14:26:12 +0000 Received: from mail-lj1-f171.google.com ([209.85.208.171]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwB-0006zB-QC; Sun, 02 Aug 2020 14:26:08 +0000 Received: by mail-lj1-f171.google.com with SMTP id x9so37042889ljc.5; Sun, 02 Aug 2020 07:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zeiAgJxHrPijvNQknHHdvjYtJyFN1FT1e2QzBTPsm24=; b=B8sVxf6RowCYAGQOlvb2k5Kal91vhbXwufnmyPE6PUcLDrrGd7CM2OToLShVJ0H4rH 4XMaj1IiPQfV7TN3EbI2mf6kGBfZAiHuMqda9qxKf20sWvkB1kaWNUlEuEuDsqN9xo9u fTRW8ZVX8UAdlc1xs0AvpQKaBjcco0nr8hzYQ5swk/jdD98i7cy5jjar4iTOPjHBasNl 1Wev0XR/LbVGjVe4z5GLm3IqcPYBkI2ExzBeoP2w7V4znUf2ah/QTLZYGO/LxHl8oJ7+ W6okwYT7PdOw60EKtOxs2GDF0DxrHDdXK0vzvzPVZYjzFRGRY2KUzr5twCL0sZo256HS h0YA== X-Gm-Message-State: AOAM530H86xogbxwY2Ra1fCF2L5RBsp8JhLnNwEtHKlEEPKYxl/6lDb1 DEEXWkaPcUKPsFuii2/Lh8E= X-Google-Smtp-Source: ABdhPJz3cgcIo8JIidtc9NrocQlQwtKoNwLE3saIsQCJHhsMNawOby6x6eEuxlT5d67lW0jGLW6Kmg== X-Received: by 2002:a2e:94d5:: with SMTP id r21mr6223757ljh.424.1596378363688; Sun, 02 Aug 2020 07:26:03 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 193sm4214136lfa.90.2020.08.02.07.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:26:02 -0700 (PDT) From: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:52 +0000 Message-Id: <20200802142601.1635926-1-kw@linux.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200802_102607_891399_E43CFC3E X-CRM114-Status: GOOD ( 12.82 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.171 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [kswilczynski[at]gmail.com] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pci@vger.kernel.org, Shawn Lin , Binghui Wang , linux-arm-kernel@axis.com, Ley Foon Tan , Thomas Petazzoni , Toan Le , Jesper Nilsson , linux-samsung-soc@vger.kernel.org, Kevin Hilman , Pratyush Anand , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Xiaowei Song , Hou Zhiqiang , Linus Walleij , Richard Zhu , Sascha Hauer , Yue Wang , Murali Karicheri , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , rfi@lists.rocketboards.org, Shawn Guo , Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org At the moment a lot of error handling code would print a duplicated error message should either the platform_get_irq() or platform_get_irq_byname() function fails to obtain an IRQ for a device. There is no need to call the dev_err() function directly to print a custom message when handling an error from either of these functions as both are going to display an appropriate error message in case of a failure. This series aims to remove surplus call to dev_err() when handing an error originating from either platform_get_irq() or platform_get_irq_byname() function as per suggestion from Coccinelle. Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") and commit 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints"). Krzysztof Wilczyński (10): PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() PCI: mobiveil: Remove dev_err() when handing an error from platform_get_irq() PCI: tegra: Remove dev_err() when handing an error from platform_get_irq() PCI: altera: Remove dev_err() when handing an error from platform_get_irq() PCI: host-generic: Remove dev_err() when handing an error from platform_get_irq() PCI: v3-semi: Remove dev_err() when handing an error from platform_get_irq() PCI: altera-msi: Remove dev_err() when handing an error from platform_get_irq() PCI: xgene-msi: Remove dev_err() when handing an error from platform_get_irq() PCI: rockchip: Remove dev_err() when handing an error from platform_get_irq() PCI: xilinx-nwl: Remove dev_err() when handing an error from platform_get_irq() drivers/pci/controller/dwc/pci-dra7xx.c | 8 ++------ drivers/pci/controller/dwc/pci-exynos.c | 9 +++------ drivers/pci/controller/dwc/pci-imx6.c | 4 +--- drivers/pci/controller/dwc/pci-keystone.c | 4 +--- drivers/pci/controller/dwc/pci-meson.c | 4 +--- drivers/pci/controller/dwc/pcie-armada8k.c | 4 +--- drivers/pci/controller/dwc/pcie-artpec6.c | 4 +--- drivers/pci/controller/dwc/pcie-histb.c | 4 +--- drivers/pci/controller/dwc/pcie-kirin.c | 5 +---- drivers/pci/controller/dwc/pcie-spear13xx.c | 5 ++--- drivers/pci/controller/dwc/pcie-tegra194.c | 4 +--- .../pci/controller/mobiveil/pcie-layerscape-gen4.c | 5 ++--- drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 4 +--- drivers/pci/controller/pci-tegra.c | 8 ++------ drivers/pci/controller/pci-v3-semi.c | 5 ++--- drivers/pci/controller/pci-xgene-msi.c | 2 -- drivers/pci/controller/pcie-altera-msi.c | 1 - drivers/pci/controller/pcie-altera.c | 4 +--- drivers/pci/controller/pcie-rockchip-host.c | 12 +++--------- drivers/pci/controller/pcie-tango.c | 4 +--- drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- 21 files changed, 29 insertions(+), 82 deletions(-)