mbox series

[v10,0/2] Amazon's Annapurna Labs Memory Controller EDAC

Message ID 20200816185551.19108-1-talel@amazon.com (mailing list archive)
Headers show
Series Amazon's Annapurna Labs Memory Controller EDAC | expand

Message

Shenhar, Talel Aug. 16, 2020, 6:55 p.m. UTC 
This series introduces support for Amazon's Annapurna Labs Memory
Controller EDAC driver.

Changes since v9:
================
- remove prefix (al_mc_edac_get_scrub_mode -> get_scrub_mode)

Changes since v8:
================
- added cells address and size description to dt-binding yaml doc

Changes since v7:
=================
- rebased and retested for tag Linux 5.8-rc1

Changes since v6:
=================
- removed unused defines
- user-visible strings changed to capital
- removed static function names prefix from internal functions (external
  used function, such as devm/interrupts-handlers/probe, left with the
  prefix to allow stack trace visibility)
- sorted function local variables declaration in a reverse Christmas tree order
- fixed use of wrong syndrome defines
- added a comment to interrupts handling (polling mode with interrupt mode)
- added grain definition
- appended "or BSD-2-Clause" to dt binding SPDX

Changes since v5:
=================
- rebased and retested for tag Linux 5.6-rc2
- added Reviewed-By for dt-binding (Rob Herring <robh@kernel.org>)
- added Reviewed-By for driver (James Morse <james.morse@arm.com>)

Changes since v4:
=================
- fixed dt-binding interrupt to have min of 1
- updated dt-binding GPL-2.0 to GPL-2.0-only
- changed writel to relaxed flavor
- added managed device driver unwind

Changes since v3:
=================
- removed quotation marks and hyphen from compatible dt-binding
- added interrupts and interrupt-names description to dt-binding
- added missing include to dt-binding

Changes since v2:
=================
- added missing includes
- aggregated variables to same line
- removed ranks read
- added spinlock to mc reporting
- made irq handler clearer
- freed irq before freeing device memory
- changed Kconfig to tristate
- added COMPILE_TEST to Kconfig
- converted dt binding to new scheme
- used devm_platform_ioremap_resource instead of get&ioremap

Changes since v1:
=================
- updated dt binding node name and added Rob Reviewed-By
- removed auto selecting of this driver


Talel Shenhar (2):
  dt-bindings: edac: al-mc-edac: Amazon's Annapurna Labs Memory
    Controller EDAC
  EDAC: al-mc-edac: Introduce Amazon's Annapurna Labs Memory Controller
    EDAC

 .../bindings/edac/amazon,al-mc-edac.yaml      |  67 ++++
 MAINTAINERS                                   |   7 +
 drivers/edac/Kconfig                          |   7 +
 drivers/edac/Makefile                         |   1 +
 drivers/edac/al_mc_edac.c                     | 354 ++++++++++++++++++
 5 files changed, 436 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
 create mode 100644 drivers/edac/al_mc_edac.c

Comments

Borislav Petkov Aug. 17, 2020, 8:31 a.m. UTC | #1 
On Sun, Aug 16, 2020 at 09:55:49PM +0300, Talel Shenhar wrote:
> Talel Shenhar (2):
>   dt-bindings: edac: al-mc-edac: Amazon's Annapurna Labs Memory
>     Controller EDAC
>   EDAC: al-mc-edac: Introduce Amazon's Annapurna Labs Memory Controller
>     EDAC
> 
>  .../bindings/edac/amazon,al-mc-edac.yaml      |  67 ++++
>  MAINTAINERS                                   |   7 +
>  drivers/edac/Kconfig                          |   7 +
>  drivers/edac/Makefile                         |   1 +
>  drivers/edac/al_mc_edac.c                     | 354 ++++++++++++++++++
>  5 files changed, 436 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-mc-edac.yaml
>  create mode 100644 drivers/edac/al_mc_edac.c

Applied, thanks.