[v4,0/2] arm64: Add basic support for Kobol's Helios64

Message

Uwe Kleine-König Oct. 14, 2020, 8 p.m. UTC

Hello,

in v3 Johan still found some inconsistencies in how I sorted (or didn't
sort) the device tree properties. The rules I applied now are:

	at the beginning of a node: compatible, reg and interrupt stuff
	status and #* at the end
	i2c-scl-rising-time-ns before i2c-scl-falling-time-ns
	regulator-name first among regulator-*
	regulator-min-microvolt before regulator-max-microvolt
	pinctrl-names before pinctrl-0
	tx_delay grouped with (and after) rx_delay
	vcc12* after vcc5*
	otherwise alphabetically

other things changed are:

	- drop disable-wp and supports-emmc for emmc
	- use led-0 and led-1 as node names for the leds
	- rename pinctrl for the leds according to the line name in the schematic
	- drop linux,default-trigger = "none";
	- add an enable gpio for the sd regulator
	- some whitespace nits

While testing I rebased to 5.9 and for an unknown reason this kernel
fails to boot (just no output), but the resulting dtb works just fine
with a Debian 5.8 kernel.

Uwe Kleine-König (2):
  dt-bindings: vendor-prefixes: Add kobol prefix
  arm64: dts: rockchip: Add basic support for Kobol's Helios64

 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../dts/rockchip/rk3399-kobol-helios64.dts    | 371 ++++++++++++++++++
 3 files changed, 374 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts

Comments

Heiko Stübner Nov. 2, 2020, 2:55 p.m. UTC | #1

On Wed, 14 Oct 2020 22:00:28 +0200, Uwe Kleine-König wrote:
> in v3 Johan still found some inconsistencies in how I sorted (or didn't
> sort) the device tree properties. The rules I applied now are:
> 
> 	at the beginning of a node: compatible, reg and interrupt stuff
> 	status and #* at the end
> 	i2c-scl-rising-time-ns before i2c-scl-falling-time-ns
> 	regulator-name first among regulator-*
> 	regulator-min-microvolt before regulator-max-microvolt
> 	pinctrl-names before pinctrl-0
> 	tx_delay grouped with (and after) rx_delay
> 	vcc12* after vcc5*
> 	otherwise alphabetically
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: vendor-prefixes: Add kobol prefix
      commit: fa67f2817ff2c9bb07472d30e58d904922f1a538
[2/2] arm64: dts: rockchip: Add basic support for Kobol's Helios64
      commit: 09e006cfb43e8ec38afe28278b210dab72e6cac8

Fixed spaces with tabs in the deleted opp area and
inserted a blank between the two cluster blocks.


Best regards,