| Message ID | 20201106061433.1483129-1-ajye_huang@compal.corp-partner.google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Modify documentation and machine driver for SC7180 sound card | expand |
Hi, Mark Could you please kindly review the series patch v6? And may I get your approval if the review is done. thanks Ajye On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang <ajye.huang@gmail.com> wrote: > > Note: > - The patch is made by the collaboration of > Ajye Huang <ajye_huang@compal.corp-partner.google.com> > Cheng-Yi Chiang <cychiang@chromium.org> > > v6: > - Documentation: Addressed suggestions from Rob Herring. > - Define "maxItems: 1" in dmic-gpios property. > - Only keep one example and add dmic-gpios property in. > v5: > - Machine driver: > - Fix a format string warning (Reported-by: kernel test robot <lkp@intel.com>). > detailed info at https://lore.kernel.org/patchwork/patch/1331087/ > > v4: > - Machine driver: Addressed suggestions from Tzung-Bi. > - Remove redundant judgments in dmic_set() and dmic_get(). > - Remove 1 level indent of judgment of IS_ERR(data->dmic_sel). > > v3: > - Machine driver: Addressed suggestions from Tzung-Bi. > - Move variables "dmic_switch" and "dmic_sel" into struct sc7180_snd_data. > - Remove redundant judgments in dmic_set(). > > v2: > - Documentation: Modify the dimc-gpios property description and examples. > - Machine driver: > - Remove "qcom,sc7180-sndcard-rt5682-m98357-2mic" compatible > - See gpio property and use anadditional control. > > Thanks for the review! > > Ajye Huang (2): > ASoC: google: dt-bindings: modify machine bindings for two MICs case > ASoC: qcom: sc7180: Modify machine driver for 2mic > > .../bindings/sound/google,sc7180-trogdor.yaml | 8 ++- > sound/soc/qcom/sc7180.c | 61 +++++++++++++++++++ > 2 files changed, 68 insertions(+), 1 deletion(-) > > -- > 2.25.1 >
On Tue, Nov 10, 2020 at 05:40:40PM +0800, Ajye Huang wrote: > Hi, Mark > > Could you please kindly review the series patch v6? And may I get your > approval if the review is done. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
On Fri, 6 Nov 2020 14:14:31 +0800, Ajye Huang wrote: > Note: > - The patch is made by the collaboration of > Ajye Huang <ajye_huang@compal.corp-partner.google.com> > Cheng-Yi Chiang <cychiang@chromium.org> > > v6: > - Documentation: Addressed suggestions from Rob Herring. > - Define "maxItems: 1" in dmic-gpios property. > - Only keep one example and add dmic-gpios property in. > v5: > - Machine driver: > - Fix a format string warning (Reported-by: kernel test robot <lkp@intel.com>). > detailed info at https://lore.kernel.org/patchwork/patch/1331087/ > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case commit: 0e38d93493c7b11bc250113dd5b7b9d17ba8c54d [2/2] ASoC: qcom: sc7180: Modify machine driver for 2mic commit: 3cfbf07c6d2779d24a6f5b999a91f400256b1d4e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi,Mark Thank you, I already understand, sorry for causing you trouble. Ajye On Tue, Nov 10, 2020 at 7:56 PM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Nov 10, 2020 at 05:40:40PM +0800, Ajye Huang wrote: > > Hi, Mark > > > > Could you please kindly review the series patch v6? And may I get your > > approval if the review is done. > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. > > Sending content free pings adds to the mail volume (if they are seen at > all) which is often the problem and since they can't be reviewed > directly if something has gone wrong you'll have to resend the patches > anyway, so sending again is generally a better approach though there are > some other maintainers who like them - if in doubt look at how patches > for the subsystem are normally handled.
Note: - The patch is made by the collaboration of Ajye Huang <ajye_huang@compal.corp-partner.google.com> Cheng-Yi Chiang <cychiang@chromium.org> v6: - Documentation: Addressed suggestions from Rob Herring. - Define "maxItems: 1" in dmic-gpios property. - Only keep one example and add dmic-gpios property in. v5: - Machine driver: - Fix a format string warning (Reported-by: kernel test robot <lkp@intel.com>). detailed info at https://lore.kernel.org/patchwork/patch/1331087/ v4: - Machine driver: Addressed suggestions from Tzung-Bi. - Remove redundant judgments in dmic_set() and dmic_get(). - Remove 1 level indent of judgment of IS_ERR(data->dmic_sel). v3: - Machine driver: Addressed suggestions from Tzung-Bi. - Move variables "dmic_switch" and "dmic_sel" into struct sc7180_snd_data. - Remove redundant judgments in dmic_set(). v2: - Documentation: Modify the dimc-gpios property description and examples. - Machine driver: - Remove "qcom,sc7180-sndcard-rt5682-m98357-2mic" compatible - See gpio property and use anadditional control. Thanks for the review! Ajye Huang (2): ASoC: google: dt-bindings: modify machine bindings for two MICs case ASoC: qcom: sc7180: Modify machine driver for 2mic .../bindings/sound/google,sc7180-trogdor.yaml | 8 ++- sound/soc/qcom/sc7180.c | 61 +++++++++++++++++++ 2 files changed, 68 insertions(+), 1 deletion(-)