[0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi()

Message

Valentin Schneider Nov. 9, 2020, 9:41 a.m. UTC

Hi folks,

While hacking on the GIC flow handlers, I grew increasingly suspicious of 
handle_percpu_devid_fasteoi_ipi() and thus did a bit of digging. AFAICT it isn't
actually needed and handle_percpu_devid_irq() would suffice. Argumentation is in
patch 1.

Tested on my Juno (GICv2) and eMAG (GICv3).

Whichever way this goes I owe Marc some pastries, given I either
- Missed something and created some noise
- Turned my brain off back when reviewing this flow handler
so maybe just start with pinging me what you want...

Valentin Schneider (5):
  irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq()
  irqchip/armada-370-xp: Make IPIs use handle_percpu_devid_irq()
  irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq()
  irqchip/hip04: Make IPIs use handle_percpu_devid_irq()
  Revert "genirq: Add fasteoi IPI flow"

 drivers/irqchip/irq-armada-370-xp.c |  2 +-
 drivers/irqchip/irq-bcm2836.c       |  2 +-
 drivers/irqchip/irq-gic-v3.c        |  6 ------
 drivers/irqchip/irq-gic.c           |  8 +-------
 drivers/irqchip/irq-hip04.c         |  6 +-----
 include/linux/irq.h                 |  1 -
 kernel/irq/chip.c                   | 27 ---------------------------
 7 files changed, 4 insertions(+), 48 deletions(-)

--
2.27.0

Comments

Marc Zyngier Dec. 11, 2020, 3:01 p.m. UTC | #1

On Mon, 9 Nov 2020 09:41:16 +0000, Valentin Schneider wrote:
> While hacking on the GIC flow handlers, I grew increasingly suspicious of
> handle_percpu_devid_fasteoi_ipi() and thus did a bit of digging. AFAICT it isn't
> actually needed and handle_percpu_devid_irq() would suffice. Argumentation is in
> patch 1.
> 
> Tested on my Juno (GICv2) and eMAG (GICv3).
> 
> [...]

Applied to irq/irqchip-next, thanks!

[1/5] irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq()
      commit: 6abbd6988971aaa607b026eaa0ffd2301352f2ea
[2/5] irqchip/armada-370-xp: Make IPIs use handle_percpu_devid_irq()
      commit: e52e73b7e9f7d08b8c2ef6fb1657105093e22a03
[3/5] irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq()
      commit: ffdad793d579c9286c7b67a86d1a3c890fb32082
[4/5] irqchip/hip04: Make IPIs use handle_percpu_devid_irq()
      commit: a2e042e13ff322ad523a2f131dd6e03e8bc05053
[5/5] Revert "genirq: Add fasteoi IPI flow"
      commit: b388fa50142510fb6477f130bb1b3f05a0a263a1

Cheers,

	M.