mbox series

[v4,0/6] SCMIv3.0 Sensor Extensions

Message ID 20201119174906.43862-1-cristian.marussi@arm.com (mailing list archive)
Headers show
Series SCMIv3.0 Sensor Extensions | expand

Message

Cristian Marussi Nov. 19, 2020, 5:49 p.m. UTC
Hi,

this series is meant to add support for the new SCMI Sensor Protocol
features defined by the upcoming SCMIv3.0 specification, whose BETA
release is available at [1].

The series is currently based on for-next/scmi [2] on top of:

commit b141fca08207 ("firmware: arm_scmi: Fix missing destroy_workqueue()")

Any feedback welcome,

Thanks,

Cristian

---
v3 --> v4
- dropped multiple single field structs
- dropped _le structs naming
- hardcoded a few defines for base sz structs
- introduced SCMIv2 version define to use for comparisons
  and fixed a few comments
- drop to _dbg prints about missing interval update info
- dropped SCMIv3 unrelated comment fix

v2 --> v3
- removed stale unused msg payload definition
- moved variable declaration inside switch block
- setting rx_size to 0 in sensor_reading_get to allow fw to send
  both v2 and v3 replies...even if sensor_reading_get() only handles
  v2 spec and returns one single value
- using get_unaligned_le64 in lieu of le64_to_cpu
- removed refs to v2.1
- Fix SCMI_MAX_NUM_SENSOR_AXIS to 63
- added missing Dox comment in resolution
- added common INTVL SEGMENT macros

v1 --> v2
- rebased on for-next/scmi v5.10
- restrict segmented intervals descriptors to single triplet
- add proper usage of scmi_reset_rx_to_maxsz

[1]:https://developer.arm.com/documentation/den0056/c/
[2]:https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/log/?h=for-next/scmi


Cristian Marussi (6):
  firmware: arm_scmi: rework scmi_sensors_protocol_init
  firmware: arm_scmi: add SCMIv3.0 Sensors descriptors extensions
  hwmon: scmi: update hwmon internal scale data type
  firmware: arm_scmi: add SCMIv3.0 Sensors timestamped reads
  firmware: arm_scmi: add SCMIv3.0 Sensor configuration support
  firmware: arm_scmi: add SCMIv3.0 Sensor notifications

 drivers/firmware/arm_scmi/sensors.c | 720 ++++++++++++++++++++++++++--
 drivers/hwmon/scmi-hwmon.c          |   2 +-
 include/linux/scmi_protocol.h       | 288 ++++++++++-
 3 files changed, 953 insertions(+), 57 deletions(-)

Comments

Sudeep Holla Nov. 23, 2020, 10:43 a.m. UTC | #1
On Thu, 19 Nov 2020 17:49:00 +0000, Cristian Marussi wrote:
> this series is meant to add support for the new SCMI Sensor Protocol
> features defined by the upcoming SCMIv3.0 specification, whose BETA
> release is available at [1].
> 
> The series is currently based on for-next/scmi [2] on top of:
> 
> commit b141fca08207 ("firmware: arm_scmi: Fix missing destroy_workqueue()")
> 
> [...]

Applied to sudeep.holla/linux (for-next/scmi), thanks!

[1/6] firmware: arm_scmi: Rework scmi_sensors_protocol_init
      https://git.kernel.org/sudeep.holla/c/f25fb6de67
[2/6] firmware: arm_scmi: Add SCMI v3.0 sensors descriptors extensions
      https://git.kernel.org/sudeep.holla/c/1fe00b8b42
[3/6] hwmon: (scmi) Update hwmon internal scale data type
      https://git.kernel.org/sudeep.holla/c/d7971d57d2
[4/6] firmware: arm_scmi: Add SCMI v3.0 sensors timestamped reads
      https://git.kernel.org/sudeep.holla/c/e2083d3673
[5/6] firmware: arm_scmi: Add SCMI v3.0 sensor configuration support
      https://git.kernel.org/sudeep.holla/c/7b83c5f410
[6/6] firmware: arm_scmi: Add SCMI v3.0 sensor notifications
      https://git.kernel.org/sudeep.holla/c/e3811190ac

--
Regards,
Sudeep