| Message ID | 20210222194158.12342-1-pali@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz | expand |
Hello Gregory! Patches are the for almost two months and more people have tested them. They are marked with Fixed/CC-stable tags, they should go also into stable trees as they are fixing CPU scaling and instability issues. Are there any issues with these patches? If not, could you please merge them for upcoming Linux version? On Monday 22 February 2021 20:41:48 Pali Rohár wrote: > Hello! > > This is third version of patches for Armada 37xx cpufreq driver which > fix CPU scaling with 1 GHz base frequency. > > The only change in this third version is modified patch 04/10 with fixes > for 1.2 GHz variant of Espressobin. Minimal CPU voltage in L1 load for > 1.2 GHz variant was increased to 1.155V. > > Patches are now rebased on top of the kernel version 5.11 with all > collected Acked-by/Tested-by lines and are available also in my git > tree in branch a3720-cpufreq-issues: > > https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=a3720-cpufreq-issues > > If you have other Armada 3720 boards with 1.2 GHz CPU, including > Espressobin V7, let us know if it is working fine for you. > > Marek & Pali > > Marek Behún (3): > arm64: dts: marvell: armada-37xx: add syscon compatible to NB clk node > cpufreq: armada-37xx: Fix setting TBG parent for load levels > clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM > clock > > Pali Rohár (7): > cpufreq: armada-37xx: Fix the AVS value for load L1 > clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to > 1 GHz > clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 > to L0 > cpufreq: armada-37xx: Fix driver cleanup when registration failed > cpufreq: armada-37xx: Fix determining base CPU frequency > cpufreq: armada-37xx: Remove cur_frequency variable > cpufreq: armada-37xx: Fix module unloading > > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 3 +- > drivers/clk/mvebu/armada-37xx-periph.c | 83 +++++++------- > drivers/cpufreq/armada-37xx-cpufreq.c | 111 +++++++++++++++---- > 3 files changed, 135 insertions(+), 62 deletions(-) > > -- > 2.20.1 >
Hello Pali, > Hello Gregory! > > Patches are the for almost two months and more people have tested them. > They are marked with Fixed/CC-stable tags, they should go also into > stable trees as they are fixing CPU scaling and instability issues. > > Are there any issues with these patches? If not, could you please merge > them for upcoming Linux version? Actually I am not the maintainer of the clk and cpufreq subsystems, so the only thing I can apply is the device tree relative patch. Gregory > > On Monday 22 February 2021 20:41:48 Pali Rohár wrote: >> Hello! >> >> This is third version of patches for Armada 37xx cpufreq driver which >> fix CPU scaling with 1 GHz base frequency. >> >> The only change in this third version is modified patch 04/10 with fixes >> for 1.2 GHz variant of Espressobin. Minimal CPU voltage in L1 load for >> 1.2 GHz variant was increased to 1.155V. >> >> Patches are now rebased on top of the kernel version 5.11 with all >> collected Acked-by/Tested-by lines and are available also in my git >> tree in branch a3720-cpufreq-issues: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=a3720-cpufreq-issues >> >> If you have other Armada 3720 boards with 1.2 GHz CPU, including >> Espressobin V7, let us know if it is working fine for you. >> >> Marek & Pali >> >> Marek Behún (3): >> arm64: dts: marvell: armada-37xx: add syscon compatible to NB clk node >> cpufreq: armada-37xx: Fix setting TBG parent for load levels >> clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM >> clock >> >> Pali Rohár (7): >> cpufreq: armada-37xx: Fix the AVS value for load L1 >> clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to >> 1 GHz >> clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 >> to L0 >> cpufreq: armada-37xx: Fix driver cleanup when registration failed >> cpufreq: armada-37xx: Fix determining base CPU frequency >> cpufreq: armada-37xx: Remove cur_frequency variable >> cpufreq: armada-37xx: Fix module unloading >> >> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 3 +- >> drivers/clk/mvebu/armada-37xx-periph.c | 83 +++++++------- >> drivers/cpufreq/armada-37xx-cpufreq.c | 111 +++++++++++++++---- >> 3 files changed, 135 insertions(+), 62 deletions(-) >> >> -- >> 2.20.1 >>
On Fri, 12 Mar 2021 10:12:06 +0100 Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > Hello Pali, > > > Hello Gregory! > > > > Patches are the for almost two months and more people have tested them. > > They are marked with Fixed/CC-stable tags, they should go also into > > stable trees as they are fixing CPU scaling and instability issues. > > > > Are there any issues with these patches? If not, could you please merge > > them for upcoming Linux version? > > Actually I am not the maintainer of the clk and cpufreq subsystems, so > the only thing I can apply is the device tree relative patch. > > Gregory Gregory, could you at least add Acked-by, or Reviewed-by? So that clk subsystem maintainer will trust these changes, since you are the original author of armada-37xx-periph. Marek
On Friday 12 March 2021 10:12:06 Gregory CLEMENT wrote: > Hello Pali, > > > Hello Gregory! > > > > Patches are the for almost two months and more people have tested them. > > They are marked with Fixed/CC-stable tags, they should go also into > > stable trees as they are fixing CPU scaling and instability issues. > > > > Are there any issues with these patches? If not, could you please merge > > them for upcoming Linux version? > > Actually I am not the maintainer of the clk and cpufreq subsystems, so > the only thing I can apply is the device tree relative patch. > > Gregory Hello Gregory! Could you please at least review this patches, so other maintainers could merge them?
Quoting Pali Rohár (2021-03-28 04:31:02) > On Friday 12 March 2021 10:12:06 Gregory CLEMENT wrote: > > Hello Pali, > > > > > Hello Gregory! > > > > > > Patches are the for almost two months and more people have tested them. > > > They are marked with Fixed/CC-stable tags, they should go also into > > > stable trees as they are fixing CPU scaling and instability issues. > > > > > > Are there any issues with these patches? If not, could you please merge > > > them for upcoming Linux version? > > > > Actually I am not the maintainer of the clk and cpufreq subsystems, so > > the only thing I can apply is the device tree relative patch. > > > > Gregory > > Hello Gregory! Could you please at least review this patches, so other > maintainers could merge them? Maybe it can merge through cpufreq tree? I've already acked the clk driver patches I believe.
Hello! This is third version of patches for Armada 37xx cpufreq driver which fix CPU scaling with 1 GHz base frequency. The only change in this third version is modified patch 04/10 with fixes for 1.2 GHz variant of Espressobin. Minimal CPU voltage in L1 load for 1.2 GHz variant was increased to 1.155V. Patches are now rebased on top of the kernel version 5.11 with all collected Acked-by/Tested-by lines and are available also in my git tree in branch a3720-cpufreq-issues: https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=a3720-cpufreq-issues If you have other Armada 3720 boards with 1.2 GHz CPU, including Espressobin V7, let us know if it is working fine for you. Marek & Pali Marek Behún (3): arm64: dts: marvell: armada-37xx: add syscon compatible to NB clk node cpufreq: armada-37xx: Fix setting TBG parent for load levels clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock Pali Rohár (7): cpufreq: armada-37xx: Fix the AVS value for load L1 clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 to L0 cpufreq: armada-37xx: Fix driver cleanup when registration failed cpufreq: armada-37xx: Fix determining base CPU frequency cpufreq: armada-37xx: Remove cur_frequency variable cpufreq: armada-37xx: Fix module unloading arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 3 +- drivers/clk/mvebu/armada-37xx-periph.c | 83 +++++++------- drivers/cpufreq/armada-37xx-cpufreq.c | 111 +++++++++++++++---- 3 files changed, 135 insertions(+), 62 deletions(-)