mbox series

[0/3] Refine mtk-cmdq-mailbox callback mechanism

Message ID 20210314233323.23377-1-chunkuang.hu@kernel.org (mailing list archive)
Headers show
Series Refine mtk-cmdq-mailbox callback mechanism | expand

Message

Chun-Kuang Hu March 14, 2021, 11:33 p.m. UTC 
mtk-cmdq-mailbox use proprietary callback mechanism and proprietary
error number, but these could be replaced by standard callback
mechanism and standard error number. In addition, use cmdq_pkt as
callback data to prevent redundnat assignment.

Because client driver still use proprietary mechanism, so keep
proprietary mechanism until client driver use the standard one.

Chun-Kuang Hu (3):
  mailbox: mtk-cmdq: Remove cmdq_cb_status
  mailbox: mtk-cmdq: Use mailbox rx_callback
  mailbox: mtk-cmdq: Add struct cmdq_pkt in struct cmdq_cb_data

 drivers/mailbox/mtk-cmdq-mailbox.c       | 24 +++++++++++++++---------
 include/linux/mailbox/mtk-cmdq-mailbox.h |  8 ++------
 2 files changed, 17 insertions(+), 15 deletions(-)

Comments

Chun-Kuang Hu April 3, 2021, 2:42 a.m. UTC | #1 
Hi, Jassi:

Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2021年3月15日 週一 上午7:33寫道：
>
> mtk-cmdq-mailbox use proprietary callback mechanism and proprietary
> error number, but these could be replaced by standard callback
> mechanism and standard error number. In addition, use cmdq_pkt as
> callback data to prevent redundnat assignment.
>
> Because client driver still use proprietary mechanism, so keep
> proprietary mechanism until client driver use the standard one.

How do you think about this series?

Regards,
Chun-Kuang.

>
> Chun-Kuang Hu (3):
>   mailbox: mtk-cmdq: Remove cmdq_cb_status
>   mailbox: mtk-cmdq: Use mailbox rx_callback
>   mailbox: mtk-cmdq: Add struct cmdq_pkt in struct cmdq_cb_data
>
>  drivers/mailbox/mtk-cmdq-mailbox.c       | 24 +++++++++++++++---------
>  include/linux/mailbox/mtk-cmdq-mailbox.h |  8 ++------
>  2 files changed, 17 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>
Chun-Kuang Hu May 26, 2021, 6:13 a.m. UTC | #2 
+ Yongqiang.

Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2021年3月15日 週一 上午7:33寫道：
>
> mtk-cmdq-mailbox use proprietary callback mechanism and proprietary
> error number, but these could be replaced by standard callback
> mechanism and standard error number. In addition, use cmdq_pkt as
> callback data to prevent redundnat assignment.
>
> Because client driver still use proprietary mechanism, so keep
> proprietary mechanism until client driver use the standard one.
>
> Chun-Kuang Hu (3):
>   mailbox: mtk-cmdq: Remove cmdq_cb_status
>   mailbox: mtk-cmdq: Use mailbox rx_callback
>   mailbox: mtk-cmdq: Add struct cmdq_pkt in struct cmdq_cb_data
>
>  drivers/mailbox/mtk-cmdq-mailbox.c       | 24 +++++++++++++++---------
>  include/linux/mailbox/mtk-cmdq-mailbox.h |  8 ++------
>  2 files changed, 17 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>
Yongqiang Niu May 26, 2021, 6:34 a.m. UTC | #3 
Reviewed-by: Yongqiang Niu <yongqiang.niu@mediatek.com>

On Wed, 2021-05-26 at 14:13 +0800, Chun-Kuang Hu wrote:
> + Yongqiang.
> 
> Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2021年3月15日 週一 上午7:33寫道：
> >
> > mtk-cmdq-mailbox use proprietary callback mechanism and proprietary
> > error number, but these could be replaced by standard callback
> > mechanism and standard error number. In addition, use cmdq_pkt as
> > callback data to prevent redundnat assignment.
> >
> > Because client driver still use proprietary mechanism, so keep
> > proprietary mechanism until client driver use the standard one.
> >
> > Chun-Kuang Hu (3):
> >   mailbox: mtk-cmdq: Remove cmdq_cb_status
> >   mailbox: mtk-cmdq: Use mailbox rx_callback
> >   mailbox: mtk-cmdq: Add struct cmdq_pkt in struct cmdq_cb_data
> >
> >  drivers/mailbox/mtk-cmdq-mailbox.c       | 24 +++++++++++++++---------
> >  include/linux/mailbox/mtk-cmdq-mailbox.h |  8 ++------
> >  2 files changed, 17 insertions(+), 15 deletions(-)
> >
> > --
> > 2.17.1
> >