From patchwork Wed Mar 17 21:41:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hawa, Hanna" X-Patchwork-Id: 12147031 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11569C433DB for ; Wed, 17 Mar 2021 21:45:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5035A64E64 for ; Wed, 17 Mar 2021 21:45:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5035A64E64 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=ttQ0g3/sc9Wa4KbAxHt/UbdWOau4e8DAoh3tZf1x1no=; b=NUiI0SCIJhjEwlXB1aoB1iCCvx NXA+htcz8x77GWjY/WaQd5myvKV+dOV4MKk0+RBkIztMVmOvu1nDAxZBOXzWx/8YU4CKs6XHCJ8i8 OPYXxKgdufhUdeKyj/t5dq0cDPV2Gk1/rTCMDJJlk4Ee8DebqlAWzftbmuHj+aexrCRUrKEwJgxtl 17vw8YKUhsxLPBNkS0ex2ie4KcmGuUqNSC+yH62OIIlkKBHHTjdbnodMVmuWioXEcKviT9vYw+hcB +FTPiDd1x9Hup99MDLMI2SV/1+JpVYhtie98ONujW6q75Cje7r8bAjCA9gqvgDPfDieVXZs7NfXJN yzamXTNQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMdwo-003xbA-S1; Wed, 17 Mar 2021 21:43:23 +0000 Received: from smtp-fw-9102.amazon.com ([207.171.184.29]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMdw4-003xS0-SU for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 21:42:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1616017357; x=1647553357; h=from:to:cc:subject:date:message-id:mime-version; bh=ryYbmSSSIni1SGHu36pR/awB6W0nYNB7Y0ksDQHqxeQ=; b=dfpeMesSkhXBI/bPNvD+7sf5UxNLC6a6ipHJh9Y7o+HOaHib+3YFxqU9 Q802UQ/DX06ugYAt96NT1ouxNQsXnAY6Dc+G+Hyy7jGRrKgXpGZWqfrX6 MRkBtL/Jcav+8YveNIjAXPZlEZHDn2a7A0k95H72+dJa4EsSWWfDmx7ar E=; X-IronPort-AV: E=Sophos;i="5.81,257,1610409600"; d="scan'208";a="121282078" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2c-76e0922c.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 17 Mar 2021 21:42:14 +0000 Received: from EX13D19EUB003.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2c-76e0922c.us-west-2.amazon.com (Postfix) with ESMTPS id 0B330A1C4C; Wed, 17 Mar 2021 21:42:12 +0000 (UTC) Received: from u8a88181e7b2355.ant.amazon.com (10.43.161.86) by EX13D19EUB003.ant.amazon.com (10.43.166.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 17 Mar 2021 21:42:05 +0000 From: Hanna Hawa To: , , , CC: , , , , , , , , , , , Subject: [PATCH v2 0/3] Fix pinctrl-single pcs_pin_dbg_show() Date: Wed, 17 Mar 2021 23:41:46 +0200 Message-ID: <20210317214149.20833-1-hhhawa@amazon.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.43.161.86] X-ClientProxiedBy: EX13D48UWB004.ant.amazon.com (10.43.163.74) To EX13D19EUB003.ant.amazon.com (10.43.166.69) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_214237_590461_9F080417 X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These patches fix the pcs_pin_dbg_show() function for the scenario where a single register controls multiple pins (i.e. bits_per_mux is not zero) Additionally, the common formula is moved to a separate function to allow reuse. Changes since v2: ----------------- - move read() register to be outside of if condition (as it common read()). - Remove extra parentheses - replace offset variable by direct return statements Changes since v1: ----------------- - remove unused variable in In function 'pcs_allocate_pin_table' (Reported-by: kernel test robot ) Hanna Hawa (3): pinctrl: pinctrl-single: remove unused variable pinctrl: pinctrl-single: remove unused parameter pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero drivers/pinctrl/pinctrl-single.c | 67 +++++++++++++++++++------------- 1 file changed, 39 insertions(+), 28 deletions(-)