From patchwork Thu Apr 1 21:21:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 12179591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDA3C433B4 for ; Thu, 1 Apr 2021 21:29:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29E38610F8 for ; Thu, 1 Apr 2021 21:29:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29E38610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=lxCX5jo9niLMujblfCOpJj+OnUl6JUVINlIZsxa3rdY=; b=Bdf6B6BB0GMstX7Lb+lesOQvIw sMomcVFdn0T0sDLhFSlIWgCSTUPWGHBnurVJI0TUiOR/EJv1ugGiXMTSVvbDE812CF1c5xpvgJ64z ZcII/IyvlxRzJG6AEDiL2AflCTzYnrCn22Y7dddKAQ1Se1T+F7s8xAo1Snnm7oCwWr/M8MrXWIkh5 gIGvaO1Gv+oiSklbYoiq28w3DyPPqS2uE0w74FLy1M8nVX9wq5Y7Vu4TsHYzBWv6Qz6ewQuMDeTIG n2yO7FEeHGloAabmrMIikbke+3jQMLTgPimvEVomRL+lmaIj5HQnmdD0Tw25wI7kQ5C9R2GQhIKsu WAUl1IsQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lS4q0-00B3PG-Dj; Thu, 01 Apr 2021 21:26:48 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lS4lH-00B35E-J0; Thu, 01 Apr 2021 21:22:53 +0000 Received: by mail-pg1-x534.google.com with SMTP id f10so2366714pgl.9; Thu, 01 Apr 2021 14:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OHE1y+eUnZAiDLwSXNcb4ovsHCQvOvUGaM/Io3DNmX0=; b=Sjy1iuHn9ODDZaLLgb2NNlK7G2oAtZJn/2neR52Op5u5nRlJZYNLZCWWYw/d58ckk5 hFXfhFhu2m7CKBch0OQkKn3Oo/uxZb9UYEAuvwb/10jevc1R/rUqrmA0ak4TattNmekX 0O62oa9g81S6JdYAwOedisooJjPJwuGEo0HT8eD7Flq27F4AQ33Iiuve8JzHXIvzrJB3 O1s4IgS4jgcC4L0xUwffKb64cxo3w6OMG2ymhtwOYRc+fszH5Rvf2ZiSH63uB0VCkprr 0u8HyxHZy2bRO2xfPWbeaij+rNO9B14TfjGT4MaAc4fNG/dy54gYQb57+oIe7kmRAGW7 NbrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OHE1y+eUnZAiDLwSXNcb4ovsHCQvOvUGaM/Io3DNmX0=; b=t78hjDbdO8774riPewMQHWxAfoiTxZf3hfIaWIrKOyXiw+q64WqPwnasPt9Vx+DQ1i xMMKJ3BVYHsvLf2cBwskWNTCR2NZo9nqvv7zrjjwmfOenyV6PIll5fReLZFqlE2NpLEx O3bn4KJvlRVaAlTOhdpsGoZz+96f7L9icKgiyQx0Ps/jKcC6zkDddcTVAZwiGmBip3yQ PsFuiAP87yTZsOdpFGif8jJmLzdWvVCJrvLcTXKhY0F0EkzMRnfjZNkC72U7iU+/T4dG MVhs18QUizxowxsFBrPrApOgbgjz2tN4p+/aLJuHHCgbnEkhpwJAygJByoPuhKnFGny1 4oIA== X-Gm-Message-State: AOAM533HZWAnNi5E/s9ckgPgRz6DqfzqA0H+21MmHsf40fo80a6O5uA+ K0lVsghcx3EahWnIsg+XSYA= X-Google-Smtp-Source: ABdhPJxszLrpfuP3/ZKD67bhlY85aoIE1kPVDcjSqf86JpqVUuE6MVzUfC6KWWF63z20Qun0aYENmw== X-Received: by 2002:a63:4522:: with SMTP id s34mr9102188pga.250.1617312113217; Thu, 01 Apr 2021 14:21:53 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id q5sm5926707pfk.219.2021.04.01.14.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 14:21:52 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Florian Fainelli , Jim Quinlan , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Lorenzo Pieralisi Subject: [PATCH v4 0/6] PCI: brcmstb: add slot0 device regulators and panic handler Date: Thu, 1 Apr 2021 17:21:40 -0400 Message-Id: <20210401212148.47033-1-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_222249_693233_B0002D2A X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v4 [NOTE: I'm not sure this fixes RobH and MarkB constraints but I'd like to use this pullreq as a basis for future discussion.] [Commit: Add bindings for ...] -- Fix syntax error in YAML bindings example (RobH) -- {vpcie12v,vpcie3v3}-supply props are back in root complex DT node (I believe RobH said this was okay) [Commit: Add control of ..] -- Do not do global search for regulator; now we look specifically for the property {vpcie12v,vpcie3v3}-supply in the root complex DT node and then call devm_regulator_bulk_get() (MarkB) -- Use devm_regulator_bulk_get() (Bjorn) -- s/EP/slot0 device/ (Bjorn) -- Spelling, capitalization (Bjorn) -- Have brcm_phy_stop() return a void (Bjorn) [Commit: Do not turn off ...] -- Capitalization (Bjorn) [Commit: Check return value ...] -- Commit message content (Bjorn) -- Move 6/6 hunk to 2/6 where it belongs (Bjorn) -- Move the rest of 6/6 before all other commits (Bjorn) v3 -- Driver now searches for EP DT subnode for any regulators to turn on. If present, these regulators have the property names "vpcie12v-supply" and "vpcie3v3-supply". The existence of these regulators in the EP subnode are currently pending as a pullreq in pci-bus.yaml at https://github.com/devicetree-org/dt-schema/pull/54 (MarkB, RobH). -- Check return of brcm_set_regulators() (Florian) -- Specify one regulator string per line for easier update (Florian) -- Author/Committer/Signoff email changed from that of V2 from 'james.quinlan@broadcom.com' to 'jim2101024@gmail.com'. v2 -- Use regulator bulk API rather than multiple calls (MarkB). v1 -- Bindings are added for fixed regulators that may power the EP device. -- The brcmstb RC driver is modified to control these regulators during probe, suspend, and resume. -- 7216 type SOCs have additional error reporting HW and a panic handler is added to dump its info. -- A missing return value check is added. Jim Quinlan (6): PCI: brcmstb: Check return value of clk_prepare_enable() dt-bindings: PCI: Add bindings for Brcmstb endpoint device voltage regulators PCI: brcmstb: Add control of slot0 device voltage regulators PCI: brcmstb: Do not turn off regulators if EP can wake up PCI: brcmstb: Give 7216 SOCs their own config type PCI: brcmstb: Add panic/die handler to RC driver .../bindings/pci/brcm,stb-pcie.yaml | 4 + drivers/pci/controller/pcie-brcmstb.c | 262 +++++++++++++++++- 2 files changed, 259 insertions(+), 7 deletions(-)