[v1,0/2] Add imx8m power domain driver

Message ID	20210402164506.520121-1-adrien.grassein@gmail.com (mailing list archive)
Headers	show Return-Path: <SRS0=Uu9Z=I7=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E25E461163 From: Adrien Grassein <adrien.grassein@gmail.com> To: Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, lgirdwood@gmail.com, broonie@kernel.org, arnd@arndb.de, peng.fan@nxp.com, Anson.Huang@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Adrien Grassein <adrien.grassein@gmail.com> Subject: [PATCH v1 0/2] Add imx8m power domain driver Date: Fri, 2 Apr 2021 18:45:04 +0200 Message-Id: <20210402164506.520121-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org
Series	Add imx8m power domain driver \| expand [v1,0/2] Add imx8m power domain driver [v1,1/2] dt-bindings: power: Add documentation for imx8m power domain driver [v1,2/2] soc: imx: add Power Domain driver for i.MX8M(M\|N\|P)

Adrien Grassein April 2, 2021, 4:45 p.m. UTC

Hi,

this patch et aims to add the support of the i.MX 8 Power Domain driver.
Some devices (like usbotg2) can't work without this patch as their
attached power domain are down.

The original drivr was taken from le imx kernel and aapted to fit with
the actual mainline (minor fixes).

Thanks,

Adrien Grassein (2):
  dt-bindings: power: Add documentation for imx8m power domain driver
  soc: imx: add Power Domain driver for i.MX8M(M|N|P)

 .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
 MAINTAINERS                                   |  10 +
 drivers/soc/imx/Kconfig                       |   7 +
 drivers/soc/imx/Makefile                      |   1 +
 drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
 include/dt-bindings/power/imx8mm-power.h      |  21 ++
 include/dt-bindings/power/imx8mn-power.h      |  15 ++
 include/dt-bindings/power/imx8mp-power.h      |  28 +++
 include/soc/imx/imx_sip.h                     |  12 +
 9 files changed, 416 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
 create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
 create mode 100644 include/dt-bindings/power/imx8mm-power.h
 create mode 100644 include/dt-bindings/power/imx8mn-power.h
 create mode 100644 include/dt-bindings/power/imx8mp-power.h
 create mode 100644 include/soc/imx/imx_sip.h

Abel Vesa April 2, 2021, 5:42 p.m. UTC | #1

On 21-04-02 18:45:04, Adrien Grassein wrote:
> Hi,
> 
> this patch et aims to add the support of the i.MX 8 Power Domain driver.
> Some devices (like usbotg2) can't work without this patch as their
> attached power domain are down.
> 
> The original drivr was taken from le imx kernel and aapted to fit with
> the actual mainline (minor fixes).
> 
> Thanks,
> 

Big NACK for the whole series.

This approach has already been rejected upstream.

Plus, you changed the original author, this work was originally done by Jacky Bai.

> Adrien Grassein (2):
>   dt-bindings: power: Add documentation for imx8m power domain driver
>   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> 
>  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
>  MAINTAINERS                                   |  10 +
>  drivers/soc/imx/Kconfig                       |   7 +
>  drivers/soc/imx/Makefile                      |   1 +
>  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
>  include/dt-bindings/power/imx8mm-power.h      |  21 ++
>  include/dt-bindings/power/imx8mn-power.h      |  15 ++
>  include/dt-bindings/power/imx8mp-power.h      |  28 +++
>  include/soc/imx/imx_sip.h                     |  12 +
>  9 files changed, 416 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
>  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
>  create mode 100644 include/dt-bindings/power/imx8mm-power.h
>  create mode 100644 include/dt-bindings/power/imx8mn-power.h
>  create mode 100644 include/dt-bindings/power/imx8mp-power.h
>  create mode 100644 include/soc/imx/imx_sip.h
> 
> -- 
> 2.25.1
>

Adrien Grassein April 2, 2021, 5:48 p.m. UTC | #2

Hi,

Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@nxp.com> a écrit :
>
> On 21-04-02 18:45:04, Adrien Grassein wrote:
> > Hi,
> >
> > this patch et aims to add the support of the i.MX 8 Power Domain driver.
> > Some devices (like usbotg2) can't work without this patch as their
> > attached power domain are down.
> >
> > The original drivr was taken from le imx kernel and aapted to fit with
> > the actual mainline (minor fixes).
> >
> > Thanks,
> >
>
> Big NACK for the whole series.
>
> This approach has already been rejected upstream.

So what is the correct approach?
At this point otg2 node of imx8mm is not working at all (and blocks the whole
boot of the kernel)

>
> Plus, you changed the original author, this work was originally done by Jacky Bai.

I have not changed this, the original author is not mentioned on the
original patch.
(Taken from https://github.com/Freescale/linux-fslc branch 5.4-2.2.x-imx)

>
> > Adrien Grassein (2):
> >   dt-bindings: power: Add documentation for imx8m power domain driver
> >   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> >
> >  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
> >  MAINTAINERS                                   |  10 +
> >  drivers/soc/imx/Kconfig                       |   7 +
> >  drivers/soc/imx/Makefile                      |   1 +
> >  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
> >  include/dt-bindings/power/imx8mm-power.h      |  21 ++
> >  include/dt-bindings/power/imx8mn-power.h      |  15 ++
> >  include/dt-bindings/power/imx8mp-power.h      |  28 +++
> >  include/soc/imx/imx_sip.h                     |  12 +
> >  9 files changed, 416 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
> >  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
> >  create mode 100644 include/dt-bindings/power/imx8mm-power.h
> >  create mode 100644 include/dt-bindings/power/imx8mn-power.h
> >  create mode 100644 include/dt-bindings/power/imx8mp-power.h
> >  create mode 100644 include/soc/imx/imx_sip.h
> >
> > --
> > 2.25.1
> >

Thanks,

Abel Vesa April 2, 2021, 5:58 p.m. UTC | #3

On 21-04-02 19:48:41, Adrien Grassein wrote:
> Hi,
> 
> Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@nxp.com> a écrit :
> >
> > On 21-04-02 18:45:04, Adrien Grassein wrote:
> > > Hi,
> > >
> > > this patch et aims to add the support of the i.MX 8 Power Domain driver.
> > > Some devices (like usbotg2) can't work without this patch as their
> > > attached power domain are down.
> > >
> > > The original drivr was taken from le imx kernel and aapted to fit with
> > > the actual mainline (minor fixes).
> > >
> > > Thanks,
> > >
> >
> > Big NACK for the whole series.
> >
> > This approach has already been rejected upstream.
> 
> So what is the correct approach?
> At this point otg2 node of imx8mm is not working at all (and blocks the whole
> boot of the kernel)
> 

Have a look at this thread:

https://lkml.org/lkml/2020/4/27/706

> >
> > Plus, you changed the original author, this work was originally done by Jacky Bai.
> 
> I have not changed this, the original author is not mentioned on the
> original patch.

Here is the original commit:

https://github.com/Freescale/linux-fslc/commit/7ebcf5ccf423afe4ccd9c53ef204018b0b653ce0


> 
> >
> > > Adrien Grassein (2):
> > >   dt-bindings: power: Add documentation for imx8m power domain driver
> > >   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> > >
> > >  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
> > >  MAINTAINERS                                   |  10 +
> > >  drivers/soc/imx/Kconfig                       |   7 +
> > >  drivers/soc/imx/Makefile                      |   1 +
> > >  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
> > >  include/dt-bindings/power/imx8mm-power.h      |  21 ++
> > >  include/dt-bindings/power/imx8mn-power.h      |  15 ++
> > >  include/dt-bindings/power/imx8mp-power.h      |  28 +++
> > >  include/soc/imx/imx_sip.h                     |  12 +
> > >  9 files changed, 416 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
> > >  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
> > >  create mode 100644 include/dt-bindings/power/imx8mm-power.h
> > >  create mode 100644 include/dt-bindings/power/imx8mn-power.h
> > >  create mode 100644 include/dt-bindings/power/imx8mp-power.h
> > >  create mode 100644 include/soc/imx/imx_sip.h
> > >
> > > --
> > > 2.25.1
> > >
> 
> Thanks,

Adrien Grassein April 2, 2021, 6:11 p.m. UTC | #4

Le ven. 2 avr. 2021 à 19:58, Abel Vesa <abel.vesa@nxp.com> a écrit :
>
> On 21-04-02 19:48:41, Adrien Grassein wrote:
> > Hi,
> >
> > Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@nxp.com> a écrit :
> > >
> > > On 21-04-02 18:45:04, Adrien Grassein wrote:
> > > > Hi,
> > > >
> > > > this patch et aims to add the support of the i.MX 8 Power Domain driver.
> > > > Some devices (like usbotg2) can't work without this patch as their
> > > > attached power domain are down.
> > > >
> > > > The original drivr was taken from le imx kernel and aapted to fit with
> > > > the actual mainline (minor fixes).
> > > >
> > > > Thanks,
> > > >
> > >
> > > Big NACK for the whole series.
> > >
> > > This approach has already been rejected upstream.
> >
> > So what is the correct approach?
> > At this point otg2 node of imx8mm is not working at all (and blocks the whole
> > boot of the kernel)
> >
>
> Have a look at this thread:
>
> https://lkml.org/lkml/2020/4/27/706
>
Understood, so I will try to update the gpc driver (at least for otg).

> > >
> > > Plus, you changed the original author, this work was originally done by Jacky Bai.
> >
> > I have not changed this, the original author is not mentioned on the
> > original patch.
>
> Here is the original commit:
>
> https://github.com/Freescale/linux-fslc/commit/7ebcf5ccf423afe4ccd9c53ef204018b0b653ce0
>
>
> >
> > >
> > > > Adrien Grassein (2):
> > > >   dt-bindings: power: Add documentation for imx8m power domain driver
> > > >   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> > > >
> > > >  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
> > > >  MAINTAINERS                                   |  10 +
> > > >  drivers/soc/imx/Kconfig                       |   7 +
> > > >  drivers/soc/imx/Makefile                      |   1 +
> > > >  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
> > > >  include/dt-bindings/power/imx8mm-power.h      |  21 ++
> > > >  include/dt-bindings/power/imx8mn-power.h      |  15 ++
> > > >  include/dt-bindings/power/imx8mp-power.h      |  28 +++
> > > >  include/soc/imx/imx_sip.h                     |  12 +
> > > >  9 files changed, 416 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
> > > >  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
> > > >  create mode 100644 include/dt-bindings/power/imx8mm-power.h
> > > >  create mode 100644 include/dt-bindings/power/imx8mn-power.h
> > > >  create mode 100644 include/dt-bindings/power/imx8mp-power.h
> > > >  create mode 100644 include/soc/imx/imx_sip.h
> > > >
> > > > --
> > > > 2.25.1
> > > >
> >
> > Thanks,

Thanks,

Adam Ford April 2, 2021, 10:09 p.m. UTC | #5

On Fri, Apr 2, 2021 at 1:16 PM Adrien Grassein
<adrien.grassein@gmail.com> wrote:
>
> Le ven. 2 avr. 2021 à 19:58, Abel Vesa <abel.vesa@nxp.com> a écrit :
> >
> > On 21-04-02 19:48:41, Adrien Grassein wrote:
> > > Hi,
> > >
> > > Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@nxp.com> a écrit :
> > > >
> > > > On 21-04-02 18:45:04, Adrien Grassein wrote:
> > > > > Hi,
> > > > >
> > > > > this patch et aims to add the support of the i.MX 8 Power Domain driver.
> > > > > Some devices (like usbotg2) can't work without this patch as their
> > > > > attached power domain are down.
> > > > >
> > > > > The original drivr was taken from le imx kernel and aapted to fit with
> > > > > the actual mainline (minor fixes).
> > > > >
> > > > > Thanks,
> > > > >
> > > >
> > > > Big NACK for the whole series.
> > > >
> > > > This approach has already been rejected upstream.
> > >
> > > So what is the correct approach?
> > > At this point otg2 node of imx8mm is not working at all (and blocks the whole
> > > boot of the kernel)
> > >
> >
> > Have a look at this thread:
> >
> > https://lkml.org/lkml/2020/4/27/706
> >
> Understood, so I will try to update the gpc driver (at least for otg).

Thanks for doing that. I know Lucas tried a few times to get something
going.  I'm willing to adapt whatever work you do on the Mini toward
the Nano if you don't have time.

adam
>
> > > >
> > > > Plus, you changed the original author, this work was originally done by Jacky Bai.
> > >
> > > I have not changed this, the original author is not mentioned on the
> > > original patch.
> >
> > Here is the original commit:
> >
> > https://github.com/Freescale/linux-fslc/commit/7ebcf5ccf423afe4ccd9c53ef204018b0b653ce0
> >
> >
> > >
> > > >
> > > > > Adrien Grassein (2):
> > > > >   dt-bindings: power: Add documentation for imx8m power domain driver
> > > > >   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> > > > >
> > > > >  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
> > > > >  MAINTAINERS                                   |  10 +
> > > > >  drivers/soc/imx/Kconfig                       |   7 +
> > > > >  drivers/soc/imx/Makefile                      |   1 +
> > > > >  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
> > > > >  include/dt-bindings/power/imx8mm-power.h      |  21 ++
> > > > >  include/dt-bindings/power/imx8mn-power.h      |  15 ++
> > > > >  include/dt-bindings/power/imx8mp-power.h      |  28 +++
> > > > >  include/soc/imx/imx_sip.h                     |  12 +
> > > > >  9 files changed, 416 insertions(+)
> > > > >  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
> > > > >  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
> > > > >  create mode 100644 include/dt-bindings/power/imx8mm-power.h
> > > > >  create mode 100644 include/dt-bindings/power/imx8mn-power.h
> > > > >  create mode 100644 include/dt-bindings/power/imx8mp-power.h
> > > > >  create mode 100644 include/soc/imx/imx_sip.h
> > > > >
> > > > > --
> > > > > 2.25.1
> > > > >
> > >
> > > Thanks,
>
> Thanks,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Adrien Grassein April 2, 2021, 10:26 p.m. UTC | #6

Hi,

Le sam. 3 avr. 2021 à 00:10, Adam Ford <aford173@gmail.com> a écrit :
>
> On Fri, Apr 2, 2021 at 1:16 PM Adrien Grassein
> <adrien.grassein@gmail.com> wrote:
> >
> > Le ven. 2 avr. 2021 à 19:58, Abel Vesa <abel.vesa@nxp.com> a écrit :
> > >
> > > On 21-04-02 19:48:41, Adrien Grassein wrote:
> > > > Hi,
> > > >
> > > > Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@nxp.com> a écrit :
> > > > >
> > > > > On 21-04-02 18:45:04, Adrien Grassein wrote:
> > > > > > Hi,
> > > > > >
> > > > > > this patch et aims to add the support of the i.MX 8 Power Domain driver.
> > > > > > Some devices (like usbotg2) can't work without this patch as their
> > > > > > attached power domain are down.
> > > > > >
> > > > > > The original drivr was taken from le imx kernel and aapted to fit with
> > > > > > the actual mainline (minor fixes).
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > >
> > > > > Big NACK for the whole series.
> > > > >
> > > > > This approach has already been rejected upstream.
> > > >
> > > > So what is the correct approach?
> > > > At this point otg2 node of imx8mm is not working at all (and blocks the whole
> > > > boot of the kernel)
> > > >
> > >
> > > Have a look at this thread:
> > >
> > > https://lkml.org/lkml/2020/4/27/706
> > >
> > Understood, so I will try to update the gpc driver (at least for otg).
>
> Thanks for doing that. I know Lucas tried a few times to get something
> going.  I'm willing to adapt whatever work you do on the Mini toward
> the Nano if you don't have time.
>

NP, the problem here is that I don't have an Nano to test.

> adam
> >
> > > > >
> > > > > Plus, you changed the original author, this work was originally done by Jacky Bai.
> > > >
> > > > I have not changed this, the original author is not mentioned on the
> > > > original patch.
> > >
> > > Here is the original commit:
> > >
> > > https://github.com/Freescale/linux-fslc/commit/7ebcf5ccf423afe4ccd9c53ef204018b0b653ce0
> > >
> > >
> > > >
> > > > >
> > > > > > Adrien Grassein (2):
> > > > > >   dt-bindings: power: Add documentation for imx8m power domain driver
> > > > > >   soc: imx: add Power Domain driver for i.MX8M(M|N|P)
> > > > > >
> > > > > >  .../bindings/power/fsl,imx-power-domain.yaml  |  89 +++++++
> > > > > >  MAINTAINERS                                   |  10 +
> > > > > >  drivers/soc/imx/Kconfig                       |   7 +
> > > > > >  drivers/soc/imx/Makefile                      |   1 +
> > > > > >  drivers/soc/imx/imx8m_pm_domains.c            | 233 ++++++++++++++++++
> > > > > >  include/dt-bindings/power/imx8mm-power.h      |  21 ++
> > > > > >  include/dt-bindings/power/imx8mn-power.h      |  15 ++
> > > > > >  include/dt-bindings/power/imx8mp-power.h      |  28 +++
> > > > > >  include/soc/imx/imx_sip.h                     |  12 +
> > > > > >  9 files changed, 416 insertions(+)
> > > > > >  create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml
> > > > > >  create mode 100644 drivers/soc/imx/imx8m_pm_domains.c
> > > > > >  create mode 100644 include/dt-bindings/power/imx8mm-power.h
> > > > > >  create mode 100644 include/dt-bindings/power/imx8mn-power.h
> > > > > >  create mode 100644 include/dt-bindings/power/imx8mp-power.h
> > > > > >  create mode 100644 include/soc/imx/imx_sip.h
> > > > > >
> > > > > > --
> > > > > > 2.25.1
> > > > > >
> > > >
> > > > Thanks,
> >
> > Thanks,
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Thanks,

[v1,0/2] Add imx8m power domain driver

Message

Comments