From patchwork Mon Apr 5 15:50:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 12183073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A2EC433B4 for ; Mon, 5 Apr 2021 15:53:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D35F61165 for ; Mon, 5 Apr 2021 15:53:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D35F61165 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=AkK5FduD09CfGhbYw6+j4y7hsSeaJSmuhThQ/9kVDjc=; b=G6J52k4Cv9xffS1WRTtQ0czx8C hkLuX2sRbw6P1Duy0iiTjqYAynxlDl0FotfuqaTlcV5Ed1vgRwnPYs4EQQrnnxoU6AIDxfsRQsZW5 KYmyngf0cQ1mxV/JM1rDv7yOZM3wn2NfvO9vQuLt+WvotmYabNgEpX8vxlezDAOX0Y0utMRRkqHIE i5Ae1jc+N8euVnU+CNjPnehN0+t7PpBR2O+RDAqvYssquKDUFXPz5h5C8Hgf2OvS5xbl08NOffRtg xYmnsIxVyZGHwZRnaUCHtIyiDRisHJ3tbKl7oYnkkar4u9u5oxHnCVtym/6d0U+iN2fuPglb4YpbK +sjAfIVg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTRW3-00HW5S-Mx; Mon, 05 Apr 2021 15:51:51 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTRVz-00HW4t-Ce for linux-arm-kernel@lists.infradead.org; Mon, 05 Apr 2021 15:51:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1617637907; x=1649173907; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IzWL5rMe178emJ/yAcOpVpD5OzbH2As9J+9cxuGn0Pw=; b=SUqp0rIZFlH+CdV51YOY/W8uAWeOjgAmEgK5dxR/yiE8fiPecWPMvYyJ hWVcaBQuOxqKpD6StbHDewVd9JwL/NGCHqGEEVpOhPjqgvGCQB2u1zihy iqVpIwgtun/H5ncAvwgzQYTnR7e3anhcPUvEQJigbPBIy+B0fF+liqhAU 4p6zdg3rHUa3tfwEDUo9JIbUz1ZqcW3+AezFpaG9QfBrSKi/NZsTFMYE8 nytLQPro1O30Jx4gkoie5ThJfBHKZwI/GH7Fltif8wq37kfLHQMU3sDMd 2YIuA4hwfT+C2b+wbBzWasiMa6TXDaxGbdpTVLrqoUMZzYzNvknhWDGfo g==; IronPort-SDR: o3t4j2y0EjXDeXDZpHFdMS3OyBfD3hRPyVZhv0TLCA7/MHgCWcYEe0A+wCcJ9XpUcZv4vsOVtJ hzL0Ik4StmbQaZy/65e41qbXf9DvKhq1U+AnX/EQdBwbqfk0drzjiqa+FQLxK2jDvFZF+Jm2Da fVE/3n7QE54KCmCE1NWh/8KfrxGR6dBC/AkedLpVyqgAmlmdEnK0NZSd1Tc87OPEyOl+KlgnT0 XL7KNfnIoZiMsq28roqI0J4NdQO0hant5ZyolDxXkCN8UnbVKiN7tzWrXTPQek+0X8XoNf2SQn D3c= X-IronPort-AV: E=Sophos;i="5.81,307,1610434800"; d="scan'208";a="112481451" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Apr 2021 08:51:43 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 5 Apr 2021 08:51:43 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Mon, 5 Apr 2021 08:51:24 -0700 From: Eugen Hristev To: , CC: , , Eugen Hristev Subject: [PATCH v2 00/30] media: atmel: atmel-isc: add support for xisc Date: Mon, 5 Apr 2021 18:50:35 +0300 Message-ID: <20210405155105.162529-1-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210405_165147_825170_66358332 X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, This series adds support for a variant of the ISC named XISC. This block is present in the product named sama7g5. I started by moving code around, the code which was specialized for sama5d2 type of ISC, to have it inside the dedicated sama5d2 file. I added several new pipeline elements to the code base, which would be common to sama5d2 and the new sama7g5, but only used by the new style pipeline. I separated the input and output formats on a per-product separate array. I added the new sama7g5 compatible driver for the xisc, which is similar with the sama5d2, but with differences in terms of DT, clocks and callbacks to specific operations. I added the binding for the xisc by copying and modifying the existing isc one. I know that it has to be converted to yaml, and I will do that if it looks good. Feedback is appreciated. Thanks, Eugen Changes in v2: - Fixed krobot warnings with W=1 regarding functions with no prototype - Fixed new sama7g5 driver to use the new subdev fwnode API in kernel 5.12. my driver was based on old 5.10 style API. Eugen Hristev (30): media: atmel: atmel-isc: specialize gamma table into product specific media: atmel: atmel-isc: specialize driver name constant media: atmel: atmel-isc: add checks for limiting frame sizes media: atmel: atmel-isc: specialize max width and max height media: atmel: atmel-isc: specialize dma cfg media: atmel: atmel-isc: extract CSC submodule config into separate function media: atmel: atmel-isc-base: add id to clock debug message media: atmel: atmel-isc: create register offsets struct media: atmel: atmel-isc: extract CBC submodule config into separate function media: atmel: atmel-isc: add CBC to the reg offsets struct media: atmel: atmel-isc: add SUB422 and SUB420 to register offsets media: atmel: atmel-isc: add RLP to register offsets media: atmel: atmel-isc: add HIS to register offsets media: atmel: atmel-isc: add DMA to register offsets media: atmel: atmel-isc: add support for version register media: atmel: atmel-isc: add his_entry to register offsets media: atmel: atmel-isc: add register description for additional modules media: atmel: atmel-isc: extend pipeline with extra modules media: atmel: atmel-isc: add CC initialization function media: atmel: atmel-isc: create product specific v4l2 controls config media: atmel: atmel-isc: create callback for DPC submodule product specific media: atmel: atmel-isc: create callback for GAM submodule product specific media: atmel: atmel-isc: create callback for RLP submodule product specific media: atmel: atmel-isc: move the formats list into product specific code media: atmel: atmel-isc: create an adapt pipeline callback for product specific media: atmel: atmel-isc-regs: add additional fields for sama7g5 type pipeline media: atmel: atmel-isc-base: add support for more formats and additional pipeline modules dt-bindings: media: atmel: add microchip-xisc binding media: atmel: atmel-isc-sama5d2: remove duplicate define media: atmel: atmel-isc: add microchip-xisc driver .../bindings/media/microchip-xisc.txt | 64 ++ drivers/media/platform/Makefile | 1 + drivers/media/platform/atmel/Kconfig | 11 + drivers/media/platform/atmel/Makefile | 2 + drivers/media/platform/atmel/atmel-isc-base.c | 381 ++++------- drivers/media/platform/atmel/atmel-isc-regs.h | 133 +++- drivers/media/platform/atmel/atmel-isc.h | 122 +++- .../media/platform/atmel/atmel-sama5d2-isc.c | 311 ++++++++- .../media/platform/atmel/atmel-sama7g5-isc.c | 643 ++++++++++++++++++ 9 files changed, 1391 insertions(+), 277 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/microchip-xisc.txt create mode 100644 drivers/media/platform/atmel/atmel-sama7g5-isc.c