mbox series

[00/16] soc: imx: gpcv2: support i.MX8MM

Message ID 20210429073050.21039-1-peng.fan@oss.nxp.com (mailing list archive)
Headers show
Series soc: imx: gpcv2: support i.MX8MM | expand

Message

Peng Fan (OSS) April 29, 2021, 7:30 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

This patchset is a pick up Lucas's gpcv2 work for i.MX8MM and several
minor changes from me to make it could work with i.MX BLK-CTL driver.

Thanks for Lucas's work and suggestion, Frieder Schrempf for collecting
all the patches, Jacky Bai on help debug issues.

Lucas Stach (12):
  soc: imx: gpcv2: move to more ideomatic error handling in probe
  soc: imx: gpcv2: move domain mapping to domain driver probe
  soc: imx: gpcv2: switch to clk_bulk_* API
  soc: imx: gpcv2: split power up and power down sequence control
  soc: imx: gpcv2: wait for ADB400 handshake
  soc: imx: gpcv2: add runtime PM support for power-domains
  soc: imx: gpcv2: allow domains without power-sequence control
  dt-bindings: imx: gpcv2: add support for optional resets
  soc: imx: gpcv2: add support for optional resets
  dt-bindings: power: add defines for i.MX8MM power domains
  soc: imx: gpcv2: add support for i.MX8MM power domains
  soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX power
    domains

Peng Fan (4):
  soc: imx: gpcv2: correct pm_runtime_get_sync usage
  soc: imx: gpcv2: move reset assert after requesting domain power up
  soc: imx: gpcv2: support reset defer probe
  soc: imx: gpcv2: remove waiting handshake in power up

 .../bindings/power/fsl,imx-gpcv2.yaml         |   9 +
 drivers/soc/imx/gpcv2.c                       | 534 ++++++++++++++----
 include/dt-bindings/power/imx8mm-power.h      |  22 +
 3 files changed, 450 insertions(+), 115 deletions(-)
 create mode 100644 include/dt-bindings/power/imx8mm-power.h

Comments

Adam Ford April 29, 2021, 12:39 p.m. UTC | #1 
On Thu, Apr 29, 2021 at 1:59 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> This patchset is a pick up Lucas's gpcv2 work for i.MX8MM and several
> minor changes from me to make it could work with i.MX BLK-CTL driver.
>
> Thanks for Lucas's work and suggestion, Frieder Schrempf for collecting
> all the patches, Jacky Bai on help debug issues.

Thank for you all the work.  I have an i.MX8M Nano that I'll work to
add support for gpcv2 unless NXP has started this already.  At one
time, I posted some patches for Nano based on Lucas' work, but since
that work wasn't accepted, mine wasn't either.

adam
>
> Lucas Stach (12):
>   soc: imx: gpcv2: move to more ideomatic error handling in probe
>   soc: imx: gpcv2: move domain mapping to domain driver probe
>   soc: imx: gpcv2: switch to clk_bulk_* API
>   soc: imx: gpcv2: split power up and power down sequence control
>   soc: imx: gpcv2: wait for ADB400 handshake
>   soc: imx: gpcv2: add runtime PM support for power-domains
>   soc: imx: gpcv2: allow domains without power-sequence control
>   dt-bindings: imx: gpcv2: add support for optional resets
>   soc: imx: gpcv2: add support for optional resets
>   dt-bindings: power: add defines for i.MX8MM power domains
>   soc: imx: gpcv2: add support for i.MX8MM power domains
>   soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX power
>     domains
>
> Peng Fan (4):
>   soc: imx: gpcv2: correct pm_runtime_get_sync usage
>   soc: imx: gpcv2: move reset assert after requesting domain power up
>   soc: imx: gpcv2: support reset defer probe
>   soc: imx: gpcv2: remove waiting handshake in power up
>
>  .../bindings/power/fsl,imx-gpcv2.yaml         |   9 +
>  drivers/soc/imx/gpcv2.c                       | 534 ++++++++++++++----
>  include/dt-bindings/power/imx8mm-power.h      |  22 +
>  3 files changed, 450 insertions(+), 115 deletions(-)
>  create mode 100644 include/dt-bindings/power/imx8mm-power.h
>
> --
> 2.30.0
>
Peng Fan April 30, 2021, 1:33 a.m. UTC | #2 
> Subject: Re: [PATCH 00/16] soc: imx: gpcv2: support i.MX8MM
> 
> On Thu, Apr 29, 2021 at 1:59 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > This patchset is a pick up Lucas's gpcv2 work for i.MX8MM and several
> > minor changes from me to make it could work with i.MX BLK-CTL driver.
> >
> > Thanks for Lucas's work and suggestion, Frieder Schrempf for
> > collecting all the patches, Jacky Bai on help debug issues.
> 
> Thank for you all the work.  I have an i.MX8M Nano that I'll work to add
> support for gpcv2 unless NXP has started this already.  At one time, I posted
> some patches for Nano based on Lucas' work, but since that work wasn't
> accepted, mine wasn't either.

Please continue your work on i.MX8MN, I not work on this. The following
work from me is i.MX8MP.

Thanks,
Peng.

> 
> adam
> >
> > Lucas Stach (12):
> >   soc: imx: gpcv2: move to more ideomatic error handling in probe
> >   soc: imx: gpcv2: move domain mapping to domain driver probe
> >   soc: imx: gpcv2: switch to clk_bulk_* API
> >   soc: imx: gpcv2: split power up and power down sequence control
> >   soc: imx: gpcv2: wait for ADB400 handshake
> >   soc: imx: gpcv2: add runtime PM support for power-domains
> >   soc: imx: gpcv2: allow domains without power-sequence control
> >   dt-bindings: imx: gpcv2: add support for optional resets
> >   soc: imx: gpcv2: add support for optional resets
> >   dt-bindings: power: add defines for i.MX8MM power domains
> >   soc: imx: gpcv2: add support for i.MX8MM power domains
> >   soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX power
> >     domains
> >
> > Peng Fan (4):
> >   soc: imx: gpcv2: correct pm_runtime_get_sync usage
> >   soc: imx: gpcv2: move reset assert after requesting domain power up
> >   soc: imx: gpcv2: support reset defer probe
> >   soc: imx: gpcv2: remove waiting handshake in power up
> >
> >  .../bindings/power/fsl,imx-gpcv2.yaml         |   9 +
> >  drivers/soc/imx/gpcv2.c                       | 534
> ++++++++++++++----
> >  include/dt-bindings/power/imx8mm-power.h      |  22 +
> >  3 files changed, 450 insertions(+), 115 deletions(-)  create mode
> > 100644 include/dt-bindings/power/imx8mm-power.h
> >
> > --
> > 2.30.0
> >
Adam Ford April 30, 2021, 3:05 a.m. UTC | #3 
On Thu, Apr 29, 2021 at 8:34 PM Peng Fan <peng.fan@nxp.com> wrote:
>
> > Subject: Re: [PATCH 00/16] soc: imx: gpcv2: support i.MX8MM
> >
> > On Thu, Apr 29, 2021 at 1:59 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > wrote:
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > This patchset is a pick up Lucas's gpcv2 work for i.MX8MM and several
> > > minor changes from me to make it could work with i.MX BLK-CTL driver.
> > >
> > > Thanks for Lucas's work and suggestion, Frieder Schrempf for
> > > collecting all the patches, Jacky Bai on help debug issues.
> >
> > Thank for you all the work.  I have an i.MX8M Nano that I'll work to add
> > support for gpcv2 unless NXP has started this already.  At one time, I posted
> > some patches for Nano based on Lucas' work, but since that work wasn't
> > accepted, mine wasn't either.
>
> Please continue your work on i.MX8MN, I not work on this. The following
> work from me is i.MX8MP.

No problem.  I thought the focus would be on the 8MP,m so I went ahead
and posted a series [1] for enabling the gpcv2 for the Nano and the
power domains which don't require blk-ctl for now which include the
USB OTG, and the GPU.

If you and/or your colleagues have time to review it, it would be
appreciated.  I was able to suspend and resume with USB attached, and
it continued to operate.  I didn't do extensive testing yet.
I'm starting on the blk-ctl stuff now.  It seems to have changed quite
a bit since the initial submission from Abel, so I'll have to spend a
bit more time porting what I had before.

Thanks again for this series.  It will be nice to have the Mini, Nano
and Plus domains functional.

adam

[1] - https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210429211625.1835702-2-aford173@gmail.com/

>
> Thanks,
> Peng.
>
> >
> > adam
> > >
> > > Lucas Stach (12):
> > >   soc: imx: gpcv2: move to more ideomatic error handling in probe
> > >   soc: imx: gpcv2: move domain mapping to domain driver probe
> > >   soc: imx: gpcv2: switch to clk_bulk_* API
> > >   soc: imx: gpcv2: split power up and power down sequence control
> > >   soc: imx: gpcv2: wait for ADB400 handshake
> > >   soc: imx: gpcv2: add runtime PM support for power-domains
> > >   soc: imx: gpcv2: allow domains without power-sequence control
> > >   dt-bindings: imx: gpcv2: add support for optional resets
> > >   soc: imx: gpcv2: add support for optional resets
> > >   dt-bindings: power: add defines for i.MX8MM power domains
> > >   soc: imx: gpcv2: add support for i.MX8MM power domains
> > >   soc: imx: gpcv2: Add support for missing i.MX8MM VPU/DISPMIX power
> > >     domains
> > >
> > > Peng Fan (4):
> > >   soc: imx: gpcv2: correct pm_runtime_get_sync usage
> > >   soc: imx: gpcv2: move reset assert after requesting domain power up
> > >   soc: imx: gpcv2: support reset defer probe
> > >   soc: imx: gpcv2: remove waiting handshake in power up
> > >
> > >  .../bindings/power/fsl,imx-gpcv2.yaml         |   9 +
> > >  drivers/soc/imx/gpcv2.c                       | 534
> > ++++++++++++++----
> > >  include/dt-bindings/power/imx8mm-power.h      |  22 +
> > >  3 files changed, 450 insertions(+), 115 deletions(-)  create mode
> > > 100644 include/dt-bindings/power/imx8mm-power.h
> > >
> > > --
> > > 2.30.0
> > >