mbox series

[v6,0/3] ata: ahci_brcm: Fix use of BCM7216 reset controller

Message ID 20210430152156.21162-1-jim2101024@gmail.com (mailing list archive)
Headers show
Series ata: ahci_brcm: Fix use of BCM7216 reset controller | expand

Message

Jim Quinlan April 30, 2021, 3:21 p.m. UTC
v6 -- Added new commit which adds a missing function to the reset API.
      This fixes 557acb3d2cd9 and should be destined for linux stable.

v5 -- Improved (I hope) commit description (Bjorn).
   -- Rnamed error labels (Krzyszt).
   -- Fixed typos.

v4 -- does not rely on a pending commit, unlike v3.

v3 -- discard commit from v2; instead rely on the new function
      reset_control_rearm provided in a recent commit [1] applied
      to reset/next.
   -- New commit to correct pcie-brcmstb.c usage of a reset controller
      to use reset/rearm verses deassert/assert.

v2 -- refactor rescal-reset driver to implement assert/deassert rather than
      reset because the reset call only fires once per lifetime and we need
      to reset after every resume from S2 or S3.
   -- Split the use of "ahci" and "rescal" controllers in separate fields
      to keep things simple.

v1 -- original

Jim Quinlan (3):
  reset: add missing empty function reset_control_rearm()
  ata: ahci_brcm: Fix use of BCM7216 reset controller
  PCI: brcmstb: Use reset/rearm instead of deassert/assert

 drivers/ata/ahci_brcm.c               | 46 +++++++++++++--------------
 drivers/pci/controller/pcie-brcmstb.c | 19 +++++++----
 include/linux/reset.h                 |  5 +++
 3 files changed, 41 insertions(+), 29 deletions(-)

Comments

Bjorn Helgaas May 3, 2021, 6:57 p.m. UTC | #1
On Fri, Apr 30, 2021 at 11:21:53AM -0400, Jim Quinlan wrote:
> v6 -- Added new commit which adds a missing function to the reset API.
>       This fixes 557acb3d2cd9 and should be destined for linux stable.
> 
> v5 -- Improved (I hope) commit description (Bjorn).
>    -- Rnamed error labels (Krzyszt).
>    -- Fixed typos.
> 
> v4 -- does not rely on a pending commit, unlike v3.
> 
> v3 -- discard commit from v2; instead rely on the new function
>       reset_control_rearm provided in a recent commit [1] applied
>       to reset/next.
>    -- New commit to correct pcie-brcmstb.c usage of a reset controller
>       to use reset/rearm verses deassert/assert.
> 
> v2 -- refactor rescal-reset driver to implement assert/deassert rather than
>       reset because the reset call only fires once per lifetime and we need
>       to reset after every resume from S2 or S3.
>    -- Split the use of "ahci" and "rescal" controllers in separate fields
>       to keep things simple.
> 
> v1 -- original
> 
> Jim Quinlan (3):
>   reset: add missing empty function reset_control_rearm()
>   ata: ahci_brcm: Fix use of BCM7216 reset controller
>   PCI: brcmstb: Use reset/rearm instead of deassert/assert
> 
>  drivers/ata/ahci_brcm.c               | 46 +++++++++++++--------------
>  drivers/pci/controller/pcie-brcmstb.c | 19 +++++++----
>  include/linux/reset.h                 |  5 +++
>  3 files changed, 41 insertions(+), 29 deletions(-)

I provisionally applied these to my pci/brcmstb branch for v5.13.

I carried forward Jens' ack on "ata: ahci_brcm: Fix use of BCM7216
reset controller" since the patch is identical to the v5 version that
he acked.

I'm hoping to get an ack from Philipp for the reset.h change.

Bjorn