mbox series

[v14,0/2] leds: mt6360: Add LED driver for MT6360

Message ID 20210524152427.123856-1-gene.chen.richtek@gmail.com (mailing list archive)
Headers show
Series leds: mt6360: Add LED driver for MT6360 | expand

Message

Gene Chen May 24, 2021, 3:24 p.m. UTC
This patch series add MT6360 LED support contains driver and binding document

Gene Chen (2)
 dt-bindings: leds: Add bindings for MT6360 LED
 leds: mt6360: Add LED driver for MT6360

 Documentation/devicetree/bindings/leds/leds-mt6360.yaml |  159 ++
 drivers/leds/flash/Kconfig                              |   13 
 drivers/leds/flash/Makefile                             |    1 
 drivers/leds/flash/leds-mt6360.c                        |  910 ++++++++++++++++
 4 files changed, 1083 insertions(+)

changelogs between v1 & v2
 - add led driver with mfd

changelogs between v2 & v3
 - independent add led driver
 - add dt-binding document
 - refactor macros definition for easy to debug
 - parse device tree by fwnode
 - use devm*ext to register led class device

changelogs between v3 & v4
 - fix binding document description
 - use GENMASK and add unit postfix to definition
 - isink register led class device

changelogs between v4 & v5
 - change rgb isink to multicolor control
 - add binding reference to mfd yaml

changelogs between v5 & v6
 - Use DT to decide RGB LED is multicolor device or indicator device only

changelogs between v6 & v7
 - Add binding multicolor device sample code
 - Add flash ops mutex lock
 - Remove V4L2 init with indicator device

changelogs between v7 & v8
 - Add mutex for led fault get ops
 - Fix flash and multicolor no-ops return 0
 - Add LED_FUNCTION_MOONLIGHT

changelogs between v8 & v9
 - reuse api in flash and multicolor header

changelogs between v9 & v10
 - add comment for reuse registration functions in flash and multicolor

changelogs between v10 & v11
 - match dt-binding reg property comment to the functionality name
 - remove exist patch in linux-next
 - dicide multicolor channel by color definitiion

changelogs between v11 & v12
 - Fix print size_t by %zu
 - Fix dt-binding name regular experssion

changelogs between v12 & v13
 - Fix kbuild test rebot build error

changelogs between v13 & v14
 - Move driver to flash folder
 - Remove LED FUNCTION MOONLIGHT
 - Keep 80 char per line

Comments

Gene Chen July 12, 2021, 8:33 a.m. UTC | #1
Gene Chen <gene.chen.richtek@gmail.com> 於 2021年5月24日 週一 下午11:24寫道:
>
> This patch series add MT6360 LED support contains driver and binding document
>
> Gene Chen (2)
>  dt-bindings: leds: Add bindings for MT6360 LED
>  leds: mt6360: Add LED driver for MT6360
>
>  Documentation/devicetree/bindings/leds/leds-mt6360.yaml |  159 ++
>  drivers/leds/flash/Kconfig                              |   13
>  drivers/leds/flash/Makefile                             |    1
>  drivers/leds/flash/leds-mt6360.c                        |  910 ++++++++++++++++
>  4 files changed, 1083 insertions(+)
>
> changelogs between v1 & v2
>  - add led driver with mfd
>
> changelogs between v2 & v3
>  - independent add led driver
>  - add dt-binding document
>  - refactor macros definition for easy to debug
>  - parse device tree by fwnode
>  - use devm*ext to register led class device
>
> changelogs between v3 & v4
>  - fix binding document description
>  - use GENMASK and add unit postfix to definition
>  - isink register led class device
>
> changelogs between v4 & v5
>  - change rgb isink to multicolor control
>  - add binding reference to mfd yaml
>
> changelogs between v5 & v6
>  - Use DT to decide RGB LED is multicolor device or indicator device only
>
> changelogs between v6 & v7
>  - Add binding multicolor device sample code
>  - Add flash ops mutex lock
>  - Remove V4L2 init with indicator device
>
> changelogs between v7 & v8
>  - Add mutex for led fault get ops
>  - Fix flash and multicolor no-ops return 0
>  - Add LED_FUNCTION_MOONLIGHT
>
> changelogs between v8 & v9
>  - reuse api in flash and multicolor header
>
> changelogs between v9 & v10
>  - add comment for reuse registration functions in flash and multicolor
>
> changelogs between v10 & v11
>  - match dt-binding reg property comment to the functionality name
>  - remove exist patch in linux-next
>  - dicide multicolor channel by color definitiion
>
> changelogs between v11 & v12
>  - Fix print size_t by %zu
>  - Fix dt-binding name regular experssion
>
> changelogs between v12 & v13
>  - Fix kbuild test rebot build error
>
> changelogs between v13 & v14
>  - Move driver to flash folder
>  - Remove LED FUNCTION MOONLIGHT
>  - Keep 80 char per line
>
>

Dear Reviewers,

Please let me know if any update.
Jacek Anaszewski July 12, 2021, 8:24 p.m. UTC | #2
Hi Gene,

You still can carry my ack:

Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

On 7/12/21 10:33 AM, Gene Chen wrote:
> Gene Chen <gene.chen.richtek@gmail.com> 於 2021年5月24日 週一 下午11:24寫道:
>>
>> This patch series add MT6360 LED support contains driver and binding document
>>
>> Gene Chen (2)
>>   dt-bindings: leds: Add bindings for MT6360 LED
>>   leds: mt6360: Add LED driver for MT6360
>>
>>   Documentation/devicetree/bindings/leds/leds-mt6360.yaml |  159 ++
>>   drivers/leds/flash/Kconfig                              |   13
>>   drivers/leds/flash/Makefile                             |    1
>>   drivers/leds/flash/leds-mt6360.c                        |  910 ++++++++++++++++
>>   4 files changed, 1083 insertions(+)
>>
>> changelogs between v1 & v2
>>   - add led driver with mfd
>>
>> changelogs between v2 & v3
>>   - independent add led driver
>>   - add dt-binding document
>>   - refactor macros definition for easy to debug
>>   - parse device tree by fwnode
>>   - use devm*ext to register led class device
>>
>> changelogs between v3 & v4
>>   - fix binding document description
>>   - use GENMASK and add unit postfix to definition
>>   - isink register led class device
>>
>> changelogs between v4 & v5
>>   - change rgb isink to multicolor control
>>   - add binding reference to mfd yaml
>>
>> changelogs between v5 & v6
>>   - Use DT to decide RGB LED is multicolor device or indicator device only
>>
>> changelogs between v6 & v7
>>   - Add binding multicolor device sample code
>>   - Add flash ops mutex lock
>>   - Remove V4L2 init with indicator device
>>
>> changelogs between v7 & v8
>>   - Add mutex for led fault get ops
>>   - Fix flash and multicolor no-ops return 0
>>   - Add LED_FUNCTION_MOONLIGHT
>>
>> changelogs between v8 & v9
>>   - reuse api in flash and multicolor header
>>
>> changelogs between v9 & v10
>>   - add comment for reuse registration functions in flash and multicolor
>>
>> changelogs between v10 & v11
>>   - match dt-binding reg property comment to the functionality name
>>   - remove exist patch in linux-next
>>   - dicide multicolor channel by color definitiion
>>
>> changelogs between v11 & v12
>>   - Fix print size_t by %zu
>>   - Fix dt-binding name regular experssion
>>
>> changelogs between v12 & v13
>>   - Fix kbuild test rebot build error
>>
>> changelogs between v13 & v14
>>   - Move driver to flash folder
>>   - Remove LED FUNCTION MOONLIGHT
>>   - Keep 80 char per line
>>
>>
> 
> Dear Reviewers,
> 
> Please let me know if any update.
>
Gene Chen July 16, 2021, 6:27 a.m. UTC | #3
Jacek Anaszewski <jacek.anaszewski@gmail.com> 於 2021年7月13日 週二 上午4:24寫道:
>
> Hi Gene,
>
> You still can carry my ack:
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>

Ok, thanks. I will add your ack in patch v15.

> On 7/12/21 10:33 AM, Gene Chen wrote:
> > Gene Chen <gene.chen.richtek@gmail.com> 於 2021年5月24日 週一 下午11:24寫道:
> >>
> >> This patch series add MT6360 LED support contains driver and binding document
> >>
> >> Gene Chen (2)
> >>   dt-bindings: leds: Add bindings for MT6360 LED
> >>   leds: mt6360: Add LED driver for MT6360
> >>
> >>   Documentation/devicetree/bindings/leds/leds-mt6360.yaml |  159 ++
> >>   drivers/leds/flash/Kconfig                              |   13
> >>   drivers/leds/flash/Makefile                             |    1
> >>   drivers/leds/flash/leds-mt6360.c                        |  910 ++++++++++++++++
> >>   4 files changed, 1083 insertions(+)
> >>
> >> changelogs between v1 & v2
> >>   - add led driver with mfd
> >>
> >> changelogs between v2 & v3
> >>   - independent add led driver
> >>   - add dt-binding document
> >>   - refactor macros definition for easy to debug
> >>   - parse device tree by fwnode
> >>   - use devm*ext to register led class device
> >>
> >> changelogs between v3 & v4
> >>   - fix binding document description
> >>   - use GENMASK and add unit postfix to definition
> >>   - isink register led class device
> >>
> >> changelogs between v4 & v5
> >>   - change rgb isink to multicolor control
> >>   - add binding reference to mfd yaml
> >>
> >> changelogs between v5 & v6
> >>   - Use DT to decide RGB LED is multicolor device or indicator device only
> >>
> >> changelogs between v6 & v7
> >>   - Add binding multicolor device sample code
> >>   - Add flash ops mutex lock
> >>   - Remove V4L2 init with indicator device
> >>
> >> changelogs between v7 & v8
> >>   - Add mutex for led fault get ops
> >>   - Fix flash and multicolor no-ops return 0
> >>   - Add LED_FUNCTION_MOONLIGHT
> >>
> >> changelogs between v8 & v9
> >>   - reuse api in flash and multicolor header
> >>
> >> changelogs between v9 & v10
> >>   - add comment for reuse registration functions in flash and multicolor
> >>
> >> changelogs between v10 & v11
> >>   - match dt-binding reg property comment to the functionality name
> >>   - remove exist patch in linux-next
> >>   - dicide multicolor channel by color definitiion
> >>
> >> changelogs between v11 & v12
> >>   - Fix print size_t by %zu
> >>   - Fix dt-binding name regular experssion
> >>
> >> changelogs between v12 & v13
> >>   - Fix kbuild test rebot build error
> >>
> >> changelogs between v13 & v14
> >>   - Move driver to flash folder
> >>   - Remove LED FUNCTION MOONLIGHT
> >>   - Keep 80 char per line
> >>
> >>
> >
> > Dear Reviewers,
> >
> > Please let me know if any update.
> >
>
> --
> Best regards,
> Jacek Anaszewski