From patchwork Tue Jun 8 10:47:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 12306287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8712BC47082 for ; Tue, 8 Jun 2021 10:50:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54CDB610A1 for ; Tue, 8 Jun 2021 10:50:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54CDB610A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=qUx94N1nr1+HWazMQoJ3GUuUmuzL9y7REt0V8VXdqfg=; b=KcP+D7zvHuh8va BOqC6PIN0ZGTrEdv7wq71v7Vm6T1MihtUBZeyV0iRRnJ0evH6RbQd5JW0HBIUoSTuLp1r175nv4zr M48ZIEn228B8we5SPF8YaXPncAVQzKwFbboPdsBWKJUXAo6IoBuID/jFtEni2ETQmdxXKj9sawXa7 3Xvguq3n8kPv1pSO/iJp7cGZvWZDKWZE1EHSjIm4TTGBt7VfeTigdkX20oglezv3c/UC/RGWz31FO 4Jo1MnOsG2/rfjv92vKBQSykbSJAh+6IST2zWJW9r9Ds2VxToPXfXdMVFrRPwmCdG9QHWK8RfrR1M HLP3sevkdpUeY0UBRi/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqZHX-007lis-Fg; Tue, 08 Jun 2021 10:48:27 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqZHO-007lgY-Mt for linux-arm-kernel@lists.infradead.org; Tue, 08 Jun 2021 10:48:23 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id EF2555804DB; Tue, 8 Jun 2021 06:48:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 08 Jun 2021 06:48:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm3; bh=hDFhnDxEtjMcaTbXERTDvsX/xK lhpV/0Oa1YnvfSBwI=; b=VzWccjlcIu/Qm8khATcLiatSIK4IEbfYC2dsISfeeA i92SLTkNHZ08w6UN2FVP4ipS79QVHJtEsiLKKbtnK38U7fvk0jcdjNCOPz/LfW/z 4wlTdf2ko6wTDEcEQ+1IOtHLN046cfPgzC0YpWoaioH7zB/qO1WF57edoDzsxQ7d PhyIUXwSZnZKGggJSE10w5wfRgRwg8IYg0xWk15IG6datZfVaKfOE75QIFTrgK0u s6ZXWrwSN+Po9tvspuNKAQgj/Kn6U8Ly5foZoukqp8sFIYWGrn61G5rvL/DndudU r2HY4+VJo8HhnCsG6slFQfThm1sxwgGD1kh29VGnJB0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=hDFhnDxEtjMcaTbXE RTDvsX/xKlhpV/0Oa1YnvfSBwI=; b=dfNq/rDX+pHeucY114zvkey1sJz3QecR/ qNDIrc0HuESLEfqmxz6/EkN88sK+WySzZF89ZN3p//UakioEhSeHfGThGXNoAJl0 6ZhBe84FpBUzymjf8v2CryRjT8jxOD8FEa2gNQ+lHP+HKqzh3cT4WekBFssQTsGH n/8QVXgrbNs+TISI+ONjwA73IkN+dsv+pmIsojNShLKslMiWj7+5iXtjJ+Vz2QTi Dj/na/T/TuBCifp1FQW9yoAIVPHvf7ogrZm+pHSjHX0FJUzg1al2hQvNnAAr2ZVD bdMmGP3mpIjOKd7n6u1zP8X4nH9pKhIDCIKuVoUuk3fhuhcSuAUsA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtledgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomheptehnughrvgifucflvghffhgvrhihuceorghnughrvgifsegrjhdr ihgurdgruheqnecuggftrfgrthhtvghrnhepieetheduveelhfdvvdejleeuhfelteevhe ffgfeitdefgeekjeefieevgfehhefgnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurh gvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Jun 2021 06:48:06 -0400 (EDT) From: Andrew Jeffery To: openipmi-developer@lists.sourceforge.net, openbmc@lists.ozlabs.org, minyard@acm.org Cc: devicetree@vger.kernel.org, tmaimon77@gmail.com, linux-aspeed@lists.ozlabs.org, avifishman70@gmail.com, venture@google.com, linux-kernel@vger.kernel.org, tali.perry1@gmail.com, robh+dt@kernel.org, chiawei_wang@aspeedtech.com, linux-arm-kernel@lists.infradead.org, benjaminfair@google.com, arnd@arndb.de, zweiss@equinix.com, joel@jms.id.au, KWLIU@nuvoton.com Subject: [PATCH v4 00/16] ipmi: Allow raw access to KCS devices Date: Tue, 8 Jun 2021 20:17:41 +0930 Message-Id: <20210608104757.582199-1-andrew@aj.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_034818_865706_3E0F472B X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, This is the 4th spin of the series refactoring the keyboard-controller-style device drivers in the IPMI subsystem. v3 can be found at: https://lore.kernel.org/lkml/20210510054213.1610760-1-andrew@aj.id.au/ v4: * Makes kcs_bmc_add_device() return an error if no client successfully initialised with respect to the binding of the device driver * Retains the existing single-open semantics (v3 allowed multiple-open) * Fixes the OBE macro for the NPCM7xx KCS driver * Cleans up Yoda-style masks (mask constant on the LHS rather than RHS) * Cleans up includes in kcs_bmc_client.h * Adds some comments to the SerIO adapter to clarify object lifetimes Previously: Changes in v3: * The series was rebased onto v5.13-rc1 * v5.13-rc1 includes Chiawei's patches reworking the LPC devicetree bindings, so they're no-longer required in the series. * After some discussion with Arnd[1] and investigating the serio subsystem, I've replaced the "raw" KCS driver (patch 16/21 in v2) with a serio adaptor (patch 11/16 in this series). The adaptor allows us to take advantage of the existing chardevs provided by serio. [1] https://lore.kernel.org/linux-arm-kernel/37e75b07-a5c6-422f-84b3-54f2bea0b917@www.fastmail.com/ Changes in v2 include: * A rebase onto v5.12-rc2 * Incorporation of off-list feedback on SerIRQ configuration from Chiawei * Further validation on hardware for ASPEED KCS devices 2, 3 and 4 * Lifting the existing single-open constraint of the IPMI chardev * Fixes addressing Rob's feedback on the conversion of the ASPEED KCS binding to dt-schema * Fixes addressing Rob's feedback on the new aspeed,lpc-interrupts property definition for the ASPEED KCS binding Please test and review! Andrew Andrew Jeffery (16): ipmi: kcs_bmc_aspeed: Use of match data to extract KCS properties ipmi: kcs_bmc: Make status update atomic ipmi: kcs_bmc: Rename {read,write}_{status,data}() functions ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi ipmi: kcs_bmc: Turn the driver data-structures inside-out ipmi: kcs_bmc: Split headers into device and client ipmi: kcs_bmc: Strip private client data from struct kcs_bmc ipmi: kcs_bmc: Decouple the IPMI chardev from the core ipmi: kcs_bmc: Allow clients to control KCS IRQ state ipmi: kcs_bmc: Enable IBF on open ipmi: kcs_bmc: Add serio adaptor dt-bindings: ipmi: Convert ASPEED KCS binding to schema dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration ipmi: kcs_bmc_aspeed: Fix IBFIE typo from datasheet ipmi: kcs_bmc_aspeed: Optionally apply status address .../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 106 +++ .../bindings/ipmi/aspeed-kcs-bmc.txt | 33 - drivers/char/ipmi/Kconfig | 27 + drivers/char/ipmi/Makefile | 2 + drivers/char/ipmi/kcs_bmc.c | 523 ++++----------- drivers/char/ipmi/kcs_bmc.h | 92 +-- drivers/char/ipmi/kcs_bmc_aspeed.c | 633 +++++++++++++----- drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 568 ++++++++++++++++ drivers/char/ipmi/kcs_bmc_client.h | 45 ++ drivers/char/ipmi/kcs_bmc_device.h | 22 + drivers/char/ipmi/kcs_bmc_npcm7xx.c | 92 ++- drivers/char/ipmi/kcs_bmc_serio.c | 157 +++++ 12 files changed, 1594 insertions(+), 706 deletions(-) create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml delete mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt create mode 100644 drivers/char/ipmi/kcs_bmc_cdev_ipmi.c create mode 100644 drivers/char/ipmi/kcs_bmc_client.h create mode 100644 drivers/char/ipmi/kcs_bmc_device.h create mode 100644 drivers/char/ipmi/kcs_bmc_serio.c