From patchwork Fri Jul 9 02:17:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 12366467 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7D5C07E96 for ; Fri, 9 Jul 2021 02:20:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9CCD61457 for ; Fri, 9 Jul 2021 02:20:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9CCD61457 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=oU8tJnJktIj9YMTMfShYgWCNgT6ADY8WyKMfx1R0phw=; b=yYNh2Xvzhkz6By icinGpVGjstedOpdbsCmoRj5UzQiO89DSxLe4wusdSBSf/XU3E5WC8Wt0ptpt7cl7Rjg1OLyj/roT Bb3tbWVdZlImN67uHQX5wx9xTMXWHQDT6vPz0sMxHnTuH+z3VyujyFSbszimwzx/hW1K361bUmNJF BsV5WTSffmqkebPSNjnfwlN6jImoe4ZmdlmFN/PSNn7sZ3ZO43VrYe8HL6r1SXniDsX3aE3MthRbt xsztusf/hZvJkDajl/5oq26Wu6kS5xpXgHSrZSa/UYcDkSG/gWSNxSUo8u0NQu0J+WdhGYU8blvXR MSoVARhDN67bR/n/OtFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1g60-000WvL-0V; Fri, 09 Jul 2021 02:18:28 +0000 Received: from [2601:1c0:6280:3f0::aefb] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1g5N-000Wlc-IQ; Fri, 09 Jul 2021 02:17:49 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , "Jason A . Donenfeld" , Russell King , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Greg Kroah-Hartman , Andres Salomon , linux-geode@lists.infradead.org, Matt Mackall , Herbert Xu , linux-crypto@vger.kernel.org, Christian Gromm , Krzysztof Halasa , netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Martin Schiller , linux-x25@vger.kernel.org, wireguard@lists.zx2c4.com Subject: [PATCH 0/6] treewide: rename 'mod_init' & 'mod_exit' functions to be module-specific Date: Thu, 8 Jul 2021 19:17:41 -0700 Message-Id: <20210709021747.32737-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are multiple (16) modules which use a module_init() function with the name 'mod_init' and a module_exit() function with the name 'mod_exit'. This can lead to confusion or ambiguity when reading crashes/oops/bugs etc. and when reading an initcall_debug log. Example 1: (System.map file) ffffffff83446d10 t mod_init ffffffff83446d18 t mod_init ffffffff83446d20 t mod_init ... ffffffff83454665 t mod_init ffffffff834548a4 t mod_init ffffffff83454a53 t mod_init ... ffffffff8345bd42 t mod_init ... ffffffff8345c916 t mod_init ffffffff8345c92a t mod_init ffffffff8345c93e t mod_init ffffffff8345c952 t mod_init ffffffff8345c966 t mod_init ... ffffffff834672c9 t mod_init Example 2: (boot log when using 'initcall_debug') [ 0.252157] initcall mod_init+0x0/0x8 returned 0 after 0 usecs [ 0.252180] initcall mod_init+0x0/0x8 returned 0 after 0 usecs [ 0.252202] initcall mod_init+0x0/0x8 returned 0 after 0 usecs ... [ 0.892907] initcall mod_init+0x0/0x23f returned -19 after 104 usecs [ 0.913788] initcall mod_init+0x0/0x1af returned -19 after 9 usecs [ 0.934353] initcall mod_init+0x0/0x49 returned -19 after 0 usecs ... [ 1.454870] initcall mod_init+0x0/0x66 returned 0 after 72 usecs ... [ 1.455527] initcall mod_init+0x0/0x14 returned 0 after 0 usecs [ 1.455531] initcall mod_init+0x0/0x14 returned 0 after 0 usecs [ 1.455536] initcall mod_init+0x0/0x14 returned 0 after 0 usecs [ 1.455541] initcall mod_init+0x0/0x14 returned 0 after 0 usecs [ 1.455545] initcall mod_init+0x0/0x52 returned 0 after 0 usecs ... [ 1.588162] initcall mod_init+0x0/0xef returned 0 after 45 usecs Cc: Jason A. Donenfeld Cc: Russell King Cc: linux-arm-kernel@lists.infradead.org Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Andres Salomon Cc: linux-geode@lists.infradead.org Cc: Matt Mackall Cc: Herbert Xu Cc: linux-crypto@vger.kernel.org Cc: Christian Gromm Cc: Krzysztof Halasa Cc: netdev@vger.kernel.org Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Martin Schiller Cc: linux-x25@vger.kernel.org Cc: wireguard@lists.zx2c4.com [PATCH 1/6] arm: crypto: rename 'mod_init' & 'mod_exit' functions to be module-specific [PATCH 2/6] hw_random: rename 'mod_init' & 'mod_exit' functions to be module-specific [PATCH 3/6] lib: crypto: rename 'mod_init' & 'mod_exit' functions to be module-specific [PATCH 4/6] MOST: cdev: rename 'mod_init' & 'mod_exit' functions to be module-specific [PATCH 5/6] net: hdlc: rename 'mod_init' & 'mod_exit' functions to be module-specific [PATCH 6/6] net: wireguard: rename 'mod_init' & 'mod_exit' functions to be module-specific arch/arm/crypto/curve25519-glue.c | 8 ++++---- drivers/char/hw_random/amd-rng.c | 8 ++++---- drivers/char/hw_random/geode-rng.c | 8 ++++---- drivers/char/hw_random/intel-rng.c | 8 ++++---- drivers/char/hw_random/via-rng.c | 8 ++++---- drivers/most/most_cdev.c | 8 ++++---- drivers/net/wan/hdlc_cisco.c | 8 ++++---- drivers/net/wan/hdlc_fr.c | 8 ++++---- drivers/net/wan/hdlc_ppp.c | 8 ++++---- drivers/net/wan/hdlc_raw.c | 8 ++++---- drivers/net/wan/hdlc_raw_eth.c | 8 ++++---- drivers/net/wan/hdlc_x25.c | 8 ++++---- drivers/net/wireguard/main.c | 8 ++++---- lib/crypto/blake2s.c | 8 ++++---- lib/crypto/chacha20poly1305.c | 8 ++++---- lib/crypto/curve25519.c | 8 ++++---- 16 files changed, 64 insertions(+), 64 deletions(-)