From patchwork Fri Jul 9 18:45:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12367813 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 959C0C07E99 for ; Fri, 9 Jul 2021 18:47:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 646A6613B7 for ; Fri, 9 Jul 2021 18:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 646A6613B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=AjF565QQycehrptWYHzGz+eN0Vijyz9Sc6uq6eGei/g=; b=acQrg1RsMrjmvm htTG5NiPuiaQoZYvta0/dp7y3fSSqd2LigNwcRfEv3jMa0O5L8i31bgyeZJ//L7qLg3zXg/23JNOI n4F1SkiVT/hSMnhgRHrNgTkwfDTG1tFYewKexCHKRDithxzalGMhUVxVPbHlZEajFbhZiLHgRnPfD W3Ejuzj0qx0mGs/AevTBLDyP4dLpyU2D3J7IZYp0C02mF9rkM+LAU16eszeMN6ucbDLNITYxlDeFK cjD4eG41ugUQ6JHIqQLv+2OCzh8uT3sVJpqPh952FuvqwX6K0MjCUJI6ZB15JBNn4KLyYUU66amLU 7jQ/qs1E1zPgcVrUze5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1vVD-002K4j-GU; Fri, 09 Jul 2021 18:45:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1vV8-002K40-Tz for linux-arm-kernel@lists.infradead.org; Fri, 09 Jul 2021 18:45:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625856323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CkQ/xgleYsDFkubWHrN4e919svBSGwuji89qB5UEP34=; b=F7RNFBahalfSeuGknjbMofWGtMGZbSl9AAhZ0YDjY/j3xJUR9tvrDvQf6uyUHVbTKR9oGk s1Qicnd/EzfaGPxmRZpopCtOZDUkqfO6OPI7L4mzr/oKCjxCHy5DPQ1qJR9jj+lRaSuocx A8M2CaS/4RmlBm9FG1INTH+XJNawL+8= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-TxpzOMc6OIeF-dDtbaR9vA-1; Fri, 09 Jul 2021 14:45:22 -0400 X-MC-Unique: TxpzOMc6OIeF-dDtbaR9vA-1 Received: by mail-oi1-f200.google.com with SMTP id 64-20020aca06430000b0290240ce72dd5eso7253879oig.4 for ; Fri, 09 Jul 2021 11:45:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CkQ/xgleYsDFkubWHrN4e919svBSGwuji89qB5UEP34=; b=TIz05lDX28xtzpWoY7guUI6SO5sp3VlLsyQosjl0lpgXEhpVir0IQu8KPHQAruC/eP rqHKxrw8sneLq0goMumI/3AVTsQOKp42Yn8erRvj98xX34rmTZEmzwEnxCXJG+SxJe2H 04HBwGFkoX7/4mu9pu0FzPoqZ480OxaDWI9du8vU44TTS5i63uCJbCPG2VWiNIX58Wu+ GhWxB61+xfq3lmdpQJHeIq/K5YqAE8oddLNf1VUvjfiAhjWWXva6SYIOPUNwg4o3j6T7 zf6g2I4G19q3eVC8o802oJpqqSXNZ85gc1YSu9HRK0nX2Qcb5qI4h52oigbsYutv20lS En4Q== X-Gm-Message-State: AOAM532h2AUIpXrSMK3xpMHrBIj3aRRPD+B91xqRhIB/bRfogXejsmgS DwH3vIlLU+RMKdUGGB3BLAURwOA/t1GJPfaCy0NdXI2DFw6uK38GfCIWmMvfv+GXUVKbrvfM9Db WIWIS4x64qumEhT+MrIJyeOQFFKGxO11JvXo= X-Received: by 2002:a05:6830:1d94:: with SMTP id y20mr14844068oti.113.1625856321560; Fri, 09 Jul 2021 11:45:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJZpkbwDOTwYT4b0ycbPElhmYn2D/4YdqvPwZhQgKsQLL7Dr7wEwHkiaW8LfQyHIBifZmLVA== X-Received: by 2002:a05:6830:1d94:: with SMTP id y20mr14844049oti.113.1625856321296; Fri, 09 Jul 2021 11:45:21 -0700 (PDT) Received: from localhost.localdomain.com (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id a44sm1145482ooj.12.2021.07.09.11.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 11:45:20 -0700 (PDT) From: trix@redhat.com To: mdf@kernel.org, corbet@lwn.net, hao.wu@intel.com, michal.simek@xilinx.com Cc: linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tom Rix Subject: [RFC PATCH v10 0/3] standard release after compat_id change Date: Fri, 9 Jul 2021 11:45:07 -0700 Message-Id: <20210709184511.2521508-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210709_114527_098423_7CE50045 X-CRM114-Status: UNSURE ( 9.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Tom Rix My objection to 'fpga: Use standard class dev_release function' here https://lore.kernel.org/linux-fpga/20210709004206.244607-1-russell.h.weight@intel.com/ Is that it has 2 register functions for mgr and region. This is caused by compat_id data being stored at the wrong level. By first moving the compat_id data to the implementation level. 'fpga: remove compat_id from fpga_manager and fpga_region' https://lore.kernel.org/linux-fpga/20210709134229.2510349-6-trix@redhat.com/ 2 registers are not needed. This change removes the register_full()'s as well as the info structs. Tested on dfl/n3000 Russ Weight (3): fpga: mgr: Use standard dev_release for class driver fpga: bridge: Use standard dev_release for class driver fpga: region: Use standard dev_release for class driver Documentation/driver-api/fpga/fpga-bridge.rst | 12 +- Documentation/driver-api/fpga/fpga-mgr.rst | 23 ++- Documentation/driver-api/fpga/fpga-region.rst | 4 - drivers/fpga/altera-cvp.c | 12 +- drivers/fpga/altera-fpga2sdram.c | 12 +- drivers/fpga/altera-freeze-bridge.c | 10 +- drivers/fpga/altera-hps2fpga.c | 12 +- drivers/fpga/altera-pr-ip-core.c | 7 +- drivers/fpga/altera-ps-spi.c | 9 +- drivers/fpga/dfl-fme-br.c | 10 +- drivers/fpga/dfl-fme-mgr.c | 10 +- drivers/fpga/dfl-fme-region.c | 7 +- drivers/fpga/dfl.c | 12 +- drivers/fpga/fpga-bridge.c | 122 +++---------- drivers/fpga/fpga-mgr.c | 166 +++++------------- drivers/fpga/fpga-region.c | 108 +++--------- drivers/fpga/ice40-spi.c | 9 +- drivers/fpga/machxo2-spi.c | 9 +- drivers/fpga/of-fpga-region.c | 10 +- drivers/fpga/socfpga-a10.c | 16 +- drivers/fpga/socfpga.c | 9 +- drivers/fpga/stratix10-soc.c | 16 +- drivers/fpga/ts73xx-fpga.c | 9 +- drivers/fpga/xilinx-pr-decoupler.c | 17 +- drivers/fpga/xilinx-spi.c | 11 +- drivers/fpga/zynq-fpga.c | 16 +- drivers/fpga/zynqmp-fpga.c | 9 +- include/linux/fpga/fpga-bridge.h | 30 +++- include/linux/fpga/fpga-mgr.h | 16 +- include/linux/fpga/fpga-region.h | 12 +- 30 files changed, 226 insertions(+), 499 deletions(-)