From patchwork Mon Jul 12 16:26:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Marussi X-Patchwork-Id: 12371505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E7E2C07E99 for ; Mon, 12 Jul 2021 16:29:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3287B601FE for ; Mon, 12 Jul 2021 16:29:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3287B601FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=SOPuNfmeky0mbccLrb+Qpjb+0W3jmByE9C78eLmn0aQ=; b=osFvQfMrYDsSkj Ih6GSQjoeDadw4dQDgzhOTEvoCC3FdAO/KBXUvjihAv7SeBN+XasdnGRpCCVLO3OjmASSjn3mqyc0 eLzTS4YPpguQ59bfq5re8dDGJYCd5lrF1mN3CmPJCncIrizn416HzLNPaV/usIDCXh2VvfCY2uYRJ hFi9J2aYKBm/SFHag7I/4o7HJIPL+PKGVV4DoT3neBZlOZopeB7Zjlpp/0gtwfK77ph6/oGtqMbwI 5RIC/YuMNRcPtdT5ljiLu1syXXClG9PZjBUwg1FupKE8aLFngZenD4uYzBwboSycNzpfKq6TyhAUF Sc6NGttAh88HKnPH5dTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2ym2-007tQG-45; Mon, 12 Jul 2021 16:27:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2yld-007tHH-67 for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 16:26:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93DA91FB; Mon, 12 Jul 2021 09:26:46 -0700 (PDT) Received: from e120937-lin.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CD90B3F774; Mon, 12 Jul 2021 09:26:44 -0700 (PDT) From: Cristian Marussi To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com Subject: [PATCH v3 0/8] Introduce atomic support for SCMI transports Date: Mon, 12 Jul 2021 17:26:17 +0100 Message-Id: <20210712162626.34705-1-cristian.marussi@arm.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_092649_416013_228837AC X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, This series mainly aims to introduce atomic support for transports that can support it. At first in [1/8], as a closely related addition, it is introduced a common way for a transport to signal to the SCMI core that it does not offer completion interrupts, so that the usual polling behaviour based on .poll_done() will be required: this can be done enabling statically a global polling behaviour for the whole transport with flag scmi_desc.force_polling OR dynamically enabling at runtime such polling behaviour on a per-channel basis with scmi_chan_info.needs_polling, typically during .chan_setup(). The usual per-command polling selection behaviour based on hdr.poll_completion is preserved as before. Then in [2/8], a transport that supports atomic operations on its TX path can now declare itself as .atomic_capable and as a consequence the SCMI core will refrain itself from sleeping on the correspondent RX-path. In [5/8] a simple method is introduced so that an SCMI driver can easily query the core to check if the currently used transport is configured to behave in an atomic manner: in this way, interested SCMI driver users, like Clock framework [6/8], can optionally support atomic operations when operating on an atomically configured transport. Finally there are 2 *tentative" RFC patch for SMC transport: at first [7/8] ports SMC to use the common core completions when completion interrupt is available or otherwise revert to use common core polling mechanism above introduced; then in [8/8] SMC is converted to be .atomic_capable by substituting the mutexes with busy-waiting to keep the channel 'locked'. SMC changes have NOT been tested so far (I cannot), AND they are just a proposal at this stage to try to better abstract and unify behaviour with the SCMI core; both patches are completely intended as RFCs, though, not only regarding their implementation but even their mere existence is RFC: I mean maybe we just don't want to do such kind of unification/abstraction, and I can just drop those SMC patches if unwanted; any feedback welcome. Atomic support has been minimally tested against the upcoming virtio transport V6 series, while polling has been tested with mailbox transports. The series is based on SCMI VirtIO Transport support V6 [1] (since it will be the main prospective user of atomic mode) and, as such, it is also publicly available on top of SCMI VirtIO V6 from ARM GitLab [2]. (Note that in order to use/test atomic mode on virtio you'll have to enable it setting .atomic_capable = true in virtio.c::scmi_virtio_desc) Given I'm still gathering feedback on this, I still not have CCed any maintainer out of SCMI subsystem. Any feedback welcome. Thanks, Cristian --- [1]:https://lore.kernel.org/linux-arm-kernel/20210712141833.6628-1-cristian.marussi@arm.com/ [2]:https://gitlab.arm.com/linux-arm/linux-cm/-/commits/scmi_atomic_transport_V3_on_virtio_V6 V2 --> v3 - rebased on SCMI VirtIO V6 which in turn is based on v5.14-rc1 Cristian Marussi (8): firmware: arm_scmi: Add configurable polling mode for transports firmware: arm_scmi: Add support for atomic transports include: trace: Add new scmi_xfer_response_wait event firmware: arm_scmi: Use new trace event scmi_xfer_response_wait firmware: arm_scmi: Add is_transport_atomic() handle method clk: scmi: Support atomic enable/disable API [RFC] firmware: arm_scmi: Make smc transport use common completions [RFC] firmware: arm_scmi: Make smc transport atomic drivers/clk/clk-scmi.c | 44 ++++-- drivers/firmware/arm_scmi/common.h | 13 ++ drivers/firmware/arm_scmi/driver.c | 223 ++++++++++++++++++++++------- drivers/firmware/arm_scmi/smc.c | 61 +++++--- include/linux/scmi_protocol.h | 8 ++ include/trace/events/scmi.h | 28 ++++ 6 files changed, 297 insertions(+), 80 deletions(-)