mbox series

[0/7] dmaengine: zynqmp_dma: fix lockdep warning and cleanup

Message ID 20210826094742.1302009-1-m.tretter@pengutronix.de (mailing list archive)
Headers show
Series dmaengine: zynqmp_dma: fix lockdep warning and cleanup | expand

Message

Michael Tretter Aug. 26, 2021, 9:47 a.m. UTC 
Hi,

I reported a lockdep warning in the ZynqMP DMA driver a few weeks ago [0].
This series fixes the reported warning and performs some cleanup that I found
while looking at the driver more closely.

Patches 1-4 are the cleanups. They affect the log output of the driver, allow
to compile the driver on other platforms when COMPILE_TEST is enabled, and
remove unused included header files from the driver.

Patches 5-7 aim to fix the lockdep warning. Patch 5 and 6 restructure the
locking in the driver to make it more fine-grained instead of holding the lock
for the entire tasklet. Patch 7 finally fixes the warning.

Michael

[0] https://lore.kernel.org/linux-arm-kernel/20210601130108.GA12967@pengutronix.de/

Michael Tretter (7):
  dmaengine: zynqmp_dma: simplify with dev_err_probe
  dmaengine: zynqmp_dma: drop message on probe success
  dmaengine: zynqmp_dma: enable COMPILE_TEST
  dmaengine: zynqmp_dma: cleanup includes
  dmaengine: zynqmp_dma: cleanup after completing all descriptors
  dmaengine: zynqmp_dma: refine dma descriptor locking
  dmaengine: zynqmp_dma: fix lockdep warning in tasklet

 drivers/dma/Kconfig             |  2 +-
 drivers/dma/xilinx/zynqmp_dma.c | 67 +++++++++++++++++----------------
 2 files changed, 35 insertions(+), 34 deletions(-)

Comments

Michael Tretter Oct. 1, 2021, 8:56 a.m. UTC | #1 
On Thu, 26 Aug 2021 11:47:35 +0200, Michael Tretter wrote:
> I reported a lockdep warning in the ZynqMP DMA driver a few weeks ago [0].
> This series fixes the reported warning and performs some cleanup that I found
> while looking at the driver more closely.
> 
> Patches 1-4 are the cleanups. They affect the log output of the driver, allow
> to compile the driver on other platforms when COMPILE_TEST is enabled, and
> remove unused included header files from the driver.
> 
> Patches 5-7 aim to fix the lockdep warning. Patch 5 and 6 restructure the
> locking in the driver to make it more fine-grained instead of holding the lock
> for the entire tasklet. Patch 7 finally fixes the warning.

Gentle ping.

Michael

> 
> Michael
> 
> [0] https://lore.kernel.org/linux-arm-kernel/20210601130108.GA12967@pengutronix.de/
> 
> Michael Tretter (7):
>   dmaengine: zynqmp_dma: simplify with dev_err_probe
>   dmaengine: zynqmp_dma: drop message on probe success
>   dmaengine: zynqmp_dma: enable COMPILE_TEST
>   dmaengine: zynqmp_dma: cleanup includes
>   dmaengine: zynqmp_dma: cleanup after completing all descriptors
>   dmaengine: zynqmp_dma: refine dma descriptor locking
>   dmaengine: zynqmp_dma: fix lockdep warning in tasklet
> 
>  drivers/dma/Kconfig             |  2 +-
>  drivers/dma/xilinx/zynqmp_dma.c | 67 +++++++++++++++++----------------
>  2 files changed, 35 insertions(+), 34 deletions(-)
> 
> -- 
> 2.30.2
> 
>
Vinod Koul Oct. 1, 2021, 11:56 a.m. UTC | #2 
On 26-08-21, 11:47, Michael Tretter wrote:
> Hi,
> 
> I reported a lockdep warning in the ZynqMP DMA driver a few weeks ago [0].
> This series fixes the reported warning and performs some cleanup that I found
> while looking at the driver more closely.
> 
> Patches 1-4 are the cleanups. They affect the log output of the driver, allow
> to compile the driver on other platforms when COMPILE_TEST is enabled, and
> remove unused included header files from the driver.
> 
> Patches 5-7 aim to fix the lockdep warning. Patch 5 and 6 restructure the
> locking in the driver to make it more fine-grained instead of holding the lock
> for the entire tasklet. Patch 7 finally fixes the warning.

Applied, thanks