From patchwork Thu Aug 26 09:47:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tretter X-Patchwork-Id: 12459363 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE1DC432BE for ; Thu, 26 Aug 2021 09:51:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D60661026 for ; Thu, 26 Aug 2021 09:51:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D60661026 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=OsDwlPAyNmTjRWTxsyaOeb48L/KHHLneh+93htRuxPE=; b=jumBpAIbwCIOWs hdaD8nicgn2lUvstGbyVDwddUm5g3U7wg44ItCO62xGm9y16DkgPhxGs5hZAHzGIMXmr02dab1k5y i+1iE4JqFAGIoWzRzS0p65ctqqa5qxWmDb5Rk2t/ccXO2KffoXxz27/wTXeONDwCMp1DYCfSQDWLp uXKjOZjnAkIGIHxbGDyeNT074d+doUoz0gQCWUBdmyhOas/mX6jFvD7I2JAY6UZC9QQA7DfuqFS4j 6FqI73FTrFgOspQsTRy0OCFktGQiNaGtuWTy6yKXGZf8vzd+QH925X5dmTbY//mufGQfrDGN/AcR6 3dgYBQSjdOkfjXk1klFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJC0a-009iaW-Fe; Thu, 26 Aug 2021 09:49:16 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJBzA-009i15-0U for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 09:47:52 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJBz5-0003c2-19; Thu, 26 Aug 2021 11:47:43 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mJBz4-0006kq-8D; Thu, 26 Aug 2021 11:47:42 +0200 Received: from mtr by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mJBz4-005Siu-7G; Thu, 26 Aug 2021 11:47:42 +0200 From: Michael Tretter To: vkoul@kernel.org, dmaengine@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, appana.durga.rao@xilinx.com, michal.simek@xilinx.com, m.tretter@pengutronix.de, kernel@pengutronix.de Subject: [PATCH 0/7] dmaengine: zynqmp_dma: fix lockdep warning and cleanup Date: Thu, 26 Aug 2021 11:47:35 +0200 Message-Id: <20210826094742.1302009-1-m.tretter@pengutronix.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_024748_240168_03CCEABD X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, I reported a lockdep warning in the ZynqMP DMA driver a few weeks ago [0]. This series fixes the reported warning and performs some cleanup that I found while looking at the driver more closely. Patches 1-4 are the cleanups. They affect the log output of the driver, allow to compile the driver on other platforms when COMPILE_TEST is enabled, and remove unused included header files from the driver. Patches 5-7 aim to fix the lockdep warning. Patch 5 and 6 restructure the locking in the driver to make it more fine-grained instead of holding the lock for the entire tasklet. Patch 7 finally fixes the warning. Michael [0] https://lore.kernel.org/linux-arm-kernel/20210601130108.GA12967@pengutronix.de/ Michael Tretter (7): dmaengine: zynqmp_dma: simplify with dev_err_probe dmaengine: zynqmp_dma: drop message on probe success dmaengine: zynqmp_dma: enable COMPILE_TEST dmaengine: zynqmp_dma: cleanup includes dmaengine: zynqmp_dma: cleanup after completing all descriptors dmaengine: zynqmp_dma: refine dma descriptor locking dmaengine: zynqmp_dma: fix lockdep warning in tasklet drivers/dma/Kconfig | 2 +- drivers/dma/xilinx/zynqmp_dma.c | 67 +++++++++++++++++---------------- 2 files changed, 35 insertions(+), 34 deletions(-)