From patchwork Tue Sep 7 14:54:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Peter X-Patchwork-Id: 12478887 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 715B0C433F5 for ; Tue, 7 Sep 2021 14:57:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B522600CD for ; Tue, 7 Sep 2021 14:57:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3B522600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=svenpeter.dev Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=smvrKxP9Z5UNInCG/o9w9TdS6M0WLmgdNcHTbWfgzAI=; b=qJjBCW8ztqbGDa GxFKNwza/VFC8WxfbIajGG0E0EWjca9tt8hazyCp1YSX7NnKp2nw7oc0Sm4D5bAQRpfoXaLec/2RP lyAOURXdQY+EdgO/QPtGu6pOrPauuB9qM446dKgOgn6KsnG+zEuLV90flCZpgA7rL86pY3uUnfUcK 2P3eAouJgO2WLlg61Psv2w8J3RBIHT3lN6Elpe1I8RL5N8M99wrYwZyKkzl6LgU75W5dQkTsu2RCk u+rvBJu7SUVMOXnp408N+s5HgRpaTSo0FnMMvDO/HXQ3jcvSFowcuZ5c8Oy+Cwt8nLXv6xP5xF72H q8lYTaZKvkicCd9TDllA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNcVh-003vnh-KJ; Tue, 07 Sep 2021 14:55:41 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNcVT-003vkD-Cn for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 14:55:28 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id D65D3580E7F; Tue, 7 Sep 2021 10:55:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 07 Sep 2021 10:55:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=tr3rAne2mxvJdDMSmiNoM/kTe5 3cOj7AacnE9RSwub8=; b=NPisbDDCJyXec9+Izt2ILl+GYv6oGQHVoQotbxN2In LWjrapdigidirvIzigOfPkh1VxpqCSWHsT87JGaYQNrMHw7EF0aIKwEkXOkdRcuA DTGHUW7kdSSXmsjl6W2AAmH8wcJr1KmUV//6d+t4VMVcYpy+QPwczMGvh8e25UkK +OLHZB1Wm6IqP61FRKXuosk7DKjVylNJzcrfgql1ek7H/iVKLHHxfnx3iLAjEIen opqizuIF8cjBJ7tM+5LhpWfdBkFSyCOsrIpsRm69vZI3wXvZAGZVI/YE610zLNhT 4/CPFzd/nSIYPNXgafMgH9ang8dqBGSWJZ+BQjcubLSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=tr3rAne2mxvJdDMSm iNoM/kTe53cOj7AacnE9RSwub8=; b=AI796OQoTbjMCduu4/84/NMmjtBQStayZ Ex8jcBwhAf8nsjQywECUodWsynTtc+5DFvLOs/Tif3ExMGgr+LIgaRtWxs9lr+pb vsApvy1n50pPFHiR3gWeEsM9UiMoit3ONH6GXicUEXQmLJrv2xw0JMXcPPc8upCa 9bTO5RXsUcDnDT2V9znBhmeYM12LSxlheGVVJamdW4Y+zyTeNw2fTGL2CawcVYkk vZ8y1wRQBzqCEkeXWUJudp/fxAdnpI2289Lf0dPUYf12fi0NbC28RZtLc+EADDCZ Ky3DEykVfT3RVQ04MQC1z/U8cEbpmRitkLrx7OIpV0p+AcAmQAVAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefhedgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuvhgvnhcurfgv thgvrhcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrfgrthhtvghrnh epuefgleekvddtjefffeejheevleefveekgfduudfhgefhfeegtdehveejfefffffgnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhvvghnse hsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Sep 2021 10:55:17 -0400 (EDT) From: Sven Peter To: Jassi Brar Cc: Sven Peter , Rob Herring , Mark Kettenis , Hector Martin , Alyssa Rosenzweig , Mohamed Mediouni , Stan Skowronek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] Apple Mailbox Controller support Date: Tue, 7 Sep 2021 16:54:58 +0200 Message-Id: <20210907145501.69161-1-sven@svenpeter.dev> X-Mailer: git-send-email 2.30.1 (Apple Git-130) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_075527_563119_FED0FBDA X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, This series adds support for the mailbox HW found in the Apple M1. These SoCs have various co-processors controlling different peripherals (NVMe, display controller, SMC (required for WiFi), Thunderbolt, and probably more we don't know about yet). All these co-processors communicate with the main CPU using these mailboxes. These mailboxes transmit 64+32 bit messages, are backed by a hardware FIFO and have four interrupts (FIFO empty and FIFO not empty for the transmit and receive FIFO each). The hardware itself allows to send 64+32 bit message using two hardware registers. A write to or read from the second register transmits or receives a message. Usually, the first 64 bit register is used for the message itself and 8 bits of the second register are used as an endpoint. I originally considered to have the endpoint exposed as a mailbox-channel, but finally decided against it: The hardware itself only provides a single channel to the co-processor and the endpoint bits are only an implementation detail of the firmware. There's even one co-processor (SEP) which uses 8 bits of the first register as its endpoint number instead. There was a similar discussion about the BCM2835 / Raspberry Pi mailboxes which came to the same conclusion [1]. These mailboxes also have a hardware FIFO which make implementing them with the current mailbox a bit tricky: There is no "transmission done" interrupt because most transmissions are "done" immediately. There is only a "transmission fifo empty" level interrupt. I have instead implemented this by adding a fast-path to the core mailbox code as a new txready_fifo mode. The other possibilities (which would not require any changes to the core mailbox code) are to either use the polling mode or to enable the "tx fifo empty" interrupt in send_message and then call txready from the irq handler before disabling it again. I'd like to avoid those though since so far I've never seen the TX FIFO run full which allows to almost always avoid the context switch when sending a message. I can easily switch to one of these modes if you prefer to keep the core code untouched though. Best, Sven Sven Peter (3): mailbox: Add txdone_fifo dt-bindings: mailbox: Add Apple mailbox bindings mailbox: apple: Add driver for Apple mailboxes .../bindings/mailbox/apple,mailbox.yaml | 81 ++++ MAINTAINERS | 3 + drivers/mailbox/Kconfig | 12 + drivers/mailbox/Makefile | 2 + drivers/mailbox/apple-mailbox.c | 432 ++++++++++++++++++ drivers/mailbox/mailbox.c | 66 ++- drivers/mailbox/mailbox.h | 1 + include/linux/apple-mailbox.h | 18 + include/linux/mailbox_controller.h | 15 + 9 files changed, 621 insertions(+), 9 deletions(-) create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml create mode 100644 drivers/mailbox/apple-mailbox.c create mode 100644 include/linux/apple-mailbox.h