| Message ID | 20210916154911.3168-1-sven@svenpeter.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | Apple Mailbox Controller support | expand |
I've dropped v1 from my tree and cherry-picked "mailbox: apple: Add driver for Apple mailboxes". NVMe and DCP both still work, so this is Tested-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Thanks! On Thu , Sep 16, 2021 at 05:49:09PM +0200, Sven Peter wrote: > Hi, > > This is the second version of my series which adds support for the mailbox > controllers found on the Apple M1. > > v1: https://lore.kernel.org/lkml/20210907145501.69161-1-sven@svenpeter.dev/ > > Thanks to Jassi, Mark and Alyssa for the initial review. I've addressed > your comments with the following changes: > > - switched to txdone_irq instead of introducing a new mode > - switched to a threaded interrupt handler for receiving messages > - added co-processor examples to the device tree binding > - reformatted the register defines and clarified multiple comments > > Best, > > Sven > > Sven Peter (2): > dt-bindings: mailbox: Add Apple mailbox bindings > mailbox: apple: Add driver for Apple mailboxes > > .../bindings/mailbox/apple,mailbox.yaml | 84 ++++ > MAINTAINERS | 3 + > drivers/mailbox/Kconfig | 12 + > drivers/mailbox/Makefile | 2 + > drivers/mailbox/apple-mailbox.c | 431 ++++++++++++++++++ > include/linux/apple-mailbox.h | 18 + > 6 files changed, 550 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml > create mode 100644 drivers/mailbox/apple-mailbox.c > create mode 100644 include/linux/apple-mailbox.h > > -- > 2.25.1 >
On Thu, Sep 16, 2021, at 17:49, Sven Peter wrote: > Hi, > > This is the second version of my series which adds support for the mailbox > controllers found on the Apple M1. > > v1: https://lore.kernel.org/lkml/20210907145501.69161-1-sven@svenpeter.dev/ > > Thanks to Jassi, Mark and Alyssa for the initial review. I've addressed > your comments with the following changes: > > - switched to txdone_irq instead of introducing a new mode > - switched to a threaded interrupt handler for receiving messages > - added co-processor examples to the device tree binding > - reformatted the register defines and clarified multiple comments > > Best, > > Sven > > Sven Peter (2): > dt-bindings: mailbox: Add Apple mailbox bindings > mailbox: apple: Add driver for Apple mailboxes > > .../bindings/mailbox/apple,mailbox.yaml | 84 ++++ > MAINTAINERS | 3 + > drivers/mailbox/Kconfig | 12 + > drivers/mailbox/Makefile | 2 + > drivers/mailbox/apple-mailbox.c | 431 ++++++++++++++++++ > include/linux/apple-mailbox.h | 18 + > 6 files changed, 550 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml > create mode 100644 drivers/mailbox/apple-mailbox.c > create mode 100644 include/linux/apple-mailbox.h > > -- > 2.25.1 Hi Jassi, Have you had a chance to look at this series yet? Thanks, Sven