mbox series

[v2,net,0/5] Make DSA switch drivers compatible with masters which unregister on shutdown

Message ID 20210917133436.553995-1-vladimir.oltean@nxp.com (mailing list archive)
Headers show
Series Make DSA switch drivers compatible with masters which unregister on shutdown | expand

Message

Vladimir Oltean Sept. 17, 2021, 1:34 p.m. UTC 
Changes in v2:
- fix build for b53_mmap
- use unregister_netdevice_many

It was reported by Lino here:

https://lore.kernel.org/netdev/20210909095324.12978-1-LinoSanfilippo@gmx.de/

that when the DSA master attempts to unregister its net_device on
shutdown, DSA should prevent that operation from succeeding because it
holds a reference to it. This hangs the shutdown process.

This issue was essentially introduced in commit 2f1e8ea726e9 ("net: dsa:
link interfaces with the DSA master to get rid of lockdep warnings").
The present series patches all DSA drivers to handle that case,
depending on whether those drivers were introduced before or after the
offending commit, a different Fixes: tag is specified for them.

The approach taken by this series solves the issue in essentially the
same way as Lino's patches, except for three key differences:

- this series takes a more minimal approach in what is done on shutdown,
  we do not attempt a full tree teardown as that is not strictly
  necessary. I might revisit this if there are compelling reasons to do
  otherwise

- this series fixes the issues for all DSA drivers, not just KSZ9897

- this series works even if the ->remove driver method gets called for
  the same device too, not just ->shutdown. This is really possible to
  happen for SPI device drivers, and potentially possible for other bus
  device drivers too.

Vladimir Oltean (5):
  net: mdio: introduce a shutdown method to mdio device drivers
  net: dsa: be compatible with masters which unregister on shutdown
  net: dsa: hellcreek: be compatible with masters which unregister on
    shutdown
  net: dsa: microchip: ksz8863: be compatible with masters which
    unregister on shutdown
  net: dsa: xrs700x: be compatible with masters which unregister on
    shutdown

 drivers/net/dsa/b53/b53_mdio.c             | 21 ++++++++-
 drivers/net/dsa/b53/b53_mmap.c             | 13 ++++++
 drivers/net/dsa/b53/b53_priv.h             |  5 +++
 drivers/net/dsa/b53/b53_spi.c              | 13 ++++++
 drivers/net/dsa/b53/b53_srab.c             | 21 ++++++++-
 drivers/net/dsa/bcm_sf2.c                  | 12 ++++++
 drivers/net/dsa/dsa_loop.c                 | 22 +++++++++-
 drivers/net/dsa/hirschmann/hellcreek.c     | 16 +++++++
 drivers/net/dsa/lan9303-core.c             |  6 +++
 drivers/net/dsa/lan9303.h                  |  1 +
 drivers/net/dsa/lan9303_i2c.c              | 24 +++++++++--
 drivers/net/dsa/lan9303_mdio.c             | 15 +++++++
 drivers/net/dsa/lantiq_gswip.c             | 18 ++++++++
 drivers/net/dsa/microchip/ksz8795_spi.c    | 11 ++++-
 drivers/net/dsa/microchip/ksz8863_smi.c    | 13 ++++++
 drivers/net/dsa/microchip/ksz9477_i2c.c    | 14 +++++-
 drivers/net/dsa/microchip/ksz9477_spi.c    |  8 +++-
 drivers/net/dsa/mt7530.c                   | 18 ++++++++
 drivers/net/dsa/mv88e6060.c                | 18 ++++++++
 drivers/net/dsa/mv88e6xxx/chip.c           | 22 +++++++++-
 drivers/net/dsa/ocelot/felix_vsc9959.c     | 20 ++++++++-
 drivers/net/dsa/ocelot/seville_vsc9953.c   | 20 ++++++++-
 drivers/net/dsa/qca/ar9331.c               | 18 ++++++++
 drivers/net/dsa/qca8k.c                    | 18 ++++++++
 drivers/net/dsa/realtek-smi-core.c         | 20 ++++++++-
 drivers/net/dsa/sja1105/sja1105_main.c     | 21 ++++++++-
 drivers/net/dsa/vitesse-vsc73xx-core.c     |  6 +++
 drivers/net/dsa/vitesse-vsc73xx-platform.c | 22 +++++++++-
 drivers/net/dsa/vitesse-vsc73xx-spi.c      | 22 +++++++++-
 drivers/net/dsa/vitesse-vsc73xx.h          |  1 +
 drivers/net/dsa/xrs700x/xrs700x.c          |  6 +++
 drivers/net/dsa/xrs700x/xrs700x.h          |  1 +
 drivers/net/dsa/xrs700x/xrs700x_i2c.c      | 18 ++++++++
 drivers/net/dsa/xrs700x/xrs700x_mdio.c     | 18 ++++++++
 drivers/net/phy/mdio_device.c              | 11 +++++
 include/linux/mdio.h                       |  3 ++
 include/net/dsa.h                          |  1 +
 net/dsa/dsa2.c                             | 50 ++++++++++++++++++++++
 38 files changed, 543 insertions(+), 24 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 19, 2021, 11:20 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Fri, 17 Sep 2021 16:34:31 +0300 you wrote:
> Changes in v2:
> - fix build for b53_mmap
> - use unregister_netdevice_many
> 
> It was reported by Lino here:
> 
> https://lore.kernel.org/netdev/20210909095324.12978-1-LinoSanfilippo@gmx.de/
> 
> [...]

Here is the summary with links:
  - [v2,net,1/5] net: mdio: introduce a shutdown method to mdio device drivers
    https://git.kernel.org/netdev/net/c/cf9579976f72
  - [v2,net,2/5] net: dsa: be compatible with masters which unregister on shutdown
    https://git.kernel.org/netdev/net/c/0650bf52b31f
  - [v2,net,3/5] net: dsa: hellcreek: be compatible with masters which unregister on shutdown
    https://git.kernel.org/netdev/net/c/46baae56e100
  - [v2,net,4/5] net: dsa: microchip: ksz8863: be compatible with masters which unregister on shutdown
    https://git.kernel.org/netdev/net/c/fe4053078cd0
  - [v2,net,5/5] net: dsa: xrs700x: be compatible with masters which unregister on shutdown
    https://git.kernel.org/netdev/net/c/a68e9da48568

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html