| Message ID | 20211009022023.3796472-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Modular Broadcom irqchip drivers | expand |
On 10/8/21 7:20 PM, Florian Fainelli wrote: > Hi Thomas, Marc, > > This patch series aims at allowing the 3 interrupt controller drivers > used on Broadcom STB platforms to be built as modules in order for those > to be shipped in a GKI enabled system (Android). > > The irq-bcm7038-l1 requires us to export a number of symbols, which is > not great, but there are not obvious solutions other than adding > accessor functions to get the same information. > > Assuming you are happy with the changes though, please do take the last > two changes as well through your tree. > > Thanks! Does this look reasonable to you? If so, can you apply all of those patches through the irqchip tree? Thanks!
On Tue, 19 Oct 2021 20:13:08 +0100, Florian Fainelli <f.fainelli@gmail.com> wrote: > > On 10/8/21 7:20 PM, Florian Fainelli wrote: > > Hi Thomas, Marc, > > > > This patch series aims at allowing the 3 interrupt controller drivers > > used on Broadcom STB platforms to be built as modules in order for those > > to be shipped in a GKI enabled system (Android). > > > > The irq-bcm7038-l1 requires us to export a number of symbols, which is > > not great, but there are not obvious solutions other than adding > > accessor functions to get the same information. > > > > Assuming you are happy with the changes though, please do take the last > > two changes as well through your tree. > > > > Thanks! > > Does this look reasonable to you? If so, can you apply all of those > patches through the irqchip tree? Thanks! Great timing! See my reply to patch #9. Please respin this to fix the glaring issue I mentioned there. M.
Hi Thomas, Marc, This patch series aims at allowing the 3 interrupt controller drivers used on Broadcom STB platforms to be built as modules in order for those to be shipped in a GKI enabled system (Android). The irq-bcm7038-l1 requires us to export a number of symbols, which is not great, but there are not obvious solutions other than adding accessor functions to get the same information. Assuming you are happy with the changes though, please do take the last two changes as well through your tree. Thanks! Changes in v4: - added Thomas' Acked-by for patch #1 - added Rob's Reviewed-by for patch 9 and updated qcom-pdc.c as suggested - s/argument/parameter/ in patch #14 as suggested by Sergey Changes in v3: - avoid the use of the cpu_logical_map array for platforms other than MIPS - removed the bogus irq_set_affinity callback for platforms other than MIPS - bring-back the export of irq_gc_noop() lost in the v2 Changes in v2: - avoid using irq_to_desc() and use irq_get_irq_data() instead - re-order patches to avoid linking failure for irq-brcmstb-l2 - removed the use of .irq_cpu_offline() and converted BMIPS to use irq_migrate_all_off_this_cpu() - avoid exporting of_irq_count() and use a platform device passed down from the irqchip platform driver registration code instead - added kernel-doc fix Florian Fainelli (14): MIPS: BMIPS: Remove use of irq_cpu_offline irqchip/irq-bcm7038-l1: Remove .irq_cpu_offline() irqchip/irq-bcm7038-l1: Use irq_get_irq_data() irqchip/irq-bcm7038-l1: Gate use of CPU logical map to MIPS irqchip/irq-bcm7038-l1: Restrict affinity setting to MIPS irqchip/irq-bcm7038-l1: Switch to IRQCHIP_PLATFORM_DRIVER genirq: Export irq_gc_{unmask_enable,mask_disable}_reg irqchip/irq-brcmstb-l2: Switch to IRQCHIP_PLATFORM_DRIVER irqchip: Provide platform_device to of_irq_init_cb_t genirq: Export irq_gc_noop() irqchip/irq-bcm7120-l2: Switch to IRQCHIP_PLATFORM_DRIVER arm64: broadcom: Removed forced select of interrupt controllers ARM: bcm: Removed forced select of interrupt controllers irqchip: Fix kernel-doc parameter typo for IRQCHIP_DECLARE arch/arm/mach-bcm/Kconfig | 4 --- arch/arm64/Kconfig.platforms | 3 -- arch/mips/Kconfig | 1 + arch/mips/kernel/smp-bmips.c | 3 +- drivers/irqchip/Kconfig | 12 ++++++-- drivers/irqchip/irq-bcm7038-l1.c | 47 ++++++++------------------------ drivers/irqchip/irq-bcm7120-l2.c | 28 +++++++++++-------- drivers/irqchip/irq-brcmstb-l2.c | 16 ++++++----- drivers/irqchip/irqchip.c | 2 +- drivers/irqchip/qcom-pdc.c | 3 +- drivers/of/irq.c | 2 +- include/linux/irqchip.h | 2 +- include/linux/of_irq.h | 5 +++- kernel/irq/generic-chip.c | 3 ++ 14 files changed, 60 insertions(+), 71 deletions(-)