From patchwork Tue Nov 2 00:21:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghavendra Rao Ananta X-Patchwork-Id: 12597639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800E0C433FE for ; Tue, 2 Nov 2021 00:23:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D12F60EDF for ; Tue, 2 Nov 2021 00:23:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D12F60EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Mime-Version: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=9PWWZ17be6wnmDq703hBsl6o/o1j1ncjs5t4/DubKeA=; b=1nP tz4gU6cPxe8q+nkEHjfHJZQ1BpGbQjdDZREegUkLsA19Ut170hIqvLQ2pyxEBnFCVkS+1kGNl7mYv kvZ500/Kg7g+tfd/JORRmiGdrHJnZnNeIilnpkjHL/UVFnzpc69P7Q9CIBwUiOWaHJTICnq5aV+iK /3tLn+PqGT4+j4CFVhYv/6rD9J7bYxGbQ0oUVf851q81AyS5wwxMRyidXTYeOONo8tTGlgUyuCiiT RL/mYVb+TZ2kLMEBqwkw9m++bDcNDvQWMv790XB8m3yW4kIEaboTw2ZFml+WevOho/q3EAhO24BpM j7ow4rZ0EnjTcEBAzDbqXiYqAAVCcAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhhZJ-0004qO-JN; Tue, 02 Nov 2021 00:22:25 +0000 Received: from mail-pg1-x54a.google.com ([2607:f8b0:4864:20::54a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhhZF-0004pK-DS for linux-arm-kernel@lists.infradead.org; Tue, 02 Nov 2021 00:22:23 +0000 Received: by mail-pg1-x54a.google.com with SMTP id g26-20020a63521a000000b0029524f04f5aso10254588pgb.5 for ; Mon, 01 Nov 2021 17:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=0q1tLc0oeztZBZsXvvPTzof7ayB7Bik3/teaxGikVwA=; b=M9RyMn9NtpqtxZRq6dzqh0AmQGmFRmQFCx0PnDS2BS3EfbwgzHnzMPoUT2VW2baznj s/4fI0vdhHNI76oo0fmgPbIBhoai9JINiRpWpJUOG2dlyqm6CqqJR5kWP5ZUv+dsnVIV V6vOssewxpAsmnUIyrtJ1cuEd+jTbQVSJf+572afB4Bhyl/o6D41fSZK1n/iV2T7a/f7 YlsTaWYn0UvkbjeKDIifzJna5+4mnIo+8UdBYC6+VQyTnS+Y0lkbYcoXGQVMjW4r7Cqj OV+FXdbxhJC+XuK8NFkZPJ+UG5ZcHG5ePMrx+yZEseXk7KjEywWzFJvgXxvVq5zrPO2P Wp/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=0q1tLc0oeztZBZsXvvPTzof7ayB7Bik3/teaxGikVwA=; b=0h6IyfeJ+zOXu1uKB3nwjAsiuJLbEtoCRCVNVU0xOmHHlj4OOED3SH9MiOE7xWFFvb e0f0eiindK1Ow2aWzjfIWUyQLQz8wFa+E2FiItQxOqSzh6PZqtgYgmvyvFFUZj6+XGoL +6ld9X1fIfrjI/E6wKv+C6tbtJ2EMwxYzsgJ7e0C4nD8PedjzvM+TX228v9U0fNimj4F bhravW350HFQZeO5R6o8gtnI8I4fmGXsBcdsdNAjhhg9Gar5fmpqbUNTvLsjNXYFM2wh GgQehbtUGD80sJhT4KZTpvc6btrfw8pmwicviGsYxgfoL8lYtM74rOdD37WVENUW9Vex 2oRw== X-Gm-Message-State: AOAM532sKUIcoqu3EPIyecoamsJqNC4t/U/6wDvBxEJg9KbmYnU8fkv/ W6BvweEiIoHc6zR5nR97LK9ASS0Sti9Q X-Google-Smtp-Source: ABdhPJxNMFUzGq4vVDxdHLg1Zowo37UyC15esk5w81Yj2K1hViKi29lRAuknRKEVUhuJwiI85y6JmFLNHLAH X-Received: from rananta-virt.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1bcc]) (user=rananta job=sendgmr) by 2002:a17:902:6bc8:b0:13f:8a54:1188 with SMTP id m8-20020a1709026bc800b0013f8a541188mr27979352plt.49.1635812539339; Mon, 01 Nov 2021 17:22:19 -0700 (PDT) Date: Tue, 2 Nov 2021 00:21:55 +0000 Message-Id: <20211102002203.1046069-1-rananta@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.33.1.1089.g2158813163f-goog Subject: [RFC PATCH 0/8] KVM: arm64: Add support for hypercall services selection From: Raghavendra Rao Ananta To: Marc Zyngier , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose Cc: Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Reiji Watanabe , Jing Zhang , Raghavendra Rao Anata , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_172221_503265_EC14A04E X-CRM114-Status: GOOD ( 22.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, Continuing the discussion from [1], the series tries to add support for the user-space to elect the hypercall services that it wishes to expose to the guest, rather than the guest discovering them unconditionally. The idea employed by the series was taken from [1] as suggested by Marc Z. In a broad sense, the idea is similar to the current implementation of PSCI interface- create a 'psuedo-firmware register' to handle the firmware revisions. The series extends this idea to all the other hypercalls such as TRNG (True Random Number Generator), PV_TIME (Paravirtualized Time), and PTP (Precision Time protocol). For better categorization and future scaling, firmware registers are introduced based on the SMCCC service call owner (standard secure service, standard hypervisor service, and vendor specific hypervisor service). Each of these registers exposes the features employed in the form of a bitmap and are enveloped into a generic interface (for future expansion). Upon VM creation, all the features supported by each owner type are enabled. User-space/VMM can learn about the services currently enabled via GET_ONE_REG and can manipulate them via SET_ONE_REG interfaces. These 'writes' directly effect the bitmap, which is further checked when the guest tries to issue the hypercall and a decision is taken weather or not the hypercall is accessable to the guest. The interface works well across live-migrations where the VMM can simply save/restore these firmware registers using the existing IOCTL interfaces. Upon VM start (at least one vCPU runs), the registers become read-only and cannot be manupulated by the VMM. This is just to avoid providing conflicting views of the services to the guests. One of the problems that the series need to address is the enablement of the features carried by a firmware register, whose existance is not known to the VMM yet. A couple of ideas were discussed to handle this: 1) Upon the first SET_ONE_REG, clear all the firmware registers implicitly. It's the responsibility of the VMM to make sure that it configures all the registers that's known to it. 2) Contrary to #1, which implicitly clears all the registers, introduce a new capability to handle this explicitly. That is, the after learning about the services supported by the host, the VMM writes to the capability to explictly clear the registers. The series currently employs #1 just for the sake of completion, but is open for further discussion. The patches are based off of kvmarm-next 5.15-rc4, with the selftest patches from [2] applied. Patch-1 factors out the non-PSCI related interface from psci.c to hypercalls.c, as the series would extend the list in the upcoming patches. Patch-2 sets up a base environment to handle the 'writes' of firmware register- clear all the registers upon first 'write' and block 'writes' to the registers upon VM start. Patch-3 introduces the firmware register, KVM_REG_ARM_STD, which holds the standard secure services (such as TRNG). Patch-4 introduces the firmware register, KVM_REG_ARM_STD_HYP, which holds the standard hypervisor services (such as PV_TIME). Patch-5 introduces the firmware register, KVM_REG_ARM_VENDOR_HYP, which holds the vendor specific hypercall services. Patch-6 imports the firmware registers' UAPI definitions into tools/ for further use in selftests. Patch-7 imports the SMCCC definitions from linux/arm-smccc.h into tools/ for further use in selftests. Patch-8 adds the selftest to test the guest (using 'hvc') and VMM interfaces (SET/GET_ONE_REG). [1]: https://lore.kernel.org/kvmarm/874kbcpmlq.wl-maz@kernel.org/T/ [2]: https://lore.kernel.org/kvmarm/YUzgdbYk8BeCnHyW@google.com/ Raghavendra Rao Ananta (8): KVM: arm64: Factor out firmware register handling from psci.c KVM: arm64: Setup base for hypercall firmware registers KVM: arm64: Add standard secure service calls firmware register KVM: arm64: Add standard hypervisor service calls firmware register KVM: arm64: Add vendor hypervisor service calls firmware register tools: Import the firmware registers tools: Import ARM SMCCC definitions selftests: KVM: aarch64: Introduce hypercall ABI test .../virt/kvm/arm/{psci.rst => hypercalls.rst} | 59 ++- Documentation/virt/kvm/arm/index.rst | 2 +- arch/arm64/include/asm/kvm_host.h | 12 + arch/arm64/include/uapi/asm/kvm.h | 18 + arch/arm64/kvm/arm.c | 17 + arch/arm64/kvm/guest.c | 2 +- arch/arm64/kvm/hypercalls.c | 339 ++++++++++++++++- arch/arm64/kvm/psci.c | 167 +-------- arch/arm64/kvm/pvtime.c | 3 + arch/arm64/kvm/trng.c | 9 +- include/kvm/arm_hypercalls.h | 18 + include/kvm/arm_psci.h | 8 +- tools/arch/arm64/include/uapi/asm/kvm.h | 18 + tools/include/linux/arm-smccc.h | 188 ++++++++++ tools/testing/selftests/kvm/.gitignore | 1 + tools/testing/selftests/kvm/Makefile | 1 + .../selftests/kvm/aarch64/hypercalls.c | 340 ++++++++++++++++++ 17 files changed, 1018 insertions(+), 184 deletions(-) rename Documentation/virt/kvm/arm/{psci.rst => hypercalls.rst} (57%) create mode 100644 tools/include/linux/arm-smccc.h create mode 100644 tools/testing/selftests/kvm/aarch64/hypercalls.c