Message ID | 20211108190200.290957-1-jae.hyun.yoo@intel.com (mailing list archive) |
---|---|
Headers | show
Return-Path: <SRS0=LkCy=P3=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B37C433EF for <linux-arm-kernel@archiver.kernel.org>; Mon, 8 Nov 2021 18:43:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77A3A61506 for <linux-arm-kernel@archiver.kernel.org>; Mon, 8 Nov 2021 18:43:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 77A3A61506 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=kCxuxiX0bC+UyZFXAqIaTKqkQCkcNHeB40DEDzwPztI=; b=SSt5AciT0ndjv2 ybEhueDFiFc6gQRFlyMal38W8S5EuAjRUIqVZ8TkXmmNRai7IETjM2SiusBqBzSGu/buc3dRwGiq/ mktawp5pVY6RcUUux4d5oIWVJbeMmBoiM3dnblRcpCjhVZyzRvvI7r/Mf+I9p69akPWxDLX/RuOoI wI8/GE0EvSgEgimSYga6wVifiQvZvdFAljB7uifZYGQ7+xUWw9OxClAGIsJudKYVAqxY8HfZ4pIZV 1u3cwLHWWgzcbAWLR5U9cz8U16cM64fXuF39gfSIMDs6jlyEWR++Jm2GlVSAeACcAbMwfG5AAL8MT LCYxKZyKoeifqcc+FLSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk9bC-00HBRW-LX; Mon, 08 Nov 2021 18:42:30 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk9b7-00HBQ9-Cg for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 18:42:26 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="212332002" X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="212332002" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2021 10:42:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="503150685" Received: from maru.jf.intel.com ([10.54.51.77]) by orsmga008.jf.intel.com with ESMTP; 08 Nov 2021 10:42:19 -0800 From: jae.hyun.yoo@intel.com To: Rob Herring <robh+dt@kernel.org>, Corey Minyard <minyard@acm.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Cedric Le Goater <clg@kaod.org>, Haiyue Wang <haiyue.wang@linux.intel.com>, ChiaWei Wang <chiawei_wang@aspeedtech.com>, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net Subject: [PATCH v3 0/6] Add LCLK control into Aspeed LPC sub drivers Date: Mon, 8 Nov 2021 11:01:54 -0800 Message-Id: <20211108190200.290957-1-jae.hyun.yoo@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_104225_468991_3826296C X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
Add LCLK control into Aspeed LPC sub drivers
|
expand
|
From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Hello all, This series is for appliying below fix to all Aspped LPC sub drivers. https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang.bj@bytedance.com/ An LPC sub driver can be enabled without using the lpc-ctrl driver or it can be registered ahead of lpc-ctrl depends on each system configuration and this difference introduces that LPC can be enabled without heart beating of LCLK so it causes improper handling on host interrupts when the host sends interrupts in that time frame. Then kernel eventually forcibly disables the interrupt with dumping stack and printing a 'nobody cared this irq' message out. To prevent this issue, all LPC sub drivers should enable LCLK individually so this patch adds clock control logic into the remaining Aspeed LPC sub drivers. Please review this series. Thanks, Jae Changes sinve v2: * Rebased it on the latest master. * Made dts and bindigs changes' commit message more descriptive. * Simplified the -EPROBE_DEFER handling using dev_err_probe(). Changes sinve v1: * Added 'clocks' property into ibt and kcs-bmc bindings using 'aspeed,ast2400-ibt-bmc.txt' and 'aspeed,ast2400-kcs-bmc.yaml' respectively because these are not merged into 'aspeed-lpc.yaml' yet. The bindings merging could be done using a separate patch later. Jae Hyun Yoo (6): ARM: dts: aspeed: add LCLK setting into LPC IBT node dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property ipmi: bt: add clock control logic ARM: dts: aspeed: add LCLK setting into LPC KCS nodes dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property ipmi: kcs_bmc_aspeed: add clock control logic .../bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 2 ++ .../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++ arch/arm/boot/dts/aspeed-g4.dtsi | 1 + arch/arm/boot/dts/aspeed-g5.dtsi | 5 ++++ arch/arm/boot/dts/aspeed-g6.dtsi | 5 ++++ drivers/char/ipmi/bt-bmc.c | 21 +++++++++++++- drivers/char/ipmi/kcs_bmc_aspeed.c | 28 ++++++++++++++++--- 7 files changed, 64 insertions(+), 5 deletions(-)