mbox series

[v3,0/2] ACPI: Arm Generic Diagnostic Dump and Reset device

Message ID 20211231033725.21109-1-ilkka@os.amperecomputing.com (mailing list archive)
Headers show
Series ACPI: Arm Generic Diagnostic Dump and Reset device | expand

Message

Ilkka Koskinen Dec. 31, 2021, 3:37 a.m. UTC 
Arm Generic Diagnostic Dump and Reset device enables a maintainer to
request OS to perform a diagnostic dump and reset a system via SDEI
event or an interrupt. This patchset adds support for the SDEI path.

I do have a patch to enable the interrupt path as well but I'm holding
it back since AGDI table is missing interrupt configuration fields
(trigger type etc.).

The recently published specification is available at
https://developer.arm.com/documentation/den0093/latest

The patchset was tested on Ampere Altra/Mt. Jade.

The patchset applies on top of
  git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (642439a44411)


From v1:
     * Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init()
     * Changed the ACPICA patch upstreaming order comment in the paragraph above

From v2:
     * The first patch was split. The most of it was merged to ACPICA project
       at first and later ported to linux-acpi
       (fd919e37cb15914c6fe13e13d530a4f732407c6d). The rest are in the first patch.


Ilkka Koskinen (2):
  ACPI: tables: Add AGDI to the list of known table signatures
  ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset
    device

 drivers/acpi/arm64/Kconfig  |   8 +++
 drivers/acpi/arm64/Makefile |   1 +
 drivers/acpi/arm64/agdi.c   | 125 ++++++++++++++++++++++++++++++++++++
 drivers/acpi/tables.c       |   2 +-
 4 files changed, 135 insertions(+), 1 deletion(-)
 create mode 100644 drivers/acpi/arm64/agdi.c

Comments

Russell King (Oracle) Dec. 31, 2021, 10:25 a.m. UTC | #1 
On Thu, Dec 30, 2021 at 07:37:23PM -0800, Ilkka Koskinen wrote:
> Arm Generic Diagnostic Dump and Reset device enables a maintainer to
> request OS to perform a diagnostic dump and reset a system via SDEI
> event or an interrupt. This patchset adds support for the SDEI path.
> 
> I do have a patch to enable the interrupt path as well but I'm holding
> it back since AGDI table is missing interrupt configuration fields
> (trigger type etc.).
> 
> The recently published specification is available at
> https://developer.arm.com/documentation/den0093/latest
> 
> The patchset was tested on Ampere Altra/Mt. Jade.
> 
> The patchset applies on top of
>   git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (642439a44411)

LGTM, thanks!

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>