[v3,0/4] arm64: accelerate crc32_be

Message

Kevin Bracey Jan. 18, 2022, 10:23 a.m. UTC

Originally sent only to the arm-linux list - now including linux-crypto.
Ard suggested that Herbert take the series.

This series completes the arm64 crc32 helper acceleration by adding crc32_be.

There are plenty of users, for example OF.

To compensate for the extra supporting cruft in lib/crc32.c, a couple of minor
tidies.

changes since v2:
- no code change, but sent to Herbert+crypto with Catalin's ack for arm64

changes since v1:
- assembler style fixes from Ard's review

Kevin Bracey (4):
  lib/crc32.c: remove unneeded casts
  lib/crc32.c: Make crc32_be weak for arch override
  lib/crc32test.c: correct printed bytes count
  arm64: accelerate crc32_be

 arch/arm64/lib/crc32.S | 87 +++++++++++++++++++++++++++++++++++-------
 lib/crc32.c            | 14 +++----
 lib/crc32test.c        |  2 +-
 3 files changed, 80 insertions(+), 23 deletions(-)

Comments

Herbert Xu Jan. 28, 2022, 6:25 a.m. UTC | #1

On Tue, Jan 18, 2022 at 12:23:47PM +0200, Kevin Bracey wrote:
> Originally sent only to the arm-linux list - now including linux-crypto.
> Ard suggested that Herbert take the series.
> 
> This series completes the arm64 crc32 helper acceleration by adding crc32_be.
> 
> There are plenty of users, for example OF.
> 
> To compensate for the extra supporting cruft in lib/crc32.c, a couple of minor
> tidies.
> 
> changes since v2:
> - no code change, but sent to Herbert+crypto with Catalin's ack for arm64
> 
> changes since v1:
> - assembler style fixes from Ard's review
> 
> Kevin Bracey (4):
>   lib/crc32.c: remove unneeded casts
>   lib/crc32.c: Make crc32_be weak for arch override
>   lib/crc32test.c: correct printed bytes count
>   arm64: accelerate crc32_be
> 
>  arch/arm64/lib/crc32.S | 87 +++++++++++++++++++++++++++++++++++-------
>  lib/crc32.c            | 14 +++----
>  lib/crc32test.c        |  2 +-
>  3 files changed, 80 insertions(+), 23 deletions(-)

All applied.  Thanks.