[v4,0/8] ARM: mstar: cpupll

Message

Romain Perier Jan. 26, 2022, 5:55 p.m. UTC

This series adds a basic driver for the PLL that generates
the cpu clock on MStar/SigmaStar ARMv7 SoCs.

Unfortunately there isn't much documentation for this thing
so there are few magic values and guesses.

This needs to come after the MPLL DT changes.

Changes since v3:
- Added Reviewed-by on Daniel's patches
- Removed "[PATCH v3 8/9] ARM: mstar: Add OPP table for mercury5"

Changes since v2:
- Re-ordered Kconfig by name
- Re-ordered includes alphabetically and removed useless ones
- Used timeout for cpu_relax
- Returned DIV_ROUND_DOWN_ULL() directly in
  msc313_cpupll_frequencyforreg()
- Returned DIV_ROUND_DOWN_ULL() directly in
  msc313_cpupll_regforfrequecy()
- Reduced the number of lines for msc313_cpupll_of_match
- Removed CLK_IS_CRITICAL

Changes since v1:
- Re-worked the series and ensure that 'make dt_binding_check' passes.
  The required commit is merged now, so it is okay.
- Fixed coding style issues in the driver and makes check_patch.pl happy
- Added one more commit for extending the opp_table for infinity2m.

Daniel Palmer (7):
  dt-bindings: clk: mstar msc313 cpupll binding description
  clk: mstar: msc313 cpupll clk driver
  ARM: mstar: Add cpupll to base dtsi
  ARM: mstar: Link cpupll to cpu
  ARM: mstar: Link cpupll to second core
  ARM: mstar: Add OPP table for infinity
  ARM: mstar: Add OPP table for infinity3

Romain Perier (1):
  ARM: mstar: Extend opp_table for infinity2m

 .../bindings/clock/mstar,msc313-cpupll.yaml   |  45 ++++
 arch/arm/boot/dts/mstar-infinity.dtsi         |  34 +++
 arch/arm/boot/dts/mstar-infinity2m.dtsi       |  17 ++
 arch/arm/boot/dts/mstar-infinity3.dtsi        |  58 +++++
 arch/arm/boot/dts/mstar-v7.dtsi               |   9 +
 drivers/clk/mstar/Kconfig                     |   8 +
 drivers/clk/mstar/Makefile                    |   2 +-
 drivers/clk/mstar/clk-msc313-cpupll.c         | 221 ++++++++++++++++++
 8 files changed, 393 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
 create mode 100644 drivers/clk/mstar/clk-msc313-cpupll.c

Comments

Romain Perier Feb. 15, 2022, 6:05 p.m. UTC | #1

Hi,

ping :)

Regards,
Romain

Le mer. 26 janv. 2022 à 18:56, Romain Perier <[e-mail]> a écrit :
>
> This series adds a basic driver for the PLL that generates
> the cpu clock on MStar/SigmaStar ARMv7 SoCs.
>
> Unfortunately there isn't much documentation for this thing
> so there are few magic values and guesses.
>
> This needs to come after the MPLL DT changes.
>
> Changes since v3:
> - Added Reviewed-by on Daniel's patches
> - Removed "[PATCH v3 8/9] ARM: mstar: Add OPP table for mercury5"
>
> Changes since v2:
> - Re-ordered Kconfig by name
> - Re-ordered includes alphabetically and removed useless ones
> - Used timeout for cpu_relax
> - Returned DIV_ROUND_DOWN_ULL() directly in
>   msc313_cpupll_frequencyforreg()
> - Returned DIV_ROUND_DOWN_ULL() directly in
>   msc313_cpupll_regforfrequecy()
> - Reduced the number of lines for msc313_cpupll_of_match
> - Removed CLK_IS_CRITICAL
>
> Changes since v1:
> - Re-worked the series and ensure that 'make dt_binding_check' passes.
>   The required commit is merged now, so it is okay.
> - Fixed coding style issues in the driver and makes check_patch.pl happy
> - Added one more commit for extending the opp_table for infinity2m.
>
> Daniel Palmer (7):
>   dt-bindings: clk: mstar msc313 cpupll binding description
>   clk: mstar: msc313 cpupll clk driver
>   ARM: mstar: Add cpupll to base dtsi
>   ARM: mstar: Link cpupll to cpu
>   ARM: mstar: Link cpupll to second core
>   ARM: mstar: Add OPP table for infinity
>   ARM: mstar: Add OPP table for infinity3
>
> Romain Perier (1):
>   ARM: mstar: Extend opp_table for infinity2m
>
>  .../bindings/clock/mstar,msc313-cpupll.yaml   |  45 ++++
>  arch/arm/boot/dts/mstar-infinity.dtsi         |  34 +++
>  arch/arm/boot/dts/mstar-infinity2m.dtsi       |  17 ++
>  arch/arm/boot/dts/mstar-infinity3.dtsi        |  58 +++++
>  arch/arm/boot/dts/mstar-v7.dtsi               |   9 +
>  drivers/clk/mstar/Kconfig                     |   8 +
>  drivers/clk/mstar/Makefile                    |   2 +-
>  drivers/clk/mstar/clk-msc313-cpupll.c         | 221 ++++++++++++++++++
>  8 files changed, 393 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/mstar,msc313-cpupll.yaml
>  create mode 100644 drivers/clk/mstar/clk-msc313-cpupll.c
>
> --
> 2.34.1
>