| Message ID | 20220127161759.53553-1-alexandru.elisei@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: arm64: Improve PMU support on heterogeneous systems | expand |
On Thu, 27 Jan 2022 16:17:53 +0000, Alexandru Elisei wrote: > (CC'ing Peter Maydell in case this might be of interest to qemu) > > The series can be found on a branch at [1], and the kvmtool support at [2]. > > Detailed explanation of the issue and symptoms that the patches attempt to > correct can be found in the cover letter for v1 [3]. > > [...] Applied to next, thanks! [1/6] KVM: arm64: Do not change the PMU event filter after a VCPU has run commit: 5177fe91e4cf78a659aada2c9cf712db4d788481 [2/6] perf: Fix wrong name in comment for struct perf_cpu_context commit: 2093057ab879da1070c851b9e07126eaa86d0dfc [3/6] KVM: arm64: Keep a per-VM pointer to the default PMU commit: 46b18782147248b62f00e98a7f87abaf934951e8 [4/6] KVM: arm64: Keep a list of probed PMUs commit: db858060b1a788fba03711793dcaff19ea43286c [5/6] KVM: arm64: Add KVM_ARM_VCPU_PMU_V3_SET_PMU attribute commit: 6ee7fca2a4a023b14aa1f1f3c4f6c833116116ef [6/6] KVM: arm64: Refuse to run VCPU if the PMU doesn't match the physical CPU commit: 583cda1b0e7d5d49db5fc15db623166310e36bf6 Cheers, M.
(CC'ing Peter Maydell in case this might be of interest to qemu) The series can be found on a branch at [1], and the kvmtool support at [2]. Detailed explanation of the issue and symptoms that the patches attempt to correct can be found in the cover letter for v1 [3]. A summary of the problem is that on heterogeneous systems KVM will always use the same PMU for creating the VCPU events for *all* VCPUs regardless of the physical CPU on which the VCPU is running, leading to events suddenly stopping and resuming in the guest as the VCPU thread gets migrated across different CPUs. This series proposes to fix this behaviour by allowing the user to specify which physical PMU is used when creating the VCPU events needed for guest PMU emulation. When the PMU is set, KVM will refuse to the VCPU on a physical which is not part of the supported CPUs for the specified PMU. The restriction is that all VCPUs must use the same PMU to avoid emulating an asymmetric platform. The default behaviour stays the same - without userspace setting the PMU, events will stop counting if the VCPU is scheduled on the wrong CPU. Changes since v3 [4]: - Gathered Reviewed-by, thank you! - Rebased on top of v5.17-rc1, on top of which I added the USB Type-C fixes to get my rockpro64 to boot [6]. Shouldn't affect KVM in any way. - Patches #1 ("KVM: arm64: Do not change the PMU event filter after a VCPU has run") and #3 ("KVM: arm64: Keep a per-VM pointer to the default PMU") are new. - Use list_is_singular() in #4 ("KVM: arm64: Keep a list of probed PMUs"). - Return -EBUSY if a VCPU has run or if a PMU event filter has been set. - Use the PMU that the user specified to replace the default PMU at the VM level. Changes since v2 [5]: - Rebased on top of v5.16-rc5 - Check that all VCPUs have the same PMU set (or none at all). - Use the VCPU's PMUVer value when calculating the event mask, if a PMU is set for that VCPU. - Clear the unsupported CPU flag in vcpu_put(). - Move the handling of the unsupported CPU flag in kvm_vcpu_exit_request(). - Free the cpumask of supported CPUs if kvm_arch_vcpu_create() fails. Changes since v1 [3]: - Rebased on top of v5.16-rc4 - Implemented review comments: protect iterating through the list of PMUs with a mutex, documentation changes, initialize vcpu-arch.supported_cpus to cpu_possible_mask, changed vcpu->arch.cpu_not_supported to a VCPU flag, set exit reason to KVM_EXIT_FAIL_ENTRY and populate fail_entry when the VCPU is run on a CPU not in the PMU's supported cpumask. Many thanks for the review! [1] https://gitlab.arm.com/linux-arm/linux-ae/-/tree/pmu-big-little-fix-v4 [2] https://gitlab.arm.com/linux-arm/kvmtool-ae/-/tree/pmu-big-little-fix-v2 [3] https://www.spinics.net/lists/arm-kernel/msg933579.html [4] https://www.spinics.net/lists/kvm-arm/msg51079.html [5] https://www.spinics.net/lists/kvm-arm/msg50944.html [6] https://www.spinics.net/lists/linux-usb/msg221604.html Alexandru Elisei (4): perf: Fix wrong name in comment for struct perf_cpu_context KVM: arm64: Keep a list of probed PMUs KVM: arm64: Add KVM_ARM_VCPU_PMU_V3_SET_PMU attribute KVM: arm64: Refuse to run VCPU if the PMU doesn't match the physical CPU Marc Zyngier (2): KVM: arm64: Do not change the PMU event filter after a VCPU has run KVM: arm64: Keep a per-VM pointer to the default PMU Documentation/virt/kvm/devices/vcpu.rst | 34 +++++- arch/arm64/include/asm/kvm_host.h | 15 ++- arch/arm64/include/uapi/asm/kvm.h | 4 + arch/arm64/kvm/arm.c | 21 ++++ arch/arm64/kvm/pmu-emul.c | 141 ++++++++++++++++++------ include/kvm/arm_pmu.h | 5 + include/linux/perf_event.h | 2 +- tools/arch/arm64/include/uapi/asm/kvm.h | 1 + 8 files changed, 189 insertions(+), 34 deletions(-)