mbox series

[v2,0/6] add more tests to MTE kselftests

Message ID 20220203143620.30629-1-joey.gouly@arm.com (mailing list archive)
Headers show
Series add more tests to MTE kselftests | expand

Message

Joey Gouly Feb. 3, 2022, 2:36 p.m. UTC 
This is a series which refactors and then adds some extra tests for MTE
in the kselftest framework.

The issue that these tests are for was was fixed by Robin in
295cf156231c ("arm64: Avoid premature usercopy failure") and based on a
simplified example by Catalin [1].

They test some combinations of pointer offsets, sizes and syscalls to
exercise different paths in the kernel.

Changes since v1 [2]:
  - add a page_sz to the tests, for non-4K kernels
  - use loops to generate more tests and avoid long lines

Thanks,
Joey

[1] https://lore.kernel.org/all/20210624150911.GA25097@arm.com/
[2] https://lore.kernel.org/linux-arm-kernel/20220125150920.23955-1-joey.gouly@arm.com/

Joey Gouly (6):
  kselftest/arm64: mte: user_mem: introduce tag_offset and tag_len
  kselftest/arm64: mte: user_mem: rework error handling
  kselftest/arm64: mte: user_mem: check different offsets and sizes
  kselftest/arm64: mte: user_mem: add test type enum
  kselftest/arm64: mte: user_mem: add more test types
  kselftest/arm64: mte: user_mem: test more combinations of values

 .../selftests/arm64/mte/check_user_mem.c      | 196 +++++++++++++++---
 1 file changed, 162 insertions(+), 34 deletions(-)

Comments

Mark Brown Feb. 4, 2022, 2:18 p.m. UTC | #1 
On Thu, Feb 03, 2022 at 02:36:14PM +0000, Joey Gouly wrote:
> This is a series which refactors and then adds some extra tests for MTE
> in the kselftest framework.
> 
> The issue that these tests are for was was fixed by Robin in
> 295cf156231c ("arm64: Avoid premature usercopy failure") and based on a
> simplified example by Catalin [1].

Reviewed-by: Mark Brown <broonie@kernel.org>
Tested-by: Mark Brown <broonie@kernel.org>
Shuah Khan Feb. 4, 2022, 4:06 p.m. UTC | #2 
On 2/3/22 7:36 AM, Joey Gouly wrote:
> This is a series which refactors and then adds some extra tests for MTE
> in the kselftest framework.
> 
> The issue that these tests are for was was fixed by Robin in
> 295cf156231c ("arm64: Avoid premature usercopy failure") and based on a
> simplified example by Catalin [1].
> 
> They test some combinations of pointer offsets, sizes and syscalls to
> exercise different paths in the kernel.
> 
> Changes since v1 [2]:
>    - add a page_sz to the tests, for non-4K kernels
>    - use loops to generate more tests and avoid long lines
> 
> Thanks,
> Joey
> 
> [1] https://lore.kernel.org/all/20210624150911.GA25097@arm.com/
> [2] https://lore.kernel.org/linux-arm-kernel/20220125150920.23955-1-joey.gouly@arm.com/
> 
> Joey Gouly (6):
>    kselftest/arm64: mte: user_mem: introduce tag_offset and tag_len
>    kselftest/arm64: mte: user_mem: rework error handling
>    kselftest/arm64: mte: user_mem: check different offsets and sizes
>    kselftest/arm64: mte: user_mem: add test type enum
>    kselftest/arm64: mte: user_mem: add more test types
>    kselftest/arm64: mte: user_mem: test more combinations of values
> 
>   .../selftests/arm64/mte/check_user_mem.c      | 196 +++++++++++++++---
>   1 file changed, 162 insertions(+), 34 deletions(-)
> 

Just noticed that these patches aren't cc'ed to linux-kselftest list. Please
do so when you sen v2.

thanks,
-- Shuah