mbox series

[PACTH,v4,0/3] dt-bindings: crypto: Convert atmel-crypto to YAML

Message ID 20220211093922.456634-1-tudor.ambarus@microchip.com (mailing list archive)
Headers show
Series dt-bindings: crypto: Convert atmel-crypto to YAML | expand

Message

Tudor Ambarus Feb. 11, 2022, 9:39 a.m. UTC
Convert Atmel AES, TDES and SHA documentation to yaml format. There is one
binding defined per file. Keeping all bindings under the same yaml does
not make sense, as these are individual IPs. With the conversion the clock
and clock-names properties are made mandatory, to reflect how the drivers
treat them: when these properties are not provided, the drivers return
error.

v4:
- fix the AES example: match the node's address with the reg's address
- collect Krzysztof's R-b tags

v3:
- update license to (GPL-2.0-only OR BSD-2-Clause)
- add "Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries"
- add Krzysztof's R-b tag on patch 3/3. Chose to keep "maxItems: 1" instead
of "items" and "description" because that's what the guide at [1] suggests:
"# Cases that have only a single entry just need to express that with
maxItems"

[1] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html#annotated-example-schema

v2:
- use generic "crypto" node name
- drop redundant status = "okay" - it's the default state anyway
- introduce empty line for readability
- be specific and rename the bindings to let room for future possible
  lines of architectures.

Tudor Ambarus (3):
  dt-bindings: crypto: Convert Atmel AES to yaml
  dt-bindings: crypto: Convert Atmel TDES to yaml
  dt-bindings: crypto: Convert Atmel SHA to yaml

 .../crypto/atmel,at91sam9g46-aes.yaml         | 66 ++++++++++++++++++
 .../crypto/atmel,at91sam9g46-sha.yaml         | 60 ++++++++++++++++
 .../crypto/atmel,at91sam9g46-tdes.yaml        | 64 +++++++++++++++++
 .../bindings/crypto/atmel-crypto.txt          | 68 -------------------
 4 files changed, 190 insertions(+), 68 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
 create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml
 create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
 delete mode 100644 Documentation/devicetree/bindings/crypto/atmel-crypto.txt

Comments

Claudiu Beznea Feb. 11, 2022, 10:14 a.m. UTC | #1
On 11.02.2022 11:39, Tudor Ambarus wrote:
> Convert Atmel AES, TDES and SHA documentation to yaml format. There is one
> binding defined per file. Keeping all bindings under the same yaml does
> not make sense, as these are individual IPs. With the conversion the clock
> and clock-names properties are made mandatory, to reflect how the drivers
> treat them: when these properties are not provided, the drivers return
> error.
> 
> v4:
> - fix the AES example: match the node's address with the reg's address
> - collect Krzysztof's R-b tags
> 
> v3:
> - update license to (GPL-2.0-only OR BSD-2-Clause)
> - add "Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries"
> - add Krzysztof's R-b tag on patch 3/3. Chose to keep "maxItems: 1" instead
> of "items" and "description" because that's what the guide at [1] suggests:
> "# Cases that have only a single entry just need to express that with
> maxItems"
> 
> [1] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html#annotated-example-schema
> 
> v2:
> - use generic "crypto" node name
> - drop redundant status = "okay" - it's the default state anyway
> - introduce empty line for readability
> - be specific and rename the bindings to let room for future possible
>   lines of architectures.
> 
> Tudor Ambarus (3):
>   dt-bindings: crypto: Convert Atmel AES to yaml
>   dt-bindings: crypto: Convert Atmel TDES to yaml
>   dt-bindings: crypto: Convert Atmel SHA to yaml

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> 
>  .../crypto/atmel,at91sam9g46-aes.yaml         | 66 ++++++++++++++++++
>  .../crypto/atmel,at91sam9g46-sha.yaml         | 60 ++++++++++++++++
>  .../crypto/atmel,at91sam9g46-tdes.yaml        | 64 +++++++++++++++++
>  .../bindings/crypto/atmel-crypto.txt          | 68 -------------------
>  4 files changed, 190 insertions(+), 68 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
>  create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml
>  create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>  delete mode 100644 Documentation/devicetree/bindings/crypto/atmel-crypto.txt
>