From patchwork Thu Feb 17 13:12:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Marussi X-Patchwork-Id: 12750021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B670C433EF for ; Thu, 17 Feb 2022 13:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+nQESOF67BH63ebqlYmBONir0d3Iln8KQfM22711ZoI=; b=szu09lxccFPvJ/ RNuPB0lCvhw210yISb6rjEsjt3wFHnlwloFyI7uIeWsQW8VL5O+PVz3FIaNYoCrD5ig+wC6e0Qfpm YfYtPfrjs82HtIO3EzCr7v2rmK3A1H04CZJCWui6I3D1BunVUe1R5lj6tCrFSGdhh0cN6W7y6Q/s7 DX2+X8Rn6/xkVJUNKXEJ9PGITumEWhQyNo9nBMat6evhO0V8dY1OyOBMVcaeQXYlw8gA5OXzUce+w mRzWCR8lbzcLyAeYAfl8ZGuWG3s69Hq58+kfy5em3vJqYP5y3rmtoqF2JtXxloGB46d0TU8YsKr5G V++eB2O9oAdZrHx/K8eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKgal-00AY0o-Ks; Thu, 17 Feb 2022 13:13:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKgae-00AXyr-PX for linux-arm-kernel@lists.infradead.org; Thu, 17 Feb 2022 13:13:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD6D812FC; Thu, 17 Feb 2022 05:12:51 -0800 (PST) Received: from e120937-lin.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0CC0A3F66F; Thu, 17 Feb 2022 05:12:49 -0800 (PST) From: Cristian Marussi To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, peter.hilber@opensynergy.com, igor.skalkin@opensynergy.com, cristian.marussi@arm.com Subject: [PATCH v5 0/8] Add SCMI Virtio & Clock atomic support Date: Thu, 17 Feb 2022 13:12:26 +0000 Message-Id: <20220217131234.50328-1-cristian.marussi@arm.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_051256_954379_42606B41 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, This small series is the tail-subset of the previous V8 series about atomic support in SCMI [1], whose 8-patches head-subset has now been queued on [2]; as such, it is based on [2] on top of tag scmi-updates-5.17: commit 94d0cd1da14a ("firmware: arm_scmi: Add new parameter to mark_txdone") Patch [1/8] substitute virtio-scmi ready flag and lock with a reference counter to keep track of vio channels lifetime while removing the need of a wide spinlocked section (that would cause issues with introduction of virtio polling support) Patch [2/8] adds a few helpers to handle the TX free_list and a dedicated spinlock to reduce the reliance on the main one. Patch [3/8] adds polling mode to SCMI VirtIO transport in order to support atomic operations on such transport. Patches [4,5/8] introduce a new optional SCMI binding, atomic-threshold-us, to configure a platform specific time threshold used in the following patches to select with a finer grain which SCMI resources should be eligible for atomic operations when requested. Patch [6/8] exposes new SCMI Clock protocol operations to allow an SCMI user to request atomic mode on clock enable commands. Patch [7/8] adds support to SCMI Clock protocol for a new clock attributes field which advertises typical enable latency for a specific resource. Finally patch [8/8] add support for atomic operations to the SCMI clock driver; the underlying logic here is that we register with the Clock framework atomic-capable clock resources if and only if the backing SCMI transport is capable of atomic operations AND the specific clock resource has been advertised by the SCMI platform as having: clock_enable_latency <= atomic-threshold-us The idea is to avoid costly atomic busy-waiting for resources that have been advertised as 'slow' to operate upon. (i.e. a PLL vs a gating clock) To ease testing the whole series can be find at [3]. Any feedback/testing welcome as usual. Thanks, Cristian [1]: https://lore.kernel.org/linux-arm-kernel/20211220195646.44498-1-cristian.marussi@arm.com/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/tag/?h=scmi-updates-5.17 [3]: https://gitlab.arm.com/linux-arm/linux-cm/-/commits/scmi_atomic_clk_virtio_V5/ --- v4 --> v5 - dt_bindings: fixed example and removed dtschema warnings/errors - dt_bindings: added 'default: 0' clause - introduced vio_msg refcounts and helpers to avoid premature reuse of freed messages when both poling and IRQ path are active on a buffer - better handling of timed out polled messages on late replies using new VIO_MSG_POLL_TIMEOUT state - fixed comments on locks - removed unneeded virtqueue re-enable when fail to acquire channel in complete_cb V3 --> V4 - renamed optional DT property to atomic-threshold-us V2 --> V3 - split out virtio_ring RFC patch into a distinct series - calling virtqueue_broke_device when cleaning up channel - removed RFC tags from CLK related patches V1 --> V2 - added vio channel refcount support patch - reviewed free_list support and usage - added virtio_ring RFC patch - shrinked spinlocked section within virtio_poll_done to exclude virtqueue_poll call - removed poll_lock - use vio channel refcount acquire/release logic when polling - using new free_list accessors - added new dedicated pending_lock to access pending_cmds_list - fixed a few comments Cristian Marussi (8): firmware: arm_scmi: Add a virtio channel refcount firmware: arm_scmi: Review virtio free_list handling firmware: arm_scmi: Add atomic mode support to virtio transport dt-bindings: firmware: arm,scmi: Add atomic-threshold-us optional property firmware: arm_scmi: Support optional system wide atomic-threshold-us firmware: arm_scmi: Add atomic support to clock protocol firmware: arm_scmi: Add support for clock_enable_latency clk: scmi: Support atomic clock enable/disable API .../bindings/firmware/arm,scmi.yaml | 10 + drivers/clk/clk-scmi.c | 71 ++- drivers/firmware/arm_scmi/Kconfig | 15 + drivers/firmware/arm_scmi/clock.c | 34 +- drivers/firmware/arm_scmi/driver.c | 33 +- drivers/firmware/arm_scmi/virtio.c | 591 +++++++++++++++--- include/linux/scmi_protocol.h | 9 +- 7 files changed, 655 insertions(+), 108 deletions(-)