From patchwork Fri Feb 18 18:34:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 12751738 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A02DDC433EF for ; Fri, 18 Feb 2022 18:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Mu8fnI6e4dfivaIAuaVDUvmNvs0l/2Yghg5Ra9ka4c0=; b=jyjiM+fPOip7AP LQ4pNiijMz97EX1GeCKjg1NfTgNk368VAdw48Sr8so0bsNhiAtymw/vafhzJyi3VK4IP2fWesI80p ZAm3DlRZbwavtyHPeZ4GMQZ3VHuqT9fHa+Xnnrcxw2qwL9OAbRQjUp3tl65VStg7I5fzTC619eMnw gDD6i8jPsS1/c2VAvpVGIqY8SvxXCuyCsoGxwGsZsWjoaRS5mft2ASNPDWrEstbupA3/rSSMqgh6B SBZQKs9ObNdLwAK1THkhXQUL2z+bpgSSZb06U9NtkeHsf87xTLC3Ffq3iZJ42PKH1ZRjqWg+pCfmL 5krfBR2qr+zQan3kZq7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nL85Y-00FVig-JB; Fri, 18 Feb 2022 18:34:40 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nL85V-00FVhy-1a for linux-arm-kernel@lists.infradead.org; Fri, 18 Feb 2022 18:34:38 +0000 Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 70A3040004; Fri, 18 Feb 2022 18:34:28 +0000 (UTC) From: Jacopo Mondi To: slongerbeam@gmail.com, p.zabel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, martin.kepplinger@puri.sm, rmfrfs@gmail.com, xavier.roumegue@oss.nxp.com, alexander.stein@ew.tq-group.com, dorota.czaplejewicz@puri.sm Cc: kernel@pengutronix.de, linux-imx@nxp.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Jacopo Mondi Subject: [PATCH v2 0/7] media: imx: Destage imx7-mipi-csis Date: Fri, 18 Feb 2022 19:34:14 +0100 Message-Id: <20220218183421.583874-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220218_103437_285399_C85418ED X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello this series includes patches from two series previously sent: https://lore.kernel.org/linux-media/20220119112024.11339-1-jacopo@jmondi.org/ https://lore.kernel.org/linux-media/20220211180216.290133-1-jacopo@jmondi.org/ v1: https://lore.kernel.org/linux-media/20220214184318.409208-1-jacopo@jmondi.org/T/#t Which can now be marked as superseded. The first 2 patches performs the de-staging of the imx7-mipi-csis driver and are now reviewed. The rest of the series builds on top of the comment received on: https://lore.kernel.org/linux-media/20220119112024.11339-3-jacopo@jmondi.org/ If DUAL pixel mode is used in the CSIS driver, then the CSI block of the IMX8MM SoC needs to be operated in dual mode as well. To do so, use the image format sample size to determine in the CSI bridge if dual or single mode should be used. Laurent could you test on MM to see if it works now ? On top two small patches I was carrying in my tree to add more formats to the CSIS driver, the last one with the caveat that RGB24 is transmitted on the wire with one format and stored in memory with a different one. Series based on top of the most recent media master branch. Thanks j v1->v2: - Remove per-SoC handling in CSI bridge and only use image formats - Add TODO note to the staging driver - Fix PIXEL_DUAL mode comments for imx-mipi-csis - Add output format translation to imx-mipi-csis to handle RGB24 Jacopo Mondi (7): media: imx: De-stage imx7-mipi-csis media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c media: imx: imx7-media-csi: Use dual sampling for YUV 1X16 media: imx: imx-mipi-csis: Set PIXEL_MODE for YUV422 media: imx: imx-mipi-csis: Add RGB565_1X16 media: imx: imx-mipi-csis: Add BGR888 media: imx: imx-mipi-csis: Add output format Documentation/admin-guide/media/imx7.rst | 2 +- ...-mipi-csi2.yaml => nxp,imx-mipi-csi2.yaml} | 2 +- MAINTAINERS | 4 +- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 1 + drivers/media/platform/imx/Kconfig | 24 ++++++++ drivers/media/platform/imx/Makefile | 1 + .../platform/imx/imx-mipi-csis.c} | 59 +++++++++++++++++-- drivers/staging/media/imx/Makefile | 1 - drivers/staging/media/imx/TODO | 26 ++++++++ drivers/staging/media/imx/imx7-media-csi.c | 8 ++- 11 files changed, 117 insertions(+), 12 deletions(-) rename Documentation/devicetree/bindings/media/{nxp,imx7-mipi-csi2.yaml => nxp,imx-mipi-csi2.yaml} (98%) create mode 100644 drivers/media/platform/imx/Kconfig create mode 100644 drivers/media/platform/imx/Makefile rename drivers/{staging/media/imx/imx7-mipi-csis.c => media/platform/imx/imx-mipi-csis.c} (95%) Tested-by: Laurent Pinchart # On i.MX8MM --- 2.35.0