mbox series

[v2,0/7] tty: serial: samsung: minor fixes/cleanups

Message ID 20220307080810.53847-1-krzysztof.kozlowski@canonical.com (mailing list archive)
Headers show
Series tty: serial: samsung: minor fixes/cleanups | expand

Message

Krzysztof Kozlowski March 7, 2022, 8:08 a.m. UTC 
Hi,

Changes since v1:
1. Patch 3: remove unneeded parenthesis and module alias change (Jiri).
2. Patch 3: move unrelated "constify" bits to patch 6.
3. Patch 5: fix typo.
4. Add review tags.

Best regards,
Krzysztof

Krzysztof Kozlowski (7):
  tty: serial: samsung: embed s3c24xx_uart_info in parent structure
  tty: serial: samsung: embed s3c2410_uartcfg in parent structure
  tty: serial: samsung: constify s3c24xx_serial_drv_data
  tty: serial: samsung: constify UART name
  tty: serial: samsung: constify s3c24xx_serial_drv_data members
  tty: serial: samsung: constify variables and pointers
  tty: serial: samsung: simplify getting OF match data

 drivers/tty/serial/samsung_tty.c | 225 +++++++++++++++----------------
 1 file changed, 109 insertions(+), 116 deletions(-)

Comments

Alim Akhtar March 7, 2022, 6:21 p.m. UTC | #1 
Hi Krzysztof

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Monday, March 7, 2022 1:38 PM
>To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Jiri Slaby <jirislaby@kernel.org>; linux-arm-
>kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
>serial@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [PATCH v2 0/7] tty: serial: samsung: minor fixes/cleanups
>
>Hi,
>
>Changes since v1:
>1. Patch 3: remove unneeded parenthesis and module alias change (Jiri).
>2. Patch 3: move unrelated "constify" bits to patch 6.
>3. Patch 5: fix typo.
>4. Add review tags.
>
>Best regards,
>Krzysztof
>
>Krzysztof Kozlowski (7):
>  tty: serial: samsung: embed s3c24xx_uart_info in parent structure
>  tty: serial: samsung: embed s3c2410_uartcfg in parent structure
>  tty: serial: samsung: constify s3c24xx_serial_drv_data
>  tty: serial: samsung: constify UART name
>  tty: serial: samsung: constify s3c24xx_serial_drv_data members
>  tty: serial: samsung: constify variables and pointers
>  tty: serial: samsung: simplify getting OF match data
>
> drivers/tty/serial/samsung_tty.c | 225 +++++++++++++++----------------
> 1 file changed, 109 insertions(+), 116 deletions(-)
>

For this series feel free to add
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

Sanity tested on Exynos7 Espresso board, boot log and other console prints
after boot looks fine, so

Tested-by: Alim Akhtar <alim.akhtar@samsung.com>

>--
>2.32.0